From: Vladimir Makarov <vmakarov@redhat.com>
To: Segher Boessenkool <segher@kernel.crashing.org>, gcc-patches@gcc.gnu.org
Cc: Andreas.Krebbel@de.ibm.com
Subject: Re: [PATCH] lra: Clobbers in a parallel are earlyclobbers (PR83245)
Date: Mon, 04 Dec 2017 00:13:00 -0000 [thread overview]
Message-ID: <1731b46a-10ea-42c2-2e57-f3ed859ced76@redhat.com> (raw)
In-Reply-To: <7ae9f258fb2ffe40746ed9ec3592e8c0ca5d9575.1512240911.git.segher@kernel.crashing.org>
On 12/02/2017 01:59 PM, Segher Boessenkool wrote:
> The documentation (rtl.texi) says:
>
> When a @code{clobber} expression for a register appears inside a
> @code{parallel} with other side effects, the register allocator
> guarantees that the register is unoccupied both before and after that
> insn if it is a hard register clobber.
>
> and at least the rs6000 backend relies on that (see PR83245). This
> patch restores that behaviour.
>
> Registers that are also used as operands in the instruction are not
> treated as earlyclobber, so such insns also still work (PR80818, an
> s390 testcase).
>
> Tested on powerpc64-linux {-m32,-m64}, also tested with a s390 cross.
>
> Andreas, can you confirm this really still works after this patch?
> Vlad, if so, is this okay for trunk?
>
>
>
Yes, it is ok for me in any case, even if it creates a trouble for s390
PR80818. Sorry for the inconvenience from my patch. I should have been
more careful.
next prev parent reply other threads:[~2017-12-04 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 18:59 Segher Boessenkool
2017-12-04 0:13 ` Vladimir Makarov [this message]
2017-12-04 9:23 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1731b46a-10ea-42c2-2e57-f3ed859ced76@redhat.com \
--to=vmakarov@redhat.com \
--cc=Andreas.Krebbel@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).