public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@adacore.com>
To: gcc-patches@gcc.gnu.org, Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH, i386]: Extend TARGET_READ_MODIFY{,_WRITE} peepholes to all integer modes
Date: Fri, 29 Apr 2016 07:47:00 -0000	[thread overview]
Message-ID: <1744658.Bp6bspGrA0@polaris> (raw)
In-Reply-To: <CAFULd4bqYNLd0P4Vb7Oi3F0Y2ieDNG0peGqeD9kww7s6jkSCMw@mail.gmail.com>

> While looking at the insn enable condition, I noticed that we don't
> use "probe_stack" pattern any more, as the stack check loop is now
> implemented in a different way.

Yes, we do, probe_stack is a standard pattern called by the middle-end.

> 2016-04-28  Uros Bizjak  <ubizjak@gmail.com>
> 
>     * config/i386/i386.md (peephole2s for operations with memory inputs):
>     Use SWI mode iterator.
>     (peephole2s for operations with memory outputs): Ditto.
>     Do not check for stack checking probe.
> 
>     (probe_stack): Remove expander.
> 
> Patch was bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.

How did you test it exactly?

                === acats tests ===
FAIL:   c52103x
FAIL:   c52104x

-- 
Eric Botcazou

  reply	other threads:[~2016-04-29  7:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 19:16 Uros Bizjak
2016-04-29  7:47 ` Eric Botcazou [this message]
2016-04-29  7:50   ` Uros Bizjak
2016-04-29  7:58     ` Eric Botcazou
2016-04-29  9:30       ` Uros Bizjak
2016-04-29 10:17         ` Eric Botcazou
2016-04-29 10:51           ` Uros Bizjak
2016-04-29 11:23             ` Eric Botcazou
2016-04-29 11:52               ` Uros Bizjak
2016-04-29 14:30                 ` Eric Botcazou
2016-04-29 14:44                   ` Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1744658.Bp6bspGrA0@polaris \
    --to=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).