From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93255 invoked by alias); 17 Oct 2016 11:05:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 93238 invoked by uid 89); 17 Oct 2016 11:05:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.0 required=5.0 tests=BAYES_00,MEDICAL_SUBJECT,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:864 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Oct 2016 11:05:53 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF0E44E4D7; Mon, 17 Oct 2016 11:05:52 +0000 (UTC) Received: from localhost.localdomain (vpn1-6-95.ams2.redhat.com [10.36.6.95]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9HB5plX011386; Mon, 17 Oct 2016 07:05:51 -0400 Subject: Re: [PATCH] read-md.c: Move various state to within class rtx_reader To: David Malcolm , Richard Sandiford , gcc-patches@gcc.gnu.org References: <87mvi9dydt.fsf@googlemail.com> <1476468970-12787-1-git-send-email-dmalcolm@redhat.com> From: Bernd Schmidt Message-ID: <174a9d45-3b43-618e-e80f-461a5d51b2a2@redhat.com> Date: Mon, 17 Oct 2016 11:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476468970-12787-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg01280.txt.bz2 On 10/14/2016 08:16 PM, David Malcolm wrote: > In this version of the patch, I've moved the global variables to > be fields of class rtx_reader, moving their setup to the constructor. > The patch adds matching cleanups to the destructor, along with a > cleanup of m_base_dir. > > Doing so requires updating the various users of these fields. > Where it seemed appropriate, I made the functions be methods > of rtx_reader. In other cases, I updated them to access the fields > via rtx_reader_ptr. > > Successfully bootstrapped®rtested on x86_64-pc-linux-gnu. Well, at least the actual patch doesn't look as scary as the ChangeLog. There are things one could discuss, like maybe gensupport should just have its own string obstack. But on the whole I think this is reasonable, so OK. Bernd