public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Harwath, Frederik" <frederik@codesourcery.com>
To: Thomas Schwinge <thomas@codesourcery.com>, <seurer@gcc.gnu.org>
Cc: <gcc-patches@gcc.gnu.org>, <tobias@codesourcery.com>
Subject: [PATCH, committed] Fix PR92901: Change test expectation for C++ in OpenACC test clause-locations.c
Date: Wed, 11 Dec 2019 08:38:00 -0000	[thread overview]
Message-ID: <174bb8d3-17f7-01ff-f6a8-5699b299b75d@codesourcery.com> (raw)
In-Reply-To: <17425c95-5819-7141-95cf-0abf934274d2@codesourcery.com>

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Hi,
I have committed the attached trivial patch to trunk as r279215. The columns of the clause locations are reported differently
by the C and C++ front-end and hence we need different test expectations for both languages.

Best regards,
Frederik

[-- Attachment #2: r279215.patch --]
[-- Type: text/x-patch, Size: 1445 bytes --]

------------------------------------------------------------------------
r279215 | frederik | 2019-12-11 09:26:18 +0100 (Mi, 11 Dez 2019) | 12 lines

Fix PR92901: Change test expectation for C++ in OpenACC test clause-locations.c 

The columns of the clause locations that are reported for C and C++ are
different and hence we need separate test expectations for both languages.

2019-12-11  Frederik Harwath  <frederik@codesourcery.com>

	PR other/92901
	/gcc/testsuite/
	* c-c++-common/clause-locations.c: Adjust test expectation for C++.


------------------------------------------------------------------------

Index: gcc/testsuite/c-c++-common/goacc/clause-locations.c
===================================================================
--- gcc/testsuite/c-c++-common/goacc/clause-locations.c	(revision 279214)
+++ gcc/testsuite/c-c++-common/goacc/clause-locations.c	(working copy)
@@ -9,7 +9,9 @@
     #pragma acc loop reduction(+:sum)
     for (i = 1; i <= 10; i++)
       {
-        #pragma acc loop reduction(-:diff) reduction(-:sum)  /* { dg-warning "53: conflicting reduction operations for .sum." } */
+        #pragma acc loop reduction(-:diff) reduction(-:sum)
+	/* { dg-warning "53: conflicting reduction operations for .sum." "" { target c } .-1 } */
+	/* { dg-warning "56: conflicting reduction operations for .sum." "" { target c++ } .-2 } */
 	for (j = 1; j <= 10; j++)
 	  sum = 1;
       }

  reply	other threads:[~2019-12-11  8:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 13:38 [Patch, Fortran] PR 92793 - fix column used for error diagnostic Tobias Burnus
2019-12-04 14:30 ` Harwath, Frederik
2019-12-06  8:02 ` *PING* – " Tobias Burnus
2019-12-06 16:42   ` Janne Blomqvist
2019-12-09 15:58 ` [PATCH] Fix column information for omp_clauses in Fortran code Harwath, Frederik
2019-12-09 16:03   ` Tobias Burnus
2019-12-10 14:23   ` [PATCH 2/2] Add tests to verify OpenACC clause locations Frederik Harwath
2019-12-10 14:23   ` [PATCH 1/2] Use clause locations in OpenACC nested reduction warnings Frederik Harwath
2019-12-10 14:23   ` [PATCH 0/2] Add tests to verify OpenACC clause locations Frederik Harwath
2019-12-10 14:44     ` Thomas Schwinge
2019-12-10 15:12       ` Harwath, Frederik
2019-12-10 16:22       ` Harwath, Frederik
2019-12-11  8:38         ` Harwath, Frederik [this message]
2020-11-03  8:17     ` Thomas Schwinge
2020-11-03 21:34       ` Thomas Schwinge
2020-11-03  8:26   ` [PATCH] Fix column information for omp_clauses in Fortran code Thomas Schwinge
2020-10-30 10:35 ` [Patch, Fortran] PR 92793 - fix column used for error diagnostic Thomas Schwinge
2020-10-30 10:47   ` Thomas Schwinge
2020-10-30 11:16     ` Tobias Burnus
2020-11-02 13:43       ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174bb8d3-17f7-01ff-f6a8-5699b299b75d@codesourcery.com \
    --to=frederik@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=seurer@gcc.gnu.org \
    --cc=thomas@codesourcery.com \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).