[PATCH][x86]Fix for false-positives results of runtime tests on machines not supporting AVX512F

[PATCH][x86]Fix for false-positives results of runtime tests on machines not supporting AVX512F

[Peryt, Sebastian]

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

Hi,

The attached patch fixes the issue of tests' false-positive results generation on machines not supporting AVX512F feature. Currently when any runtime test intended for AVX512F feature will be run on non-AVX512F machine the best it can produce to inform of such a case is print SKIPPED, if debug is enabled. But in any case the return value is 0, which is exactly the same as if the test passed what might be misleading when looking at gcc.sum summary values. With this patch such tests can be properly recognized during make check as unexpected failures.

gcc/testsuite/
	* gcc.target/i386/avx512f-check.h: Return value modified for skipped test.



Please let me know if such fix can be accepted.

Thanks,
Sebastian

[-- Attachment #2: AVX512F_TESTS_VERIFICATION_PATCH.patch --]
[-- Type: application/octet-stream, Size: 334 bytes --]

diff --git a/gcc/testsuite/gcc.target/i386/avx512f-check.h b/gcc/testsuite/gcc.target/i386/avx512f-check.h
index 811184b..a949ada 100644
--- a/gcc/testsuite/gcc.target/i386/avx512f-check.h
+++ b/gcc/testsuite/gcc.target/i386/avx512f-check.h
@@ -43,5 +43,5 @@ main ()
     printf ("SKIPPED\n");
 #endif
 
-  return 0;
+  return -1;
 }

Re: [PATCH][x86]Fix for false-positives results of runtime tests on machines not supporting AVX512F

[Uros Bizjak]

On Tue, May 30, 2017 at 7:59 AM, Peryt, Sebastian
<sebastian.peryt@intel.com> wrote:
> Hi,
>
> The attached patch fixes the issue of tests' false-positive results generation on machines not supporting AVX512F feature. Currently when any runtime test intended for AVX512F feature will be run on non-AVX512F machine the best it can produce to inform of such a case is print SKIPPED, if debug is enabled. But in any case the return value is 0, which is exactly the same as if the test passed what might be misleading when looking at gcc.sum summary values. With this patch such tests can be properly recognized during make check as unexpected failures.
>
> gcc/testsuite/
>         * gcc.target/i386/avx512f-check.h: Return value modified for skipped test.
>
>
>
> Please let me know if such fix can be accepted.

No, this is by design. It is not a failure, if the target doesn't
support requested runtime feature. The test shoudl be marked
UNSUPPORTED in this case, but I don't think DejaGnu infrastructure
allows that.

Uros.

RE: [PATCH][x86]Fix for false-positives results of runtime tests on machines not supporting AVX512F

[Peryt, Sebastian]

Thank you very much for clarification. Yes, you are right, it would be better if such test would
be marked UNSUPPORTED.

Sebastian

-----Original Message-----
From: Uros Bizjak [mailto:ubizjak@gmail.com] 
Sent: Tuesday, May 30, 2017 8:23 AM
To: Peryt, Sebastian <sebastian.peryt@intel.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][x86]Fix for false-positives results of runtime tests on machines not supporting AVX512F

On Tue, May 30, 2017 at 7:59 AM, Peryt, Sebastian <sebastian.peryt@intel.com> wrote:
> Hi,
>
> The attached patch fixes the issue of tests' false-positive results generation on machines not supporting AVX512F feature. Currently when any runtime test intended for AVX512F feature will be run on non-AVX512F machine the best it can produce to inform of such a case is print SKIPPED, if debug is enabled. But in any case the return value is 0, which is exactly the same as if the test passed what might be misleading when looking at gcc.sum summary values. With this patch such tests can be properly recognized during make check as unexpected failures.
>
> gcc/testsuite/
>         * gcc.target/i386/avx512f-check.h: Return value modified for skipped test.
>
>
>
> Please let me know if such fix can be accepted.

No, this is by design. It is not a failure, if the target doesn't support requested runtime feature. The test shoudl be marked UNSUPPORTED in this case, but I don't think DejaGnu infrastructure allows that.

Uros.