From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id C70A8385841B; Sat, 30 Oct 2021 18:11:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C70A8385841B X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gluon.fritz.box ([79.251.10.174]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MYvY8-1mCCnb0G0m-00Unrh; Sat, 30 Oct 2021 20:11:15 +0200 Subject: Re: [PATCH] Fortran: adjust error message for SHORT and LONG intrinsics To: Manfred Schwarb , fortran@gcc.gnu.org Cc: gcc-patches@gcc.gnu.org Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <6189797e-b646-fb2b-0d23-befa8ed1aa55@gmx.ch> From: Harald Anlauf Message-ID: <17764b83-6c60-d9a1-3393-5966405e0787@gmx.de> Date: Sat, 30 Oct 2021 20:11:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:g6RASEO4LT9C+C99fiXSLz5PzheKQaBY3fnoeS2aW4gwhAi13WN TFh1G4BqciR38piQr+8fO2av5izevygGERqArrGIY9fDE759YQ79HtCP3x9/12wC1+ko2bE 0aTFbpgp8BJ4aRNVF5CEkbSCQN7w9BUCfxkP7X4wBzbT1y6BgeCVIEL+jdn2iSAfar0Z1YY rqdBfd+Dv53MO1N4uuW+w== X-UI-Out-Filterresults: notjunk:1;V03:K0:zBgOnH2bMHI=:wFlViPTSH7OyDG+hSaQJYo 5+GhM/3pRoF7rK9Em1vr/b0LW5JY7gLpLfL20Xi3pNiq1vY+lni41mvGxzhyhHTfHZmHXiZBr IPLWGhPlOcCgd0t9OxBMwVIVcoLMQvZ3fmEfRdITK5KBbX2NCbD+q9n0GSVWjy7Vu4TrYyD+K CLO/hRgylfDrWMIGC2C+oHVnkS7N+6BQsfwyXgHAxvFTZwJ6nJ0NXgByLPj00coZCPCFdmzXl TNZQ0CRfqjNu7MD19fFNDRt73se74Z4+JFJ59jgG5cUwGQNL+LgZfQByCWYOL/HHGuH5uG4tp tjEUJRv5KZrynAXIuHrK4BBA+SFsiNTNcAkIlFg396KcZf1HUz4wLDWeOssrUXOOoR4vxLrcA 8Q1PmdNFshWHftd7s0panQHm/hH6dnzVp4cBi9v/ccsOPYunZIEb59N7//GN99NMtktYu7Rt7 CitgSjtM8svGjU0B9xAKYnT65l6yr1wzu41eHZU0HE9fCvh4X/fjfy+WaJMW9ahYEVkW8Ht/u PqtHmcP+XKnvT5loahwD0xzjSaeX5Uu+tgzYmKWiml9LRcLldBCw0Z6g+dF+JxWx2UYiUt5XA 2083ZxXmJ3xiSE8JP7Fr9GLKQxHkfMovO+MlucUmS13ypX/epDXdgioIzypDvMcYQzHdNh+tV ZRAZfuSfNbmNoIvhqdUtNx6qQrYiJ1LtIeGGx/U6XyC/dNigzkLFx87KglFuPcNGGQvQzKFb4 OLTQZyLsOBMMteledllo+Jcmxb1ikp2Z+2m+r6gVlld4kao8+I/NXF/ubBNF05d+3Ft9JKzpC s4x6gQlgrYOaKm2HJot5/gTlL67FScBjoRsUg6YkDZiJvN3yjZQzOM+qt1ThzbEV+6LEoU3wY 5YMYHPaupdV0ekjIeetMqlwRxF+kPaPW2BdpSblGPTTqR0Y48OJnFLcEeMX6utjkn4BJcevN/ qQxWAPb5g/Sz6UQ6AGGauDHbFg2GFX+u4IlDvwQ16EwUyzp1BNrQjOcG/fOZb89pO6JT0VUwX zR8HnWyQ1m4ywI2Czmv43W3x7j87NADRlVMx1XnznXdW139573/9mQgIHCjH5TRNSaC5Ijk91 XKANSS5ZvuJ2NU= X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2021 18:11:19 -0000 Committed as r12-4807. Thanks for the patch! Harald Am 30.10.21 um 01:15 schrieb Manfred Schwarb via Gcc-patches: > Am 29.10.21 um 21:51 schrieb Harald Anlauf via Fortran: >> Hi Manfred, >> >> Am 29.10.21 um 16:12 schrieb Manfred Schwarb via Fortran: >>> Hi, >>> >>> on 2019-07-23, support for SHORT and LONG intrinsics were removed be S= teve Kargl by >>> adding an error message in check.c. However, the error message >>> Error: 'long' intrinsic subprogram at (1) has been deprecated >>> is misleading, as support has been disabled by this patch. >>> >>> Adjust the error message. This error message does not appear in the te= stsuite AFAIK. >> >> the patch looks fine. A testcase checking the error message is missing= , >> as well as a ChangeLog entry. > > Sorry, forgot the changelog entry, I added it to the patch now. > Testcase was missing already before, but I added a trivial test to the p= atch for completeness. > >> >> Thanks, >> Harald >> >>> Signed-off-by Manfred Schwarb >>> >>> >>> [Note: I do not have commit access] >>> >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 05B663857C5E for ; Sat, 30 Oct 2021 18:11:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 05B663857C5E Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mgsp8-0003Uj-WD for gcc-patches@gcc.gnu.org; Sat, 30 Oct 2021 20:11:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: [PATCH] Fortran: adjust error message for SHORT and LONG intrinsics Date: Sat, 30 Oct 2021 20:11:13 +0200 Message-ID: <17764b83-6c60-d9a1-3393-5966405e0787@gmx.de> References: <6189797e-b646-fb2b-0d23-befa8ed1aa55@gmx.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: Content-Language: en-US Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2021 18:11:25 -0000 Message-ID: <20211030181113.BtPZ7p8ASsFLslew83KNgN_oXzkAxSKVLc7HOaiwptM@z> Committed as r12-4807. Thanks for the patch! Harald Am 30.10.21 um 01:15 schrieb Manfred Schwarb via Gcc-patches: > Am 29.10.21 um 21:51 schrieb Harald Anlauf via Fortran: >> Hi Manfred, >> >> Am 29.10.21 um 16:12 schrieb Manfred Schwarb via Fortran: >>> Hi, >>> >>> on 2019-07-23, support for SHORT and LONG intrinsics were removed be Steve Kargl by >>> adding an error message in check.c. However, the error message >>> Error: 'long' intrinsic subprogram at (1) has been deprecated >>> is misleading, as support has been disabled by this patch. >>> >>> Adjust the error message. This error message does not appear in the testsuite AFAIK. >> >> the patch looks fine. A testcase checking the error message is missing, >> as well as a ChangeLog entry. > > Sorry, forgot the changelog entry, I added it to the patch now. > Testcase was missing already before, but I added a trivial test to the patch for completeness. > >> >> Thanks, >> Harald >> >>> Signed-off-by Manfred Schwarb >>> >>> >>> [Note: I do not have commit access] >>> >> >> >