From: Michael Eager <eager@eagercon.com>
To: "Frager, Neal" <neal.frager@amd.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"eager@eagerm.com" <eager@eagerm.com>
Cc: "Erkiaga Elorza, Ibai" <ibai.erkiaga-elorza@amd.com>,
"Mekala, Nagaraju" <nagaraju.mekala@amd.com>,
"Hatle, Mark" <mark.hatle@amd.com>,
"Mutyala, Sadanand" <sadanand.mutyala@amd.com>,
"Nali, Appa Rao" <appa.rao.nali@amd.com>,
"Hunsigida, Vidhumouli" <vidhumouli.hunsigida@amd.com>,
"luca.ceresoli@bootlin.com" <luca.ceresoli@bootlin.com>
Subject: Re: [PATCH v6 1/1] gcc: config: microblaze: fix cpu version check
Date: Tue, 31 Oct 2023 10:45:30 -0700 [thread overview]
Message-ID: <1783c0ba-3d0d-4754-b25c-ba6c9320c406@eagercon.com> (raw)
In-Reply-To: <CH2PR12MB500410372F263579B7499E81F0A0A@CH2PR12MB5004.namprd12.prod.outlook.com>
On 10/31/23 09:41, Frager, Neal wrote:
> Hi Michael,
>
>> The MICROBLAZE_VERSION_COMPARE was incorrectly using strcasecmp
>> instead of strverscmp to check the mcpu version against feature
>> options. By simply changing the define to use strverscmp, the new
>> version 10.0 is treated correctly as a higher version than previous
>> versions.
>>
>> Signed-off-by: Neal Frager <neal.frager@amd.com>
>
>> Added to commit message;
>> Fix incorrect warning with -mcpu=10.0:
>> warning: '-mxl-multiply-high' can be used only with
>> '-mcpu=v6.00.a' or greater
>
>> ---
>> V1->V2:
>> - No need to create a new microblaze specific version check
>> routine as strverscmp is the correct solution.
>> V2->V3:
>> - Changed mcpu define for microblaze isa testsuite examples.
>> V3->V4:
>> - Added ChangeLog
>> V4->V5:
>> - Added testsuite ChangeLog
>> V5->V6:
>> - Updated testsuite ChangeLog to include all files
>> ---
>> gcc/ChangeLog | 4 ++++
>> gcc/config/microblaze/microblaze.cc | 2 +-
>> gcc/testsuite/ChangeLog | 22 +++++++++++++++++++
>> .../gcc.target/microblaze/isa/bshift.c | 2 +-
>> gcc/testsuite/gcc.target/microblaze/isa/div.c | 2 +-
>> .../gcc.target/microblaze/isa/fcmp1.c | 2 +-
>> .../gcc.target/microblaze/isa/fcmp2.c | 2 +-
>> .../gcc.target/microblaze/isa/fcmp3.c | 2 +-
>> .../gcc.target/microblaze/isa/fcmp4.c | 2 +-
>> .../gcc.target/microblaze/isa/fcvt.c | 2 +-
>> .../gcc.target/microblaze/isa/float.c | 2 +-
>> .../gcc.target/microblaze/isa/fsqrt.c | 2 +-
>> .../microblaze/isa/mul-bshift-pcmp.c | 2 +-
>> .../gcc.target/microblaze/isa/mul-bshift.c | 2 +-
>> gcc/testsuite/gcc.target/microblaze/isa/mul.c | 2 +-
>> .../microblaze/isa/mulh-bshift-pcmp.c | 2 +-
>> .../gcc.target/microblaze/isa/mulh.c | 2 +-
>> .../gcc.target/microblaze/isa/nofcmp.c | 2 +-
>> .../gcc.target/microblaze/isa/nofloat.c | 2 +-
>> .../gcc.target/microblaze/isa/pcmp.c | 2 +-
>> .../gcc.target/microblaze/isa/vanilla.c | 2 +-
>> .../gcc.target/microblaze/microblaze.exp | 2 +-
>> 22 files changed, 46 insertions(+), 20 deletions(-)
>
>> Committed.
>
> Did you commit this patch? I only see the ChangeLog files have been
> updated by your commit.
>
> Am I missing something?
Somehow only the ChangeLogs, which required manual editing, were
marked to be added. I'll add the other files.
--
Michael Eager
next prev parent reply other threads:[~2023-10-31 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 17:02 Neal Frager
2023-10-31 16:29 ` Michael Eager
2023-10-31 16:41 ` Frager, Neal
2023-10-31 17:45 ` Michael Eager [this message]
2023-10-31 17:58 ` Michael Eager
2023-10-31 18:02 ` Frager, Neal
-- strict thread matches above, loose matches on Subject: below --
2023-10-30 16:28 Neal Frager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1783c0ba-3d0d-4754-b25c-ba6c9320c406@eagercon.com \
--to=eager@eagercon.com \
--cc=appa.rao.nali@amd.com \
--cc=eager@eagerm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=luca.ceresoli@bootlin.com \
--cc=mark.hatle@amd.com \
--cc=nagaraju.mekala@amd.com \
--cc=neal.frager@amd.com \
--cc=sadanand.mutyala@amd.com \
--cc=vidhumouli.hunsigida@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).