From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 5B9A93857C6C; Fri, 15 Oct 2021 11:51:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B9A93857C6C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: efc1y/CNSK8miO3h9YG9yPgXgGWVKuUq6bm4g2g0720+Wy+FIvE/gFIWYs6bJGgWsIqVsS7+I1 xDw8d48YocrYZ2hAxSMuNox3s+LY4jLd31x6saTOoePWWOX9uk7PX15Bhjl3H5Aqvdcic5ZxlW nBXKLkhRHe362nKkwAFAb0rwnnF9kO+qms5dIJYtLWKJt28c53ja5/QeqzIiXb53G6P/Xzxd9U p3VqKL0oDFktJfhsVDpk5gcs+UuEUreKxHBgMuguf1BY9B3b7nitRvFrj314ucl5mavNrHtnyk m3N+04U62YAKitZpqu3VZC5C X-IronPort-AV: E=Sophos;i="5.85,375,1624348800"; d="diff'?scan'208";a="69702909" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 15 Oct 2021 03:51:06 -0800 IronPort-SDR: zWV3jkzil9ibqhgZOlmtCVkalsqQ8fjX0emqDw9WtXBFzvNoUa6jV7+yezfPXCgI0MMtvuPBqC 7cdiF0WD4UcyY3K5Q+vcFjqwXmQX9FfnU/KGk+uD0srJ5g01FvBmpJrDLsruVaAMGtRp2yG37Y SrVWssWnzuxDfuJ0+qo80iP5cxzr9zqWN79PLAJJFPnn08U+oKkIlq3I1P67dDQ9RD5/GBnJ4H kN+jgbVZ0QYFwIUkQCvgbjsmh7uAwS357MrRXeobdhVpfDtMiCZpuW1gZaN0QY1RI/aNAjUYqO sZE= Content-Type: multipart/mixed; boundary="------------umqAH8pUBSf5403R7DPE4HHZ" Message-ID: <178d8f79-0d99-9d21-6f02-381cb66be222@codesourcery.com> Date: Fri, 15 Oct 2021 13:50:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] PR fortran/102685 - ICE in output_constructor_regular_field, at varasm.c:5514 Content-Language: en-US To: Harald Anlauf , fortran , gcc-patches References: From: Tobias Burnus In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_NUMSUBJECT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Oct 2021 11:51:10 -0000 --------------umqAH8pUBSf5403R7DPE4HHZ Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Hi Harald, dear all, On 14.10.21 23:27, Harald Anlauf via Fortran wrote: > the attached patch adds a check for the shape of arrays in derived type > constructors. This brings it in line with other major brands. > ... > In developing the patch I encountered a difficulty with testcase > dec_structure_6.f90, which uses a DEC extension, namelist "old-style > CLIST initializers in STRUCTURE". I could not figure out how to > determine the shape of the initializer; it seemed to be always zero. > I've added code to accept this, but only under -fdec-structure, and > added a TODO in a comment. If somebody reading this could give me > a hint to solve end, I would adjust the patch accordingly. See attached patch =E2=80=93 it does initialize the variables similarly to = other shapes in that file, except that it has to take the shape from the LHS as seemingly (same testfile) having a 1-dim array can be used to initialize a 2-dim array. You can approve that patch and integrate it then in your own patch :-) > Regtested on x86_64-pc-linux-gnu. OK? Or further comments? LGTM =E2=80=93 with the DECL exception removed from resolve.c. Thanks, Tobias PS: Without the auto-reshape part, a simple 'gfc_array_size (expr, &expr->shape[0]))" would have been sufficient. ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------umqAH8pUBSf5403R7DPE4HHZ Content-Type: text/x-patch; charset="UTF-8"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL2RlY2wuYyBiL2djYy9mb3J0cmFuL2RlY2wuYwpp bmRleCBkNmEyMmQxMzQ1MS4uODZhZGI4MWRhMzIgMTAwNjQ0Ci0tLSBhL2djYy9mb3J0cmFu L2RlY2wuYworKysgYi9nY2MvZm9ydHJhbi9kZWNsLmMKQEAgLTg5MiwyOSArODkyLDMyIEBA IG1hdGNoX2NsaXN0X2V4cHIgKGdmY19leHByICoqcmVzdWx0LCBnZmNfdHlwZXNwZWMgKnRz LCBnZmNfYXJyYXlfc3BlYyAqYXMpCiAgIC8qIFNldCB1cCBleHByIGFzIGFuIGFycmF5IGNv bnN0cnVjdG9yLiAqLwogICBpZiAoIXNjYWxhcikKICAgICB7CiAgICAgICBleHByID0gZ2Zj X2dldF9hcnJheV9leHByICh0cy0+dHlwZSwgdHMtPmtpbmQsICZ3aGVyZSk7CiAgICAgICBl eHByLT50cyA9ICp0czsKICAgICAgIGV4cHItPnZhbHVlLmNvbnN0cnVjdG9yID0gYXJyYXlf aGVhZDsKIAotICAgICAgZXhwci0+cmFuayA9IGFzLT5yYW5rOwotICAgICAgZXhwci0+c2hh cGUgPSBnZmNfZ2V0X3NoYXBlIChleHByLT5yYW5rKTsKLQogICAgICAgLyogVmFsaWRhdGUg c2l6ZXMuICBXZSBidWlsdCBleHByIG91cnNlbHZlcywgc28gY29uc19zaXplIHdpbGwgYmUK IAkgY29uc3RhbnQgKHdlIGZhaWwgYWJvdmUgZm9yIG5vbi1jb25zdGFudCBleHByZXNzaW9u cykuCiAJIFdlIHN0aWxsIG5lZWQgdG8gdmVyaWZ5IHRoYXQgdGhlIHNpemVzIG1hdGNoLiAg Ki8KICAgICAgIGdjY19hc3NlcnQgKGdmY19hcnJheV9zaXplIChleHByLCAmY29uc19zaXpl KSk7CiAgICAgICBjbXAgPSBtcHpfY21wIChjb25zX3NpemUsIGFzX3NpemUpOwogICAgICAg aWYgKGNtcCA8IDApCiAJZ2ZjX2Vycm9yICgiTm90IGVub3VnaCBlbGVtZW50cyBpbiBhcnJh eSBpbml0aWFsaXplciBhdCAlQyIpOwogICAgICAgZWxzZSBpZiAoY21wID4gMCkKIAlnZmNf ZXJyb3IgKCJUb28gbWFueSBlbGVtZW50cyBpbiBhcnJheSBpbml0aWFsaXplciBhdCAlQyIp OwogICAgICAgbXB6X2NsZWFyIChjb25zX3NpemUpOwogICAgICAgaWYgKGNtcCkKIAlnb3Rv IGNsZWFudXA7CisKKyAgICAgIC8qIFNldCB0aGUgcmFuay9zaGFwZSB0byBtYXRjaCB0aGUg TEhTIGFzIGF1dG8tcmVzaGFwZSBpcyBpbXBsaWVkLiAqLworICAgICAgZXhwci0+cmFuayA9 IGFzLT5yYW5rOworICAgICAgZXhwci0+c2hhcGUgPSBnZmNfZ2V0X3NoYXBlIChhcy0+cmFu ayk7CisgICAgICBmb3IgKGludCBpID0gMDsgaSA8IGFzLT5yYW5rOyArK2kpCisJc3BlY19k aW1lbl9zaXplIChhcywgaSwgJmV4cHItPnNoYXBlW2ldKTsKICAgICB9CiAKICAgLyogTWFr ZSBzdXJlIHNjYWxhciB0eXBlcyBtYXRjaC4gKi8KICAgZWxzZSBpZiAoIWdmY19jb21wYXJl X3R5cGVzICgmZXhwci0+dHMsIHRzKQogICAgICAgICAgICAmJiAhZ2ZjX2NvbnZlcnRfdHlw ZSAoZXhwciwgdHMsIDEpKQogICAgIGdvdG8gY2xlYW51cDsKIAo= --------------umqAH8pUBSf5403R7DPE4HHZ--