From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27983 invoked by alias); 1 Dec 2016 12:28:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27962 invoked by uid 89); 1 Dec 2016 12:27:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=3717, 371,7, UD:xloc.file, xloc.file X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Dec 2016 12:27:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8A8D06267F; Thu, 1 Dec 2016 12:27:57 +0000 (UTC) Received: from localhost.localdomain (vpn1-7-50.ams2.redhat.com [10.36.7.50]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB1CRtVN011381; Thu, 1 Dec 2016 07:27:56 -0500 Subject: Re: [PING] (v2) Add a "compact" mode to print_rtx_function To: vogt@linux.vnet.ibm.com, David Malcolm , Jakub Jelinek , gcc-patches@gcc.gnu.org References: <43d4ec20-5f84-2533-22e4-e16c779f6162@redhat.com> <1476304646-39819-1-git-send-email-dmalcolm@redhat.com> <20161122131836.GA7025@linux.vnet.ibm.com> <48811c08-6412-2e8b-2763-b163c358afe3@redhat.com> <20161122133750.GR3541@tucnak.redhat.com> <20161122144501.GU3541@tucnak.redhat.com> <1479829122.7673.83.camel@redhat.com> <20161201101249.GA7155@linux.vnet.ibm.com> From: Bernd Schmidt Message-ID: <1793cdbe-94fa-a610-e799-5057c51b79e2@redhat.com> Date: Thu, 01 Dec 2016 12:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161201101249.GA7155@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00054.txt.bz2 On 12/01/2016 11:12 AM, Dominik Vogt wrote: >> >> diff --git a/gcc/print-rtl.c b/gcc/print-rtl.c >> index 77e6b05..5370602 100644 >> --- a/gcc/print-rtl.c >> +++ b/gcc/print-rtl.c >> @@ -371,7 +371,10 @@ rtx_writer::print_rtx_operand_code_i (const_rtx in_rtx, int idx) >> if (INSN_HAS_LOCATION (in_insn)) >> { >> expanded_location xloc = insn_location (in_insn); >> - fprintf (m_outfile, " \"%s\":%i", xloc.file, xloc.line); >> + if (m_compact) >> + fprintf (m_outfile, " \"%s\":%i", xloc.file, xloc.line); >> + else >> + fprintf (m_outfile, " %s:%i", xloc.file, xloc.line); >> } >> #endif >> } >> -- >> 1.8.5.3 > > I'd like to get our test failure fixed, either by changing > print-rtl.c or our test case. Is the above patch good for trunk? > It does fix the s390 test failure. I still don't see a strong reason not to print the quotes, so I'd suggest changing the testcase. Bernd