From: Jeff Law <law@redhat.com>
To: Dragan Mladjenovic <dmladjenovic@wavecomp.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Sandiford <richard.sandiford@arm.com>,
matthew Beliveau <mbelivea@redhat.com>
Subject: Re: [RFC/PATCH v2][PR89245] Check REG_CALL_DECL note during the tail-merging
Date: Wed, 24 Jul 2019 19:02:00 -0000 [thread overview]
Message-ID: <17953999-d9b0-3414-af40-97ce9666127c@redhat.com> (raw)
In-Reply-To: <5D2EDC47.2070501@wavecomp.com>
On 7/17/19 2:29 AM, Dragan Mladjenovic wrote:
>
>
> On 09.07.2019. 23:21, Jeff Law wrote:
>> On 7/9/19 2:06 PM, Dragan Mladjenovic wrote:
>>> This patch prevents merging of CALL instructions that that have different
>>> REG_CALL_DECL notes attached to them.
>>>
>>> On most architectures this is not an important distinction. Usually instruction patterns
>>> for calls to different functions reference different SYMBOL_REF-s, so they won't match.
>>> On MIPS PIC calls get split into an got_load/*call_internal pair where the latter represents
>>> indirect register call w/o SYMBOL_REF attached (until machine_reorg pass). The bugzilla issue
>>> had such two internal_call-s merged despite the fact that they had different register usage
>>> information assigned by ipa-ra.
>>>
>>> As per comment form Richard Sandiford, this version compares reg usage for both call
>>> instruction instead of shallow comparing the notes. Tests updated accordingly.
>>>
>>> gcc/ChangeLog:
>>>
>>> 2019-07-09 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
>>>
>>> * cfgcleanup.c (old_insns_match_p): Check if used hard regs set is equal
>>> for both call instructions.
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2019-07-09 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
>>>
>>> * gcc.target/mips/cfgcleanup-jalr1.c: New test.
>>> * gcc.target/mips/cfgcleanup-jalr2.c: New test.
>>> * gcc.target/mips/cfgcleanup-jalr3.c: New test.
>> THanks. I've installed this on the trunk.
>>
>> jeff
> Thanks. Can this be back-ported to active branches also. This issue
> seems to be there > since gcc6 if not gcc5.
I've asked Matthew to handle the backport. I'm going to be on PTO the
next couple weeks.
jeff
next prev parent reply other threads:[~2019-07-24 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 21:00 Dragan Mladjenovic
2019-07-09 21:21 ` Jeff Law
2019-07-17 8:32 ` Dragan Mladjenovic
2019-07-24 19:02 ` Jeff Law [this message]
2019-09-06 10:23 ` [EXTERNAL]Re: " Dragan Mladjenovic
2019-10-01 19:35 ` Jeff Law
2019-10-30 15:53 ` Dragan Mladjenovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17953999-d9b0-3414-af40-97ce9666127c@redhat.com \
--to=law@redhat.com \
--cc=dmladjenovic@wavecomp.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mbelivea@redhat.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).