From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32493 invoked by alias); 24 Jun 2013 15:12:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32482 invoked by uid 89); 24 Jun 2013 15:12:06 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_BF autolearn=ham version=3.3.1 Received: from mx3-phx2.redhat.com (HELO mx3-phx2.redhat.com) (209.132.183.24) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 24 Jun 2013 15:12:05 +0000 Received: from zmail10.collab.prod.int.phx2.redhat.com (zmail10.collab.prod.int.phx2.redhat.com [10.5.83.12]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5OFC40J014908; Mon, 24 Jun 2013 11:12:04 -0400 Date: Mon, 24 Jun 2013 15:12:00 -0000 From: Anthony Green To: David Edelsohn Cc: GCC Patches , libffi-discuss@sourceware.org, Alan Modra Message-ID: <1796424869.21686355.1372086723737.JavaMail.root@redhat.com> In-Reply-To: References: <20130607013408.GI6878@bubble.grove.modra.org> <20130624002616.GG21523@bubble.grove.modra.org> Subject: Re: [RS6000] libffi little-endian MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg01384.txt.bz2 It's fine with me. Please commit it directly to GCC and I'll put it in the upstream. Thanks! AG ----- Original Message ----- From: "David Edelsohn" To: "GCC Patches" , libffi-discuss@sourceware.org, "Alan Modra" Sent: Sunday, June 23, 2013 10:32:44 PM Subject: Re: [RS6000] libffi little-endian On Sun, Jun 23, 2013 at 8:26 PM, Alan Modra wrote: > On Fri, Jun 07, 2013 at 12:12:17AM -0400, David Edelsohn wrote: >> On Thu, Jun 6, 2013 at 9:34 PM, Alan Modra wrote: >> > Bootstrapped and regression tested powerpc64-linux. OK to apply? >> > >> > * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Support >> > little-endian. >> > * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Likewise. >> >> This patch needs to be applied upstream in the libffi repository. >> >> All of the handling of structs in ffi.c and ffi_darwin.c doesn't need >> any changes? Cool. I thought there might be a padding issue. > > You were right, of course. When we finally got around to running an > all languages bootstrap on powerpc64le, we discovered some missing > pieces in libffi. The following adds some ffi.c changes to the > previous patch (closure.S patches are unchanged). I haven't tackled > ffi_darwin.c. > > Bootstrapped and regression tested powerpc64-linux. This one passes > the libffi testsuite on powerpc64le-linux. OK mainline and 4.8? > > * src/powerpc/ffi.c (ffi_prep_args_SYSV): Move var declaration > before statements. > (ffi_prep_args64): Support little-endian. > (ffi_closure_helper_SYSV, ffi_closure_helper_LINUX64): Likewise. > * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Likewise. > * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Likewise. This looks okay to me and more like the changes I expected. Assuming Anthony accepts it upstream. Thanks, David