From: Robin Dapp <rdapp.gcc@gmail.com>
To: "Jeff Law" <jeffreyalaw@gmail.com>,
"Demin Han" <demin.han@starfivetech.com>,
钟居哲 <juzhe.zhong@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: rdapp.gcc@gmail.com, "kito.cheng" <kito.cheng@gmail.com>,
"Li, Pan2" <pan2.li@intel.com>
Subject: Re: [PATCH 1/5] RISC-V: Remove float vector eqne pattern
Date: Mon, 10 Jun 2024 09:33:09 +0200 [thread overview]
Message-ID: <17992cfd-195e-4bb5-9a75-919d1f702279@gmail.com> (raw)
In-Reply-To: <229ecbf1-6e59-4e2b-82bb-da7c729b2f01@gmail.com>
> But isn't canonicalization of EQ/NE safe, even for IEEE NaN and +-0.0?
>
> target = (a == b) ? x : y
> target = (a != b) ? y : x
>
> Are equivalent, even for IEEE IIRC.
Yes, that should be fine. My concern was not that we do a
canonicalization but that we might not do it for some of the
vector cases. In particular when one of the operands is wrapped
in a vec_duplicate and we end up with it first rather than
second.
My general feeling is that the patch is good but I wasn't entirely
sure about all cases (in particular in case we transform something
after expand). That's why I would have liked to see at least some
small test cases for it along with the patch (for the combinations
we don't test yet).
Regards
Robin
next prev parent reply other threads:[~2024-06-10 7:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 6:27 [PATCH 0/5] RISC-V: Support vf and vx for autovec comparison of demin.han
2024-03-01 6:27 ` [PATCH 1/5] RISC-V: Remove float vector eqne pattern demin.han
2024-03-01 7:23 ` 钟居哲
2024-03-01 8:12 ` Demin Han
2024-03-01 14:53 ` [PATCH " Robin Dapp
2024-05-15 19:48 ` Robin Dapp
2024-05-16 1:54 ` Demin Han
2024-05-16 19:21 ` Robin Dapp
2024-06-08 20:48 ` Jeff Law
2024-06-10 7:33 ` Robin Dapp [this message]
2024-06-10 13:49 ` Jeff Law
2024-06-10 14:52 ` Li, Pan2
2024-06-10 16:30 ` Jeff Law
2024-06-10 16:16 ` Demin Han
2024-06-10 16:23 ` Jeff Law
2024-06-08 20:51 ` Jeff Law
2024-06-08 20:50 ` Jeff Law
2024-03-01 6:27 ` [PATCH 2/5] RISC-V: Refactor expand_vec_cmp demin.han
2024-03-01 7:32 ` 钟居哲
2024-03-01 6:27 ` [PATCH 3/5] RISC-V: Support vmfxx.vf for autovec comparison of vec and imm demin.han
2024-03-01 7:48 ` 钟居哲
2024-03-01 8:26 ` Demin Han
2024-03-05 8:40 ` Demin Han
2024-03-05 9:02 ` juzhe.zhong
2024-03-05 10:40 ` Demin Han
2024-03-01 6:27 ` [PATCH 4/5] RISC-V: Remove integer vector eqne pattern demin.han
2024-03-01 7:37 ` 钟居哲
2024-03-01 6:27 ` [PATCH 5/5] RISC-V: Support vmsxx.vx for autovec comparison of vec and imm demin.han
2024-03-01 7:50 ` 钟居哲
2024-03-01 12:07 ` [PATCH " Robin Dapp
2024-03-02 0:24 ` Andrew Waterman
2024-03-01 6:50 ` [PATCH 0/5] RISC-V: Support vf and vx for autovec comparison of Demin Han
2024-05-16 2:01 [PATCH 1/5] RISC-V: Remove float vector eqne pattern =?gb18030?B?1tO+09Xc?=
2024-05-16 2:17 ` Demin Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17992cfd-195e-4bb5-9a75-919d1f702279@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=demin.han@starfivetech.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=pan2.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).