From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id D64793858D29 for ; Mon, 10 Jun 2024 07:33:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D64793858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D64793858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::529 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718004795; cv=none; b=cr5Ejhe3r920k6P0NoRRo+Tv1mQsaXcTHFOEcpUO5jhObswNS/ZD2EE7rsuvS4TfRmea51hVi6bBMr/fLUUmapZwCpyJ07yuUSLmK0LA06tHtTpA3OSNHNtsNqYzTjxuFcdt6Yl39wXriSvsx7coin1CiH5VWaGga19kY8PXmiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718004795; c=relaxed/simple; bh=KSJF43ISzi0myvXmge3YCSMBt8t5UKlS0xPceH6aFN8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=L6PMjjMiKLjfhpQcHbhNSz1GK8f1LFNS1bawQqv60ojsE42YiG1GCSF1W4BxZygkRuYN04o02eRzT7HXDLfN93q/qwV5dQh1DQLyOcxfa4Ft1o6oowqjVOfPSNrQOpdf/7NMIuvFCp7PM85savtq4tUbxJSg6QUr97GP+LfPIyA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-57a4d7ba501so5217128a12.2 for ; Mon, 10 Jun 2024 00:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718004790; x=1718609590; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B5JVZqrYLjLEIzjPOp/OO/NPIGXRAnYcRWm3NJM/Irc=; b=WzllY7E7Ue2wcdcQQN10r9yRxaT96I1XzUg7AouSjrsY+1b70Qy5FLsFOGpq5TloEi KZYQxHnR5oonfsJYwARu40ZERjD5RMECsP698hgbzl3QcfZnzvKvB6IyfxXtDeoqKyn9 EHxqW7rnJD5yEOcG/WGjRRh0LZZ8nXOdZ4mNf1w5EHJ80dRonfN6x/p5Xq7LbKS286vr mqWyVxHopzxpPZJnmemtzHkoLUMAodWinctuSNPPiCQaLzk+lSzmOLQ2LIRyL3EzVQiO tUuVo9WoVlWj8963YXYeVRIBaZc/99W9VgIBnuOfbwGBjENHTMlC+nIqd27lN6J83c+I uRXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718004790; x=1718609590; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B5JVZqrYLjLEIzjPOp/OO/NPIGXRAnYcRWm3NJM/Irc=; b=H8v2ANXhhbE3uPnZgqTHayBun0XxK3Y3QMYar+RdfdbGqyqlORvIWP3liQ7EEK82o6 tQegPv8h1g1QuNN5h8evO+fJ96oXGeCcg7UoZjrdQT6MnMmMwKAQV2pAnRtzQ8gGPWyR fce/zIG2L61LW3QQQuxR9gWt9xWIYue4+VHowo4D1R4ktSJgyOQp8+WzFQxKqDZe/52E nMxKUHzjx9PQ5ioUfZwfbKKvjlbQrzZYW+HxKm345GGXqptOCIe80ekRN/kt6i2ysOf8 vyE2A1lN1iJ88nAV1DRQ6oUEpmlLGfWiawBTlHDO8qlY4KuuHDcDbCuAQAhfoLbAAKv5 044A== X-Forwarded-Encrypted: i=1; AJvYcCWcAkPN0CDpFyTsnLTgQH/m5gEaXtQ3X3uH6rc8kc8lcAEAoTXta88N1Lcq+4HmBwzOSfyg/ttZYFXXPttTBSbbxLC1XhgoPw== X-Gm-Message-State: AOJu0YyhO4gGUF5vQ9/9V3xVL9ekxMjVHaPIN/ugEE7uNnH0A5X/DrDp jseIHEJI9I3k6DBG6IYMM85pLyCrqpbixWAMfI9Y70rLLRfE+jeUkiZxYQ== X-Google-Smtp-Source: AGHT+IEH6nPlx6sBmCFE4yptu4i9rxzYTP2mHXT6UyEHyf6LA3HQeH6vlZHcLgLTMxRYgmRiggDUFA== X-Received: by 2002:a17:907:970e:b0:a6f:da1:d077 with SMTP id a640c23a62f3a-a6f0da1d11bmr385493566b.25.1718004790362; Mon, 10 Jun 2024 00:33:10 -0700 (PDT) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57c82ce5762sm1161469a12.18.2024.06.10.00.33.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 00:33:10 -0700 (PDT) Message-ID: <17992cfd-195e-4bb5-9a75-919d1f702279@gmail.com> Date: Mon, 10 Jun 2024 09:33:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, "kito.cheng" , "Li, Pan2" Subject: Re: [PATCH 1/5] RISC-V: Remove float vector eqne pattern To: Jeff Law , Demin Han , =?UTF-8?B?6ZKf5bGF5ZOy?= , gcc-patches References: <20240301062711.207137-1-demin.han@starfivetech.com> <20240301062711.207137-2-demin.han@starfivetech.com> <06644d87-ccfa-42c3-a971-69e84f44c270@gmail.com> <229ecbf1-6e59-4e2b-82bb-da7c729b2f01@gmail.com> Content-Language: en-US From: Robin Dapp In-Reply-To: <229ecbf1-6e59-4e2b-82bb-da7c729b2f01@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > But isn't canonicalization of EQ/NE safe, even for IEEE NaN and +-0.0? > > target = (a == b) ? x : y > target = (a != b) ? y : x > > Are equivalent, even for IEEE IIRC. Yes, that should be fine. My concern was not that we do a canonicalization but that we might not do it for some of the vector cases. In particular when one of the operands is wrapped in a vec_duplicate and we end up with it first rather than second. My general feeling is that the patch is good but I wasn't entirely sure about all cases (in particular in case we transform something after expand). That's why I would have liked to see at least some small test cases for it along with the patch (for the combinations we don't test yet). Regards Robin