From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89422 invoked by alias); 4 Dec 2015 18:49:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 89413 invoked by uid 89); 4 Dec 2015 18:49:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 04 Dec 2015 18:49:34 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4vQ8-0004lQ-I5 for gcc-patches@gcc.gnu.org; Fri, 04 Dec 2015 13:49:32 -0500 Received: from oarmail.oarcorp.com ([67.63.146.244]:50550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4vQ8-0004k6-Dk for gcc-patches@gcc.gnu.org; Fri, 04 Dec 2015 13:49:28 -0500 Received: from [192.168.0.19] (207.98.215.166) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.3.389.2; Fri, 4 Dec 2015 12:49:23 -0600 User-Agent: K-9 Mail for Android In-Reply-To: <5661DF29.8010508@redhat.com> References: <3667951.xxJfb3I2z2@kubuntu> <565E9A4E.6070101@redhat.com> <1838497.lGhAiFNhbp@kubuntu> <5661DF29.8010508@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [PATCH] Fix declaration of pthread-structs in s-osinte-rtems.ads (ada/68169) From: Joel Sherrill Date: Fri, 04 Dec 2015 18:49:00 -0000 To: Jeff Law ,Jan Sommer ,"gcc-patches@gcc.gnu.org" CC: "devel@rtems.org" ,"sebastian.huber@embedded-brains.de" Message-ID: <17BFF74B-F699-4BC2-A3E2-401244C874E6@oarcorp.com> X-detected-operating-system: by eggs.gnu.org: Windows XP X-Received-From: 67.63.146.244 X-SW-Source: 2015-12/txt/msg00623.txt.bz2 On December 4, 2015 12:44:57 PM CST, Jeff Law wrote: >On 12/02/2015 03:23 PM, Jan Sommer wrote: >> Am Wednesday 02 December 2015, 08:13:20 schrieb Joel Sherrill: >>> >>> On December 2, 2015 2:14:22 AM EST, Jeff Law >>> wrote: >>>> On 12/01/2015 12:56 PM, Jan Sommer wrote: >>>>> Am Monday 30 November 2015, 16:19:30 schrieb Jeff Law: >>>>>> On 11/30/2015 03:06 PM, Jan Sommer wrote: >>>>>>> Could someone with write access please commit the patch? >>>>>>> The paperwork with the FSF has gone through. If something >>>>>>> else is >>>> missing, please tell me. >>>>>>> I won't be available next week. >>>>>> I'm not sure what you built your patches again, but I can't >>>>>> apply >>>> them >>>>>> to the trunk. Can you resend a patch as a diff against the >>>>>> trunk. >>>>>> >>>>>> Often I can fix things by hand, but this is Ada and I'd be >>>>>> much more likely to botch something. >>>>> >>>>> I updated the patches again. They should now fit with the heads >>>>> of >>>> the respective branches again. >>>>> Maybe the Changelog will be out of synch again. The patches are >>>>> for the following branches: ada-68169_4.9.diff --> >>>>> gcc-4_9-branch ada-68169_5.x.diff --> gcc-5-branch >>>>> ada-68169_trunk.diff --> trunk >>>>> >>>>> Let me know if they apply this time. I used svn diff to create >>>>> them >>>> and used patch -p0 to test if they apply locally. THanks. I've >>>> committed this to the trunk based on Joel's comments. >>>> >>>> The gcc-5 branch is frozen for the upcoming release and gcc-4.9 >>>> is regression/doc fixes only. It'll be up to the release >>>> managers whether >>>> >>>> or not to backport to those branches. >>> >>> Thanks Jeff. >>> >>> I would consider this a regression. RTEMS changed the >>> pthread_attr_t when we added thread affinity and updating Ada to >>> match slipped through. We knew it needed attention for SMP but >>> missed this critical piece to keep it working. >OK. I wasn't aware of this. Given this note, I went ahead and=20 >committed the change to the gcc-5 and gcc-4.9 branches. However, it=20 >missed the deadline for 5.3, which went out earlier this morning. Thanks.=20 Releases and freezes happen independent of bugs being discovered and fixed.= We all just have to keep plugging on and patching. We just like to build = tools with released versions and as few patches as possible. That's all we = can strive for. >Jeff --joel