From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pv34p98im-ztdg02162201.me.com (pv34p98im-ztdg02162201.me.com [17.143.234.141]) by sourceware.org (Postfix) with ESMTPS id 9FCF3385E018 for ; Wed, 11 Aug 2021 02:06:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FCF3385E018 Received: from [10.0.1.20] (cpe-98-26-0-177.nc.res.rr.com [98.26.0.177]) by pv34p98im-ztdg02162201.me.com (Postfix) with ESMTPSA id 989D41C01FE; Wed, 11 Aug 2021 02:06:17 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [PATCH] Objective-C: don't require redundant -fno-objc-sjlj-exceptions for the NeXT v2 ABI From: Matt Jacobson In-Reply-To: <1393D6BA-64E1-4965-BF07-4DF9394A390F@googlemail.com> Date: Tue, 10 Aug 2021 22:06:15 -0400 Cc: Eric Gallager , gcc-patches Content-Transfer-Encoding: quoted-printable Message-Id: <17E0391E-7BF4-4475-9133-8649D998706D@me.com> References: <7A5B0FDB-BE51-4801-96A1-6C83899F3D0C@me.com> <1393D6BA-64E1-4965-BF07-4DF9394A390F@googlemail.com> To: Iain Sandoe X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-10_08:2021-08-10, 2021-08-10 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2108110012 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Aug 2021 02:06:30 -0000 > On Aug 3, 2021, at 2:39 PM, Iain Sandoe = wrote: >=20 >=20 >=20 >> On 2 Aug 2021, at 22:37, Matt Jacobson via Gcc-patches = wrote: >>=20 >>> On Aug 2, 2021, at 5:09 PM, Eric Gallager = wrote: >>>=20 >>> On Wed, Jul 28, 2021 at 11:36 PM Matt Jacobson via Gcc-patches >>> wrote: >>>>=20 >>>> As is, an invocation of GCC with -fnext-runtime = -fobjc-abi-version=3D2 crashes, >>>> unless target-specific code adds an implicit = -fno-objc-sjlj-exceptions (which >>>> Darwin does). >>>>=20 >>>> This patch makes the general case not crash. >>>>=20 >>>> I don't have commit access, so if this patch is suitable, I'd need = someone else >>>> to commit it for me. Thanks. >>>=20 >>> Is there a bug open for the issue that this fixes? Just wondering = for >>> cross-referencing purposes... >>=20 >> No, I didn=E2=80=99t file a bug for this one, just sent the patch = directly. Hope=20 >> that=E2=80=99s OK. If not, happy to file one. >=20 > I have this on my TODO (and in my =E2=80=9Cto apply=E2=80=9D patch = queue - IMO it=E2=80=99s OK as an interim > solution - but I think in the longer term it would be better to make = fobjc-sjlj-exceptions > into a NOP, since the exception models are fixed for NeXT runtime = (unless you have > some intent to update the 32bit one to use DWARF unwinding ;-) ). Thanks. It certainly isn=E2=80=99t crystal clear just from the diff in the mail, = but with this=20 patch, -fobjc-sjlj-exceptions *is* essentially a no-op (modulo a small = warning)=20 under NeXT v2. Prior to this patch, it=E2=80=99s also a no-op, but (a) it=E2=80=99s = initially on by default=20 for NeXT v2, which (b) causes a crash unless `-fobjc-exceptions` is also=20= specified. Matt=