From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Carl Love <cel@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org,
Segher Boessenkool <segher@kernel.crashing.org>,
"bergner@linux.ibm.com" <bergner@linux.ibm.com>
Subject: Re: [PATCH 1/13 ver 3] rs6000, Remove __builtin_vsx_cmple* builtins
Date: Tue, 4 Jun 2024 14:00:03 +0800 [thread overview]
Message-ID: <17aa607d-ebbd-bd1a-3449-ad22710c5246@linux.ibm.com> (raw)
In-Reply-To: <a796b61c-3054-42f9-99ee-c7af2b1dff1b@linux.ibm.com>
Hi Carl,
on 2024/5/29 23:52, Carl Love wrote:
> This patch was approved in the previous series. There are no changes to this patch. Reposting for completeness.
I guess you can just push the approved ones, as there is no dependency
between any two of them? It can help to reduce the size of this series.
BR,
Kewen
>
> Carl
> -------------------------------------------------------
>
> rs6000, Remove __builtin_vsx_cmple* builtins
>
> The built-ins __builtin_vsx_cmple_u16qi, __builtin_vsx_cmple_u2di,
> __builtin_vsx_cmple_u4si and __builtin_vsx_cmple_u8hi should take
> unsigned arguments and return an unsigned result. The current definitions
> take signed arguments and return signed results which is incorrect.
>
> The signed and unsigned versions of __builtin_vsx_cmple* are not
> documented in extend.texi. Also there are no test cases for the
> built-ins.
>
> Users can use the existing vec_cmple as PVIPR defines instead of
> __builtin_vsx_cmple_u16qi, __builtin_vsx_cmple_u2di,
> __builtin_vsx_cmple_u4si and __builtin_vsx_cmple_u8hi,
> __builtin_vsx_cmple_16qi, __builtin_vsx_cmple_2di,
> __builtin_vsx_cmple_4si and __builtin_vsx_cmple_8hi,
> __builtin_altivec_cmple_1ti, __builtin_altivec_cmple_u1ti.
>
> Hence these built-ins are redundant and are removed by this patch.
>
> gcc/ChangeLog:
> * config/rs6000/rs6000-builtin.cc (RS6000_BIF_CMPLE_16QI,
> RS6000_BIF_CMPLE_U16QI, RS6000_BIF_CMPLE_8HI,
> RS6000_BIF_CMPLE_U8HI, RS6000_BIF_CMPLE_4SI, RS6000_BIF_CMPLE_U4SI,
> RS6000_BIF_CMPLE_2DI, RS6000_BIF_CMPLE_U2DI, RS6000_BIF_CMPLE_1TI,
> RS6000_BIF_CMPLE_U1TI): Remove case statements.
> * config/rs6000/rs6000-builtins.def (__builtin_vsx_cmple_16qi,
> __builtin_vsx_cmple_2di, __builtin_vsx_cmple_4si,
> __builtin_vsx_cmple_8hi, __builtin_vsx_cmple_u16qi,
> __builtin_vsx_cmple_u2di, __builtin_vsx_cmple_u4si,
> __builtin_vsx_cmple_u8hi): Remove buit-in definitions.
> ---
> gcc/config/rs6000/rs6000-builtin.cc | 13 ------------
> gcc/config/rs6000/rs6000-builtins.def | 30 ---------------------------
> 2 files changed, 43 deletions(-)
>
> diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc
> index 320affd79e3..ac9f16fe51a 100644
> --- a/gcc/config/rs6000/rs6000-builtin.cc
> +++ b/gcc/config/rs6000/rs6000-builtin.cc
> @@ -2027,19 +2027,6 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator *gsi)
> fold_compare_helper (gsi, GT_EXPR, stmt);
> return true;
>
> - case RS6000_BIF_CMPLE_16QI:
> - case RS6000_BIF_CMPLE_U16QI:
> - case RS6000_BIF_CMPLE_8HI:
> - case RS6000_BIF_CMPLE_U8HI:
> - case RS6000_BIF_CMPLE_4SI:
> - case RS6000_BIF_CMPLE_U4SI:
> - case RS6000_BIF_CMPLE_2DI:
> - case RS6000_BIF_CMPLE_U2DI:
> - case RS6000_BIF_CMPLE_1TI:
> - case RS6000_BIF_CMPLE_U1TI:
> - fold_compare_helper (gsi, LE_EXPR, stmt);
> - return true;
> -
> /* flavors of vec_splat_[us]{8,16,32}. */
> case RS6000_BIF_VSPLTISB:
> case RS6000_BIF_VSPLTISH:
> diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def
> index 3bc7fed6956..7c36976a089 100644
> --- a/gcc/config/rs6000/rs6000-builtins.def
> +++ b/gcc/config/rs6000/rs6000-builtins.def
> @@ -1337,30 +1337,6 @@
> const vss __builtin_vsx_cmpge_u8hi (vus, vus);
> CMPGE_U8HI vector_nltuv8hi {}
>
> - const vsc __builtin_vsx_cmple_16qi (vsc, vsc);
> - CMPLE_16QI vector_ngtv16qi {}
> -
> - const vsll __builtin_vsx_cmple_2di (vsll, vsll);
> - CMPLE_2DI vector_ngtv2di {}
> -
> - const vsi __builtin_vsx_cmple_4si (vsi, vsi);
> - CMPLE_4SI vector_ngtv4si {}
> -
> - const vss __builtin_vsx_cmple_8hi (vss, vss);
> - CMPLE_8HI vector_ngtv8hi {}
> -
> - const vsc __builtin_vsx_cmple_u16qi (vsc, vsc);
> - CMPLE_U16QI vector_ngtuv16qi {}
> -
> - const vsll __builtin_vsx_cmple_u2di (vsll, vsll);
> - CMPLE_U2DI vector_ngtuv2di {}
> -
> - const vsi __builtin_vsx_cmple_u4si (vsi, vsi);
> - CMPLE_U4SI vector_ngtuv4si {}
> -
> - const vss __builtin_vsx_cmple_u8hi (vss, vss);
> - CMPLE_U8HI vector_ngtuv8hi {}
> -
> const vd __builtin_vsx_concat_2df (double, double);
> CONCAT_2DF vsx_concat_v2df {}
>
> @@ -3117,12 +3093,6 @@
> const vbq __builtin_altivec_cmpge_u1ti (vuq, vuq);
> CMPGE_U1TI vector_nltuv1ti {}
>
> - const vbq __builtin_altivec_cmple_1ti (vsq, vsq);
> - CMPLE_1TI vector_ngtv1ti {}
> -
> - const vbq __builtin_altivec_cmple_u1ti (vuq, vuq);
> - CMPLE_U1TI vector_ngtuv1ti {}
> -
> const unsigned long long __builtin_altivec_cntmbb (vuc, const int<1>);
> VCNTMBB vec_cntmb_v16qi {}
>
next prev parent reply other threads:[~2024-06-04 6:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 15:48 [PATCH 0/13 ver 3] rs6000, built-in cleanup patch series Carl Love
2024-05-29 15:52 ` [PATCH 1/13 ver 3] s6000, Remove __builtin_vsx_cmple* builtins Carl Love
2024-06-04 6:00 ` Kewen.Lin [this message]
2024-06-05 22:25 ` [PATCH 1/13 ver 3] rs6000, " Carl Love
2024-06-06 2:40 ` Kewen.Lin
2024-05-29 15:55 ` [PATCH 2/13 ver 3] rs6000, Remove __builtin_vsx_xvcvspsxws built-in Carl Love
2024-05-29 15:56 ` [PATCH 3/13 ver 3] rs6000, fix error in unsigned vector float to unsigned int built-in definition Carl Love
2024-06-04 5:58 ` Kewen.Lin
2024-05-29 15:58 ` [PATCH 4/13 ver 3] rs6000, extend the current vec_{un,}signed{e,o} built-ins Carl Love
2024-06-04 7:19 ` Kewen.Lin
2024-06-13 15:35 ` Carl Love
2024-05-29 16:00 ` [PATCH 5/13 ver 3] rs6000, Remove redundant float/double type conversions Carl Love
2024-06-04 6:20 ` Kewen.Lin
2024-05-29 16:01 ` [PATCH 6/13 ver 3] rs6000, remove duplicated built-ins of vecmergl and, vec_mergeh Carl Love
2024-05-29 16:03 ` [PATCH 7/13 ver 3] rs6000, add overloaded vec_sel with int128 arguments Carl Love
2024-06-04 5:58 ` Kewen.Lin
2024-06-13 15:35 ` Carl Love
2024-05-29 16:05 ` [PATCH 8/13 ver 3] rs6000, remove the vec_xxsel built-ins, they are, duplicates Carl Love
2024-06-04 5:58 ` Kewen.Lin
2024-05-29 16:06 ` [PATCH 9/13 ver 3] rs6000, remove __builtin_vsx_vperm_* built-ins Carl Love
2024-06-04 5:58 ` Kewen.Lin
2024-05-29 16:08 ` [PATCH 10/13 ver 3] rs6000, remove __builtin_vsx_xvnegdp and, __builtin_vsx_xvnegsp built-ins Carl Love
2024-05-29 16:10 ` [PATCH 11/13 ver 3] rs6000, extend vec_xxpermdi built-in for __int128 args Carl Love
2024-06-04 5:58 ` Kewen.Lin
2024-06-13 15:35 ` Carl Love
2024-05-29 16:11 ` [PATCH 12/13 ver 3] rs6000, remove __builtin_vsx_xvcmpeqsp_p built-in Carl Love
2024-06-04 5:59 ` Kewen.Lin
2024-05-29 16:16 ` [PATCH 13/13 ver 3] rs6000, remove vector set and vector init built-ins Carl Love
2024-06-04 5:59 ` Kewen.Lin
2024-06-13 15:35 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17aa607d-ebbd-bd1a-3449-ad22710c5246@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=cel@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).