From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 8CF853875446 for ; Tue, 4 Jun 2024 06:00:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CF853875446 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8CF853875446 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717480822; cv=none; b=O60NRSSxEd6RaUIhexbHsRjsmUqCbAbLDLZj3fEoIItCjbDmnJ6Hu+9Rl6M6ojpUk9aL6LNxfqDsa4ZJnnHHteP5MWxfV/UjZlphcXqHqhaCEsazERwkJcZLNl8DgYSOjacTnSJnUM4rnb5Q45qsUaJxXRcD3arn7WaS5aET0Es= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717480822; c=relaxed/simple; bh=O52UzbpaWSezTrQJW+8m2jkrMAJe/pESsn86spUUr8A=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=TTxCCjkMsfz+RxvZ9xgntVpSHbFzaUaBae0SXFZUUrNNkP4DMQj/gMgC+ZK2mt5bp7PYwmk7nNqRV9Ki1skBuqBKqvUuRSJQtT0vOl0l38oNCVKlaR5OVDDy+qVAV4juGmiVuU15yaf23oNWc0Zspdr4nt3fJdRj7qUtmnD32AU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4545r9lE008423; Tue, 4 Jun 2024 06:00:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=pp1; bh=P/Q17HpCFhc7Ap2UCUEWom6k+GIRDKL7ESk50DjveUs=; b=eljC15zUL0SddjkkieVjd+dw7yfIkgHooBb9ZzEMPQRhukXrpmn1NjOTTmHQrDo8+1sI 11riq/iSLoODEw6FdkB56jLVKfkkMfO89m9y7zlw5iLrlZzrQ+zl7rIUtocfU2mHFf9i s5FMgEKuCjZPK7xtEKIp22Nr3d/RS9f0PucleIOp1XczcDYsiX+ZpLJ817AO+uglgYD+ n+P749Og+SOkIB7DY/3s6un80Mgf31s0zaOVOMWfDRmZJcSAO8sSh9AijzVVHYQQ1Sca sfBGgW+VEkz5BHxE4JrThh+uCoJ14wcuo2UGlbcb1CVo9eQ+LMxrlWnAZ2lXEyLwp+IH 1g== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yhw5jg0q4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Jun 2024 06:00:17 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4543QnUx022786; Tue, 4 Jun 2024 06:00:17 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ygg6m41kc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Jun 2024 06:00:17 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45460Bmp47055206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 4 Jun 2024 06:00:13 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1FC372004E; Tue, 4 Jun 2024 06:00:11 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A89292004F; Tue, 4 Jun 2024 06:00:09 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 4 Jun 2024 06:00:09 +0000 (GMT) Message-ID: <17aa607d-ebbd-bd1a-3449-ad22710c5246@linux.ibm.com> Date: Tue, 4 Jun 2024 14:00:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/13 ver 3] rs6000, Remove __builtin_vsx_cmple* builtins Content-Language: en-US To: Carl Love References: <59db7e45-e780-4d20-a364-526f9e45800b@linux.ibm.com> Cc: gcc-patches@gcc.gnu.org, Segher Boessenkool , "bergner@linux.ibm.com" From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BuymnzM_dP-mYAe4gldqFC9M3rOKo3DZ X-Proofpoint-GUID: BuymnzM_dP-mYAe4gldqFC9M3rOKo3DZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-06-04_02,2024-05-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406040046 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Carl, on 2024/5/29 23:52, Carl Love wrote: > This patch was approved in the previous series. There are no changes to this patch. Reposting for completeness. I guess you can just push the approved ones, as there is no dependency between any two of them? It can help to reduce the size of this series. BR, Kewen > > Carl > ------------------------------------------------------- > > rs6000, Remove __builtin_vsx_cmple* builtins > > The built-ins __builtin_vsx_cmple_u16qi, __builtin_vsx_cmple_u2di, > __builtin_vsx_cmple_u4si and __builtin_vsx_cmple_u8hi should take > unsigned arguments and return an unsigned result. The current definitions > take signed arguments and return signed results which is incorrect. > > The signed and unsigned versions of __builtin_vsx_cmple* are not > documented in extend.texi. Also there are no test cases for the > built-ins. > > Users can use the existing vec_cmple as PVIPR defines instead of > __builtin_vsx_cmple_u16qi, __builtin_vsx_cmple_u2di, > __builtin_vsx_cmple_u4si and __builtin_vsx_cmple_u8hi, > __builtin_vsx_cmple_16qi, __builtin_vsx_cmple_2di, > __builtin_vsx_cmple_4si and __builtin_vsx_cmple_8hi, > __builtin_altivec_cmple_1ti, __builtin_altivec_cmple_u1ti. > > Hence these built-ins are redundant and are removed by this patch. > > gcc/ChangeLog: > * config/rs6000/rs6000-builtin.cc (RS6000_BIF_CMPLE_16QI, > RS6000_BIF_CMPLE_U16QI, RS6000_BIF_CMPLE_8HI, > RS6000_BIF_CMPLE_U8HI, RS6000_BIF_CMPLE_4SI, RS6000_BIF_CMPLE_U4SI, > RS6000_BIF_CMPLE_2DI, RS6000_BIF_CMPLE_U2DI, RS6000_BIF_CMPLE_1TI, > RS6000_BIF_CMPLE_U1TI): Remove case statements. > * config/rs6000/rs6000-builtins.def (__builtin_vsx_cmple_16qi, > __builtin_vsx_cmple_2di, __builtin_vsx_cmple_4si, > __builtin_vsx_cmple_8hi, __builtin_vsx_cmple_u16qi, > __builtin_vsx_cmple_u2di, __builtin_vsx_cmple_u4si, > __builtin_vsx_cmple_u8hi): Remove buit-in definitions. > --- > gcc/config/rs6000/rs6000-builtin.cc | 13 ------------ > gcc/config/rs6000/rs6000-builtins.def | 30 --------------------------- > 2 files changed, 43 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc > index 320affd79e3..ac9f16fe51a 100644 > --- a/gcc/config/rs6000/rs6000-builtin.cc > +++ b/gcc/config/rs6000/rs6000-builtin.cc > @@ -2027,19 +2027,6 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator *gsi) > fold_compare_helper (gsi, GT_EXPR, stmt); > return true; > > - case RS6000_BIF_CMPLE_16QI: > - case RS6000_BIF_CMPLE_U16QI: > - case RS6000_BIF_CMPLE_8HI: > - case RS6000_BIF_CMPLE_U8HI: > - case RS6000_BIF_CMPLE_4SI: > - case RS6000_BIF_CMPLE_U4SI: > - case RS6000_BIF_CMPLE_2DI: > - case RS6000_BIF_CMPLE_U2DI: > - case RS6000_BIF_CMPLE_1TI: > - case RS6000_BIF_CMPLE_U1TI: > - fold_compare_helper (gsi, LE_EXPR, stmt); > - return true; > - > /* flavors of vec_splat_[us]{8,16,32}. */ > case RS6000_BIF_VSPLTISB: > case RS6000_BIF_VSPLTISH: > diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def > index 3bc7fed6956..7c36976a089 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -1337,30 +1337,6 @@ > const vss __builtin_vsx_cmpge_u8hi (vus, vus); > CMPGE_U8HI vector_nltuv8hi {} > > - const vsc __builtin_vsx_cmple_16qi (vsc, vsc); > - CMPLE_16QI vector_ngtv16qi {} > - > - const vsll __builtin_vsx_cmple_2di (vsll, vsll); > - CMPLE_2DI vector_ngtv2di {} > - > - const vsi __builtin_vsx_cmple_4si (vsi, vsi); > - CMPLE_4SI vector_ngtv4si {} > - > - const vss __builtin_vsx_cmple_8hi (vss, vss); > - CMPLE_8HI vector_ngtv8hi {} > - > - const vsc __builtin_vsx_cmple_u16qi (vsc, vsc); > - CMPLE_U16QI vector_ngtuv16qi {} > - > - const vsll __builtin_vsx_cmple_u2di (vsll, vsll); > - CMPLE_U2DI vector_ngtuv2di {} > - > - const vsi __builtin_vsx_cmple_u4si (vsi, vsi); > - CMPLE_U4SI vector_ngtuv4si {} > - > - const vss __builtin_vsx_cmple_u8hi (vss, vss); > - CMPLE_U8HI vector_ngtuv8hi {} > - > const vd __builtin_vsx_concat_2df (double, double); > CONCAT_2DF vsx_concat_v2df {} > > @@ -3117,12 +3093,6 @@ > const vbq __builtin_altivec_cmpge_u1ti (vuq, vuq); > CMPGE_U1TI vector_nltuv1ti {} > > - const vbq __builtin_altivec_cmple_1ti (vsq, vsq); > - CMPLE_1TI vector_ngtv1ti {} > - > - const vbq __builtin_altivec_cmple_u1ti (vuq, vuq); > - CMPLE_U1TI vector_ngtuv1ti {} > - > const unsigned long long __builtin_altivec_cntmbb (vuc, const int<1>); > VCNTMBB vec_cntmb_v16qi {} >