From: Robin Dapp <rdapp.gcc@gmail.com>
To: Richard Biener <rguenther@suse.de>,
Tamar Christina <Tamar.Christina@arm.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
richard.sandiford@arm.com
Cc: rdapp.gcc@gmail.com
Subject: Re: [PATCH] ifcvt/vect: Emit COND_ADD for conditional scalar reduction.
Date: Tue, 31 Oct 2023 22:19:29 +0100 [thread overview]
Message-ID: <17e3c169-a971-4169-b400-8651f87e5036@gmail.com> (raw)
In-Reply-To: <mpta5rycxm3.fsf@arm.com>
>> +int
>> +internal_fn_else_index (internal_fn fn)
>
> The function needs a comment, maybe:
>
> /* If FN is an IFN_COND_* or IFN_COND_LEN_* function, return the index of the
> argument that is used when the condition is false. Return -1 otherwise. */
>
> OK for the internal-fn* and tree-if-conv.cc bits (which were the
> parts I commented on earlier). I'll look at cleaning up the
> definition of conditional internal functions separately, so that
> the list of functions isn't necessary.
Thank you, added the comment (shouldn't have forgotten it in the
first place...). So there's the vectorizer part left that is not
yet OK'd.
Regards
Robin
next prev parent reply other threads:[~2023-10-31 21:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 13:51 Robin Dapp
2023-09-27 0:44 ` Tamar Christina
2023-10-04 7:54 ` Robin Dapp
2023-10-04 13:15 ` Robin Dapp
2023-10-04 15:12 ` Tamar Christina
2023-10-05 8:54 ` Robin Dapp
2023-10-05 9:02 ` Robin Dapp
2023-10-05 14:05 ` Robin Dapp
2023-10-05 14:15 ` Tamar Christina
2023-10-06 9:10 ` Richard Biener
2023-10-06 12:28 ` Robin Dapp
2023-10-06 12:30 ` Robin Dapp
2023-10-06 13:43 ` Richard Biener
2023-10-06 20:54 ` Robin Dapp
2023-10-09 8:25 ` Richard Biener
2023-10-09 12:54 ` Robin Dapp
2023-10-09 13:05 ` Richard Biener
2023-10-09 5:50 ` Richard Sandiford
2023-10-09 12:02 ` Robin Dapp
2023-10-09 14:57 ` Richard Sandiford
2023-10-11 19:15 ` Robin Dapp
2023-10-12 10:47 ` Richard Sandiford
2023-10-12 11:11 ` Richard Biener
2023-10-19 20:07 ` Robin Dapp
2023-10-23 10:53 ` Richard Biener
2023-10-24 11:11 ` Richard Sandiford
2023-10-24 19:56 ` Robin Dapp
2023-10-31 21:04 ` Richard Sandiford
2023-10-31 21:19 ` Robin Dapp [this message]
2023-11-02 7:48 ` Richard Biener
2023-09-27 11:42 ` Richard Biener
2023-11-02 23:26 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e3c169-a971-4169-b400-8651f87e5036@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).