public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Haley <aph-gcc@littlepinkcloud.COM>
To: Richard Guenther <rguenther@suse.de>
Cc: Paolo Bonzini <bonzini@gnu.org>,
	gcc-patches@gcc.gnu.org,         Andreas Tobler <toa@pop.agri.ch>
Subject: Re: [PATCH] Fix PR32843, testsuite bug wrt sign/zero-extension of   return  values
Date: Thu, 26 Jul 2007 14:54:00 -0000	[thread overview]
Message-ID: <18088.45169.206955.401393@zebedee.pink> (raw)
In-Reply-To: <Pine.LNX.4.64.0707261633400.6492@s68.fhfr.qr>

Richard Guenther writes:
 > On Thu, 26 Jul 2007, Andrew Haley wrote:
 > 
 > > Richard Guenther writes:
 > >  > On Thu, 26 Jul 2007, Paolo Bonzini wrote:
 > >  > 
 > >  > > 
 > >  > > > This patch was approved by Andreas Tobler in the PR audit trail and
 > >  > > > committed to mainline.
 > >  > > 
 > >  > > Couldn't it be also a FFI bug?  If the ABI is unclear, I would have expected
 > >  > > libffi to do the cast itself...
 > >  > 
 > >  > Maybe.  Still it shouldn't matter -- the only valid thing to do with
 > >  > a signed char is to use it as signed char.  Everything else requires
 > >  > a proper conversion.
 > > 
 > > Perhaps so, but even if this is not strictly speaking a libffi bug, it
 > > is a libffi quality of implementation issue, and it does potentially
 > > break code.
 > > 
 > > The intention of the testcase that has been broken is precisely to
 > > check that signed characters are sign extended.  When this fails
 > > libffi should be changed, not the testcase.
 > 
 > If you are familiar with libffi can you try to fix this then and
 > revert the testsuite change?

Sure.

Andrew.

  reply	other threads:[~2007-07-26 14:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26  9:25 Richard Guenther
2007-07-26 14:17 ` Paolo Bonzini
2007-07-26 14:25   ` Richard Guenther
2007-07-26 14:28     ` Andrew Haley
2007-07-26 14:48       ` Richard Guenther
2007-07-26 14:54         ` Andrew Haley [this message]
2007-07-27 18:28           ` Andrew Haley
2007-07-27 19:28             ` Richard Guenther
2007-07-30 13:58               ` Andrew Haley
2007-08-06 12:46                 ` Andrew Haley
2007-08-07 12:46                   ` Andrew Haley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18088.45169.206955.401393@zebedee.pink \
    --to=aph-gcc@littlepinkcloud.com \
    --cc=bonzini@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    --cc=toa@pop.agri.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).