From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31502 invoked by alias); 26 Jul 2007 14:32:27 -0000 Received: (qmail 31494 invoked by uid 22791); 26 Jul 2007 14:32:27 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jul 2007 14:32:24 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.1/8.13.1) with ESMTP id l6QEWMdp005405 for ; Thu, 26 Jul 2007 10:32:22 -0400 Received: from zebedee.littlepinkcloud.COM (vpn-14-81.rdu.redhat.com [10.11.14.81]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6QEWKXp015166; Thu, 26 Jul 2007 10:32:21 -0400 Received: from littlepinkcloud.COM (localhost.localdomain [127.0.0.1]) by zebedee.littlepinkcloud.COM (8.13.8/8.13.5) with ESMTP id l6QEWI2J010183; Thu, 26 Jul 2007 15:32:18 +0100 Received: (from aph@localhost) by littlepinkcloud.COM (8.13.8/8.13.5/Submit) id l6QEWH4S010180; Thu, 26 Jul 2007 15:32:17 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18088.45169.206955.401393@zebedee.pink> Date: Thu, 26 Jul 2007 14:54:00 -0000 From: Andrew Haley To: Richard Guenther Cc: Paolo Bonzini , gcc-patches@gcc.gnu.org, Andreas Tobler Subject: Re: [PATCH] Fix PR32843, testsuite bug wrt sign/zero-extension of return values In-Reply-To: References: <46A8AAF0.1090603@gnu.org> <18088.44823.174959.708412@zebedee.pink> X-Mailer: VM 7.19 under Emacs 22.0.93.1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg01921.txt.bz2 Richard Guenther writes: > On Thu, 26 Jul 2007, Andrew Haley wrote: > > > Richard Guenther writes: > > > On Thu, 26 Jul 2007, Paolo Bonzini wrote: > > > > > > > > > > > > This patch was approved by Andreas Tobler in the PR audit trail and > > > > > committed to mainline. > > > > > > > > Couldn't it be also a FFI bug? If the ABI is unclear, I would have expected > > > > libffi to do the cast itself... > > > > > > Maybe. Still it shouldn't matter -- the only valid thing to do with > > > a signed char is to use it as signed char. Everything else requires > > > a proper conversion. > > > > Perhaps so, but even if this is not strictly speaking a libffi bug, it > > is a libffi quality of implementation issue, and it does potentially > > break code. > > > > The intention of the testcase that has been broken is precisely to > > check that signed characters are sign extended. When this fails > > libffi should be changed, not the testcase. > > If you are familiar with libffi can you try to fix this then and > revert the testsuite change? Sure. Andrew.