public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Haley <aph-gcc@littlepinkcloud.COM>
To: Richard Guenther <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][C++/Java] Get rid of the walk_subtrees langhook
Date: Thu, 26 Jul 2007 16:35:00 -0000	[thread overview]
Message-ID: <18088.51460.111474.583536@zebedee.pink> (raw)
In-Reply-To: <Pine.LNX.4.64.0707261627310.6492@s68.fhfr.qr>

Richard Guenther writes:
 > 
 > This gets rid of the walk_subtrees langhook which is called at every
 > invocation of walk_trees.  The only real user is the C++ frontend which
 > is too lazy to use its own walk_tree.  Instead of duplicating walk_tree
 > there I made the langhook an extra callback parameter for walk_tree
 > and replaced all occurances in the C++ frontend by a wrapper called
 > cp_walk_tree that passes the current langhook implementation.  All
 > cases covered in the langhook look frontend specific and should not
 > affect middle-end walkers.
 > 
 > Apart from nice to LTO this should bring a noticable speedup for
 > targets with slow indirect calls.
 > 
 > Full bootstrap and regtest on x86_64-unknown-linux-gnu still running
 > for C++ and Java, though build and C++ testing finished successfully
 > already.
 > 
 > Ok for mainline?  (This needs a GWP at best)
 > 
 > Note I did not go through callers to walk_tree in the C++ frontend
 > to identify which ones really need the callback but just changed them
 > all over.

I guess that's OK, yes.  Now that inlining is done on generic trees
rather than java FE trees there's no need for java_tree_inlining_walk_subtrees.

Andrew.

  reply	other threads:[~2007-07-26 16:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26 14:32 Richard Guenther
2007-07-26 16:35 ` Andrew Haley [this message]
2007-08-06  0:24 ` Mark Mitchell
2007-08-20 11:18   ` Richard Guenther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18088.51460.111474.583536@zebedee.pink \
    --to=aph-gcc@littlepinkcloud.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).