From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15561 invoked by alias); 5 Aug 2007 09:50:25 -0000 Received: (qmail 15480 invoked by uid 22791); 5 Aug 2007 09:50:23 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 05 Aug 2007 09:50:20 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.1/8.13.1) with ESMTP id l759oIV5004129; Sun, 5 Aug 2007 05:50:18 -0400 Received: from zebedee.littlepinkcloud.COM (vpn-14-18.rdu.redhat.com [10.11.14.18]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l759oFcw005114; Sun, 5 Aug 2007 05:50:16 -0400 Received: from littlepinkcloud.COM (localhost.localdomain [127.0.0.1]) by zebedee.littlepinkcloud.COM (8.13.8/8.13.5) with ESMTP id l759oDls022927; Sun, 5 Aug 2007 10:50:13 +0100 Received: (from aph@localhost) by littlepinkcloud.COM (8.13.8/8.13.5/Submit) id l759oCp0022924; Sun, 5 Aug 2007 10:50:12 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18101.40276.289598.913697@zebedee.pink> Date: Sun, 05 Aug 2007 09:50:00 -0000 From: Andrew Haley To: David Daney Cc: GCJ-patches , GCC Patches , andreast@gcc.gnu.org Subject: Re: [Patch] libffi: Fix broken return_ul.c test. In-Reply-To: <46B04209.3000509@avtrex.com> References: <46B04209.3000509@avtrex.com> X-Mailer: VM 7.19 under Emacs 22.0.93.1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00262.txt.bz2 David Daney writes: > The return_ul.c test is failing for mips64 n32 ABI. The problem is that > the return value location was too small and was overflowing into > adjacent memory. > > According to the libffi README, return values must be at least as large > as ffi_arg, so that is what I used. > > Tested on x86_64-pc-linux-gnu and mips64-linux-gnu. > > OK to commit? > > 2007-08-01 David Daney > > * testsuite/libffi.call/return_ul.c (main): Define return type as > ffi_arg. Use proper printf conversion specifier. Yeah, of course. Andrew.