From: Andrew Haley <aph-gcc@littlepinkcloud.COM>
To: Richard Guenther <rguenther@suse.de>,
Paolo Bonzini <bonzini@gnu.org>,
gcc-patches@gcc.gnu.org, Andreas Tobler <toa@pop.agri.ch>
Subject: Re: [PATCH] Fix PR32843, testsuite bug wrt sign/zero-extension of return values
Date: Mon, 06 Aug 2007 12:46:00 -0000 [thread overview]
Message-ID: <18103.6180.137779.637441@zebedee.pink> (raw)
In-Reply-To: <18093.59884.292404.551618@zebedee.pink>
The PR32843 fix caused libgcj regressions. This turned out to be
because ffi_closure_raw_SYSV duplicates code from ffi_closure_SYSV but
in a way that is difficult to share, and the libffi testsuite doesn't
test raw closures at all. The PR32843 patch needed to be applied in
two places, not just one. :-(
Fixed thusly.
Andrew.
2007-08-06 Andrew Haley <aph@redhat.com>
PR testsuite/32843
* src/x86/sysv.S (ffi_closure_raw_SYSV): Handle FFI_TYPE_UINT8,
FFI_TYPE_SINT8, FFI_TYPE_UINT16, FFI_TYPE_SINT16, FFI_TYPE_UINT32,
FFI_TYPE_SINT32.
Index: sysv.S
===================================================================
*** sysv.S (revision 127238)
--- sysv.S (working copy)
*************** ffi_closure_raw_SYSV:
*** 266,271 ****
--- 266,278 ----
movl CIF_FLAGS_OFFSET(%esi), %eax /* rtype */
cmpl $FFI_TYPE_INT, %eax
je .Lrcls_retint
+ /* Handle FFI_TYPE_UINT8, FFI_TYPE_SINT8, FFI_TYPE_UINT16,
+ FFI_TYPE_SINT16, FFI_TYPE_UINT32, FFI_TYPE_SINT32. */
+ cmpl $FFI_TYPE_UINT64, %eax
+ jge 0f
+ cmpl $FFI_TYPE_UINT8, %eax
+ jge .Lcls_retint
+ 0:
cmpl $FFI_TYPE_FLOAT, %eax
je .Lrcls_retfloat
cmpl $FFI_TYPE_DOUBLE, %eax
next prev parent reply other threads:[~2007-08-06 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 9:25 Richard Guenther
2007-07-26 14:17 ` Paolo Bonzini
2007-07-26 14:25 ` Richard Guenther
2007-07-26 14:28 ` Andrew Haley
2007-07-26 14:48 ` Richard Guenther
2007-07-26 14:54 ` Andrew Haley
2007-07-27 18:28 ` Andrew Haley
2007-07-27 19:28 ` Richard Guenther
2007-07-30 13:58 ` Andrew Haley
2007-08-06 12:46 ` Andrew Haley [this message]
2007-08-07 12:46 ` Andrew Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18103.6180.137779.637441@zebedee.pink \
--to=aph-gcc@littlepinkcloud.com \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=toa@pop.agri.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).