From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 68BAD3858022; Sun, 20 Nov 2022 20:45:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 68BAD3858022 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42a.google.com with SMTP id g12so17122396wrs.10; Sun, 20 Nov 2022 12:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LLxgb7IhGOmJaS5gF044p04/xjQ0N+lpEe5ygbKNNuc=; b=Q3/fHMj7P19axmcUob2bd3sHuX/bDNORw8w0lG5sQZ5GmzbkGNXab+zoG8ho5wgckt TAfdRu/tA2gMzedAe2ehOXwRqVdyx1nwUgnKgXT4APLCUk4Y1px/8KnNQ3Rq5696wGIl fT8ZXE/QD9Apxs+dARXpWrnNENyu3GpPe6S62YpQN3C2hGCjdOgfu74/wfucwBZeWjA2 2UmChDdr2+e57i1tPsfUNMj/wsxK7/XeqYxXMnJOWcLP9qG/Nf6jMSaKM7nUVY5dJSmJ v/Wf1KA11ZqDWzSC7qxdS9e2vfEgb2PVraue/ymevRTaYEqfTXedsmbrrtrdMy5CErpF KzxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LLxgb7IhGOmJaS5gF044p04/xjQ0N+lpEe5ygbKNNuc=; b=cdHCU5cOoQoxI1Vw6FqKXCGfkOW1vLcFR/2V3jlkWfU+v8GaubbE1iQOPWidFbd+y5 22RcZu6EMHN9kojySEcuAold9/CCLi3oZ8m7Riz0qjdRgq+lNFqmuPEgPkpxNLFQTAQ2 wftX7i1yts8YFWHB1SYsyRG+pEVZXEBOod1UzLn+tgS8xuRHMlsgG6vD3CigzDflEYIz LTMtivQTyvLTdyPqKwuqfmCoPZo0BnvO2aV2JNSdNjkaZ7a6O2ckX0YC11dZbslGgLhN JjkNlfP66jZtp86vA0bXIm3TyOFPHvcWagbqpsO4AjwA6ZqUTwneI6hMeVHx9Y9KL604 7fjg== X-Gm-Message-State: ANoB5pkIx9cvygmqdZwPHWutBHnyb8ZGkzdAqZvGK70L90ffewvhEb9m tPaSPnVIUelvN//HFkQjhTU= X-Google-Smtp-Source: AA0mqf5r2zFkpfunkhfUWv4BTqp3STuDAMJk4nFUdgEYu6Wc8o2iihXaLkwEVjyxqStYcVpyq6tOrQ== X-Received: by 2002:a5d:68cd:0:b0:241:d609:9d40 with SMTP id p13-20020a5d68cd000000b00241d6099d40mr1256808wrw.305.1668977143152; Sun, 20 Nov 2022 12:45:43 -0800 (PST) Received: from ?IPV6:2a01:e0a:1dc:b1c0:5e76:d3a5:726f:e6da? ([2a01:e0a:1dc:b1c0:5e76:d3a5:726f:e6da]) by smtp.googlemail.com with ESMTPSA id 4-20020a05600c020400b003b492753826sm11200267wmi.43.2022.11.20.12.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 12:45:42 -0800 (PST) Message-ID: <181a331d-ba82-2caf-ce2b-f00665bcafc7@gmail.com> Date: Sun, 20 Nov 2022 21:45:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] Fix in _GLIBCXX_INLINE_VERSION mode Content-Language: fr To: Jonathan Wakely Cc: "libstdc++@gcc.gnu.org" , gcc-patches References: From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19/11/22 14:11, Jonathan Wakely wrote: > On Sat, 19 Nov 2022 at 13:03, François Dumont via Libstdc++ > wrote: >> Without this qualification I have this in _GLIBCXX_INLINE_VERSION mode: >> >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649: >> note: candidate: 'template bool std::__9::isxdigit(_CharT, >> const locale&)' >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649: >> note: template argument deduction/substitution failed: >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1540: >> note: candidate expects 2 arguments, 1 provided >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630: >> error: no matching function for call to 'isxdigit(const >> std::__9::basic_string_view::value_type&)' >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649: >> note: candidate: 'template bool std::__9::isxdigit(_CharT, >> const locale&)' >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649: >> note: template argument deduction/substitution failed: >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630: >> note: candidate expects 2 arguments, 1 provided >> compiler exited with status 1 >> FAIL: 17_intro/headers/c++2020/all_attributes.cc (test for excess errors) >> Excess errors: >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1540: >> error: no matching function for call to 'isxdigit(const >> std::__9::basic_string_view::value_type&)' >> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630: >> error: no matching function for call to 'isxdigit(const >> std::__9::basic_string_view::value_type&)' >> >> It sounds like the most reasonable fix as this is how toupper is being >> called. > I think the real problem is that include/c_global/cctype is missing > the NAMESPACE_VERSION macros. > > All declarations of std::isxdigit etc should be in the same namespace, > precisely so we don't need to do this. Didn't you want to fix it this way then ? To be honest I was a little bit lost by this code: #if !__has_builtin(__builtin_toupper) # include #endif Looks like cctype is included only for toupper, why not for isxdigit ? > >> libstdc++: Add missing std qualification on isxdigit calls >> >> libstdc++-v3/ChangeLog >> >> * include/std/format: Add std qualification on isxdigit calls. >> >> Ok to commit ? > Yes, OK. Committed.