From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17800 invoked by alias); 8 Nov 2007 11:00:36 -0000 Received: (qmail 17769 invoked by uid 22791); 8 Nov 2007 11:00:29 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Nov 2007 11:00:28 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lA8B0Pnv005979 for ; Thu, 8 Nov 2007 06:00:25 -0500 Received: from zebedee.littlepinkcloud.COM (vpn-14-118.rdu.redhat.com [10.11.14.118]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lA8B0OOt017348; Thu, 8 Nov 2007 06:00:24 -0500 Received: from littlepinkcloud.COM (localhost.localdomain [127.0.0.1]) by zebedee.littlepinkcloud.COM (8.13.8/8.13.5) with ESMTP id lA8B0MvT022413; Thu, 8 Nov 2007 11:00:23 GMT Received: (from aph@localhost) by littlepinkcloud.COM (8.13.8/8.13.5/Submit) id lA8B0MW5022410; Thu, 8 Nov 2007 11:00:22 GMT MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18226.60486.374665.909325@zebedee.pink> Date: Thu, 08 Nov 2007 11:00:00 -0000 From: Andrew Haley To: Alexandre Oliva , gcc-patches@gcc.gnu.org Subject: Re: stabilize java assertion tables In-Reply-To: <18226.59569.569614.837534@zebedee.pink> References: <18226.59569.569614.837534@zebedee.pink> X-Mailer: VM 7.19 under Emacs 22.0.93.1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-11/txt/msg00404.txt.bz2 Andrew Haley writes: > Alexandre Oliva writes: > > Using TYPE_UID rather than pointers to hash type_assertions shaved off > > another 70 -fvar-tracking-assignments (and, probably -g vs -g0) > > codegen differences. Now I'm down to four differences on > > x86_64-linux-gnu libs, yay. > > > > Ok for trunk, after retesting in it (rather than in the vta branch) > > completes? > > > > for gcc/ChangeLog.vta => gcc/java/ChangeLog > > from Alexandre Oliva > > > > * java/expr.c (type_assertion_hash): Hash type uids rather > > than tree pointers. > > > > I guess so. I don't understand that fragment of code at all, but I'll > trust you. Actually, that's a terrible thing for a maintainer to say. Blame a lack of coffee. If the assertion code is JV_ASSERT_TYPES_COMPATIBLE, we hash both op1 and op2; if it's JV_ASSERT_IS_INSTANTIABLE we only hash op1. And the switch statement with multiple fall-throughs is the best way to do this. OK. Andrew.