From: chenglulu <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact
Date: Thu, 23 Nov 2023 22:39:30 +0800 [thread overview]
Message-ID: <1825d81c-9eaa-c056-2ad1-1830449beeac@loongson.cn> (raw)
In-Reply-To: <8609363ca71e2a1022678caeddd98d40e415d413.camel@xry111.site>
在 2023/11/23 下午8:24, Xi Ruoyao 写道:
> On Thu, 2023-11-23 at 17:14 +0800, chenglulu wrote:
>> When I look at this code and compare it to our scalar implementation, it
>> seems
>>
>> that our scalar implementation still lacks an "lround".
> Should be "lroundeven". We don't have an instruction for lround :(.
>
> I tried this but it does not work:
>
> -(define_int_iterator LRINT [UNSPEC_FTINT UNSPEC_FTINTRM UNSPEC_FTINTRP])
> +(define_int_iterator LRINT
> + [UNSPEC_FTINT UNSPEC_FTINTRM UNSPEC_FTINTRP UNSPEC_FTINTRNE])
> (define_int_attr lrint_pattern [(UNSPEC_FTINT "lrint")
> (UNSPEC_FTINTRM "lfloor")
> - (UNSPEC_FTINTRP "lceil")])
> + (UNSPEC_FTINTRP "lceil")
> + (UNSPEC_FTINTRNE "lroundeven")])
> (define_int_attr lrint_submenmonic [(UNSPEC_FTINT "")
> (UNSPEC_FTINTRM "rm")
> - (UNSPEC_FTINTRP "rp")])
> + (UNSPEC_FTINTRP "rp")
> + (UNSPEC_FTINTRNE "rne")])
>
> The problem is "lroundevenMN2" is not a standard pattern name. The SIMD
> version of ftintrne in patch 1 only works because we are expanding
> "roundevenM2" (it's a standard pattern name) to UNSPEC_SIMD_FRINTRNE,
> and then a define_insn can match (fix (UNSPEC_SIMD_FRINTRNE op)). But
> for non-SIMD we don't have roundevenM2.
>
Okay, I understand. I think this is a bit regretful.
next prev parent reply other threads:[~2023-11-23 14:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 0:47 [PATCH v3 0/5] LoongArch: SIMD fixes and optimizations Xi Ruoyao
2023-11-20 0:47 ` [PATCH v3 1/5] LoongArch: Fix usage of LSX and LASX frint/ftint instructions [PR112578] Xi Ruoyao
2023-11-23 6:35 ` chenglulu
2023-11-23 7:11 ` Xi Ruoyao
2023-11-23 7:31 ` chenglulu
2023-11-23 8:13 ` chenglulu
2023-11-23 9:02 ` Xi Ruoyao
2023-11-23 9:12 ` chenglulu
2023-11-23 10:12 ` Xi Ruoyao
2023-11-23 12:06 ` Xi Ruoyao
2023-11-23 18:03 ` Joseph Myers
2023-11-24 2:39 ` Xi Ruoyao
2023-11-24 8:01 ` chenglulu
2023-11-24 8:26 ` Xi Ruoyao
2023-11-24 8:36 ` chenglulu
2023-11-24 8:42 ` Xi Ruoyao
2023-11-24 9:46 ` chenglulu
2023-11-24 10:30 ` Xi Ruoyao
2023-11-24 14:59 ` chenglulu
2023-11-23 8:54 ` Xi Ruoyao
2023-11-20 0:47 ` [PATCH v3 2/5] LoongArch: Use standard pattern name and RTX code for LSX/LASX muh instructions Xi Ruoyao
2023-11-23 12:08 ` chenglulu
2023-11-20 0:47 ` [PATCH v3 3/5] LoongArch: Use standard pattern name and RTX code for LSX/LASX rotate shift Xi Ruoyao
2023-11-23 8:42 ` chenglulu
2023-11-20 0:47 ` [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact Xi Ruoyao
2023-11-23 8:23 ` chenglulu
2023-11-23 8:58 ` Xi Ruoyao
2023-11-23 9:14 ` chenglulu
2023-11-23 12:24 ` Xi Ruoyao
2023-11-23 14:39 ` chenglulu [this message]
2023-11-20 0:47 ` [PATCH v3 5/5] LoongArch: Use LSX for scalar FP rounding with explicit rounding mode Xi Ruoyao
2023-11-29 7:12 ` Pushed: [PATCH v3 0/5] LoongArch: SIMD fixes and optimizations Xi Ruoyao
2023-11-29 7:45 ` chenglulu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1825d81c-9eaa-c056-2ad1-1830449beeac@loongson.cn \
--to=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).