From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 02CA03858C5F for ; Thu, 23 Nov 2023 14:40:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02CA03858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 02CA03858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700750406; cv=none; b=aMvEr+3W7jf3vxQhI1oJ0FPxfKwJggTb92pjPnN7fuUO0DzPHN7ojnXBpN9KEsc+UkFPg4K41hAyyNGZCmiO2c1rNlMVAXSKNxRBMVSnxsPDYHnAeIq8nVuV9FIhdCTf8e8qeDVTACESHoea9drU0URAol5Gh5zd5kyNvm37yhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700750406; c=relaxed/simple; bh=uOJiASrx2R1GkkPJohKOrxoxHVOmRe9MIDVKYNP0iHE=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=YID/jxi9MDPznmOB30x+yun0hDsPSpg7q80SKlIuqmZ22Ro0LPzISEH9cBh4ZKkaxQ+prMdPYjVK0PpQDaMKfFm8w3J2m6zVIvlwXiv9+devbIybfNB4YdrF124fOiSgXd+ud9Z7HTj/UkpRauHeheqqeAJAzk6My6etCiFJcz4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [117.129.62.95]) by gateway (Coremail) with SMTP id _____8CxtPBAZF9l+E08AA--.54940S3; Thu, 23 Nov 2023 22:40:01 +0800 (CST) Received: from [192.168.2.109] (unknown [117.129.62.95]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxzdwiZF9l49FKAA--.34036S3; Thu, 23 Nov 2023 22:40:00 +0800 (CST) Subject: Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20231120004728.205167-1-xry111@xry111.site> <20231120004728.205167-5-xry111@xry111.site> <7a4ceec5-2545-f30a-af44-7f7767620b76@loongson.cn> <1d8a856e-d810-3bc9-b985-44c105802bf0@loongson.cn> <8609363ca71e2a1022678caeddd98d40e415d413.camel@xry111.site> From: chenglulu Message-ID: <1825d81c-9eaa-c056-2ad1-1830449beeac@loongson.cn> Date: Thu, 23 Nov 2023 22:39:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <8609363ca71e2a1022678caeddd98d40e415d413.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxzdwiZF9l49FKAA--.34036S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7AFW5Ar4DGFy7ZF1DAr4DWrX_yoW8Jw1xpw 1DJF15Kr45Zw12ka45ta45AFyaqr4DXasrKFZxG343Grn8Jr1Ykr1fA3y5WFWUW3s5JrW5 uryrta45JFW5tFXCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw 1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UN vtZUUUUU= X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/11/23 下午8:24, Xi Ruoyao 写道: > On Thu, 2023-11-23 at 17:14 +0800, chenglulu wrote: >> When I look at this code and compare it to our scalar implementation, it >> seems >> >> that our scalar implementation still lacks an "lround". > Should be "lroundeven". We don't have an instruction for lround :(. > > I tried this but it does not work: > > -(define_int_iterator LRINT [UNSPEC_FTINT UNSPEC_FTINTRM UNSPEC_FTINTRP]) > +(define_int_iterator LRINT > + [UNSPEC_FTINT UNSPEC_FTINTRM UNSPEC_FTINTRP UNSPEC_FTINTRNE]) > (define_int_attr lrint_pattern [(UNSPEC_FTINT "lrint") > (UNSPEC_FTINTRM "lfloor") > - (UNSPEC_FTINTRP "lceil")]) > + (UNSPEC_FTINTRP "lceil") > + (UNSPEC_FTINTRNE "lroundeven")]) > (define_int_attr lrint_submenmonic [(UNSPEC_FTINT "") > (UNSPEC_FTINTRM "rm") > - (UNSPEC_FTINTRP "rp")]) > + (UNSPEC_FTINTRP "rp") > + (UNSPEC_FTINTRNE "rne")]) > > The problem is "lroundevenMN2" is not a standard pattern name. The SIMD > version of ftintrne in patch 1 only works because we are expanding > "roundevenM2" (it's a standard pattern name) to UNSPEC_SIMD_FRINTRNE, > and then a define_insn can match (fix (UNSPEC_SIMD_FRINTRNE op)). But > for non-SIMD we don't have roundevenM2. > Okay, I understand. I think this is a bit regretful.