From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128961 invoked by alias); 2 Dec 2015 22:23:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128945 invoked by uid 89); 2 Dec 2015 22:23:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: aries.uberspace.de Received: from aries.uberspace.de (HELO aries.uberspace.de) (95.143.172.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 02 Dec 2015 22:23:06 +0000 Received: (qmail 2291 invoked from network); 2 Dec 2015 22:23:02 -0000 Received: from localhost (HELO kubuntu.localnet) (127.0.0.1) by aries.uberspace.de with SMTP; 2 Dec 2015 22:23:02 -0000 From: Jan Sommer To: gcc-patches@gcc.gnu.org Cc: Joel Sherrill , Jeff Law , "devel@rtems.org" , "sebastian.huber@embedded-brains.de" Subject: Re: [PATCH] Fix declaration of pthread-structs in s-osinte-rtems.ads (ada/68169) Date: Wed, 02 Dec 2015 22:23:00 -0000 Message-ID: <1838497.lGhAiFNhbp@kubuntu> User-Agent: KMail/5.0.2 (Linux/4.2.0-18-generic; KDE/5.15.0; x86_64; ; ) In-Reply-To: References: <3667951.xxJfb3I2z2@kubuntu> <565E9A4E.6070101@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00374.txt.bz2 Am Wednesday 02 December 2015, 08:13:20 schrieb Joel Sherrill: > > On December 2, 2015 2:14:22 AM EST, Jeff Law wrote: > >On 12/01/2015 12:56 PM, Jan Sommer wrote: > >> Am Monday 30 November 2015, 16:19:30 schrieb Jeff Law: > >>> On 11/30/2015 03:06 PM, Jan Sommer wrote: > >>>> Could someone with write access please commit the patch? > >>>> The paperwork with the FSF has gone through. If something else is > >missing, please tell me. > >>>> I won't be available next week. > >>> I'm not sure what you built your patches again, but I can't apply > >them > >>> to the trunk. Can you resend a patch as a diff against the trunk. > >>> > >>> Often I can fix things by hand, but this is Ada and I'd be much more > >>> likely to botch something. > >> > >> I updated the patches again. They should now fit with the heads of > >the respective branches again. > >> Maybe the Changelog will be out of synch again. > >> The patches are for the following branches: > >> ada-68169_4.9.diff --> gcc-4_9-branch > >> ada-68169_5.x.diff --> gcc-5-branch > >> ada-68169_trunk.diff --> trunk > >> > >> Let me know if they apply this time. I used svn diff to create them > >and used patch -p0 to test if they apply locally. > >THanks. I've committed this to the trunk based on Joel's comments. > > > >The gcc-5 branch is frozen for the upcoming release and gcc-4.9 is > >regression/doc fixes only. It'll be up to the release managers whether > > > >or not to backport to those branches. > > Thanks Jeff. > > I would consider this a regression. RTEMS changed the pthread_attr_t when we added thread affinity and updating Ada to match slipped through. We knew it needed attention for SMP but missed this critical piece to keep it working. > > Jan.. Is there a gcc PR for this? To get it on a release branch, it is better to have one. > Yes, I created this one: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68169