From: Jeff Law <law@redhat.com>
To: Bernd Schmidt <bschmidt@redhat.com>,
"Andre Vieira (lists)" <Andre.SimoesDiasVieira@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE
Date: Fri, 09 Dec 2016 16:01:00 -0000 [thread overview]
Message-ID: <18603e32-692f-9147-632f-e0ef4261a7a6@redhat.com> (raw)
In-Reply-To: <334ff580-3e7d-22fb-83da-da18acd84244@redhat.com>
On 12/09/2016 08:02 AM, Bernd Schmidt wrote:
> On 12/09/2016 03:03 PM, Andre Vieira (lists) wrote:
>> This patch fixes the issue reported in PR78255 by making postreload
>> aware it should not be performing CSE on functions if NO_FUNCTION_CSE is
>> defined to true.
>>
>> Bootstrap and full regression on arm-none-linux-gnueabihf and
>> aarch64-unknown-linux-gnu.
>>
>> Also checked this fixed the reported issue on arm-none-eabi.
>>
>> Is this OK for trunk?
>
> Hmm, it probably doesn't hurt, but looking at the PR I think the
> originally reported problem suggests you need a different fix: a
> separate register class to be used for indirect sibling calls. I
> remember seeing similar issues on other targets.
I think we actually split the call patterns into direct and indirect
variants on the PA when we stumbled on this in cse.c.
Jeff
next prev parent reply other threads:[~2016-12-09 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 14:03 Andre Vieira (lists)
2016-12-09 15:02 ` Bernd Schmidt
2016-12-09 15:34 ` Andre Vieira (lists)
2016-12-09 15:58 ` Bernd Schmidt
2016-12-09 16:02 ` Ramana Radhakrishnan
2016-12-09 16:16 ` Andre Vieira (lists)
2016-12-09 16:31 ` Bernd Schmidt
2016-12-09 17:22 ` [arm-embedded][committed] " Andre Vieira (lists)
2017-01-06 10:53 ` [PATCH] " Andre Vieira (lists)
2017-01-06 15:47 ` Jeff Law
2017-01-11 15:09 ` Andre Vieira (lists)
2016-12-12 9:05 ` Christophe Lyon
2016-12-20 16:48 ` [ARM][committed] Fix for PR78255-2.c testism for targets that do not optimize for tailcall Andre Vieira (lists)
2016-12-09 16:01 ` Jeff Law [this message]
2016-12-09 15:47 [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18603e32-692f-9147-632f-e0ef4261a7a6@redhat.com \
--to=law@redhat.com \
--cc=Andre.SimoesDiasVieira@arm.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).