From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85287 invoked by alias); 17 Oct 2017 20:12:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 85277 invoked by uid 89); 17 Oct 2017 20:12:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:728 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 20:12:36 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id EEB4B81A10; Tue, 17 Oct 2017 22:12:34 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K_D5fxZ0fzUH; Tue, 17 Oct 2017 22:12:34 +0200 (CEST) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id AC30381549; Tue, 17 Oct 2017 22:12:34 +0200 (CEST) From: Eric Botcazou To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, Nathan Sidwell , Pierre-Marie de Rodat , Jeff Law , Richard Biener Subject: Re: Unbreak Ada bootstrap (was Re: [PATCH PR/82546] tree node size) Date: Tue, 17 Oct 2017 20:21:00 -0000 Message-ID: <1861897.NJvYQB7GQQ@polaris> User-Agent: KMail/4.14.10 (Linux/3.16.7-53-desktop; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20171017192946.GB14653@tucnak> References: <3e7ecb64-cd96-47a3-cb75-53e41317d90c@acm.org> <20171017192946.GB14653@tucnak> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2017-10/txt/msg01101.txt.bz2 > This change broke Ada bootstrap, because the FE doesn't have any tree_size > langhook, but has one language specific tcc_type tree - > UNCONSTRAINED_ARRAY_TYPE. There should be a requirement to test all languages for this kind of changes. > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk? > > 2017-10-17 Jakub Jelinek > > * langhooks.h (struct lang_hooks): Document that tree_size langhook > may be also called on tcc_type nodes. > * langhooks.c (lhd_tree_size): Likewise. > > * gcc-interface/misc.c (gnat_tree_size): New function. > (LANG_HOOKS_TREE_SIZE): Redefine. OK, thanks. -- Eric Botcazou