From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21325 invoked by alias); 5 Nov 2008 17:12:02 -0000 Received: (qmail 21181 invoked by uid 22791); 5 Nov 2008 17:12:01 -0000 X-Spam-Check-By: sourceware.org Received: from smarthost.piip.TechFak.Uni-Bielefeld.DE (HELO smarthost.TechFak.Uni-Bielefeld.DE) (129.70.137.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Nov 2008 17:11:07 +0000 Received: from manam.TechFak.Uni-Bielefeld.DE (manam.TechFak.Uni-Bielefeld.DE [129.70.137.47]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smarthost.TechFak.Uni-Bielefeld.DE (Postfix) with ESMTP id 3C17648308; Wed, 5 Nov 2008 18:11:04 +0100 (CET) From: Rainer Orth Message-ID: <18705.54181.858026.33670@manam.TechFak.Uni-Bielefeld.DE> Date: Wed, 05 Nov 2008 17:12:00 -0000 To: Ian Lance Taylor Cc: gcc-patches@gcc.gnu.org Subject: Re: 4.3/4.4 PATCH: Fix Solaris/x86 bootstrap with Sun ld (PR bootstrap/33100) In-Reply-To: References: <18671.26770.804364.445962@manam.TechFak.Uni-Bielefeld.DE> X-Mailer: VM 6.62 under Emacs 19.34.1 Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-11/txt/msg00177.txt.bz2 Ian Lance Taylor writes: > Rainer Orth writes: > > > Fri Oct 10 16:27:14 2008 Rainer Orth > > > > PR bootstrap/33100 > > * config.gcc (i[34567]86-*-solaris2*): Include i386/t-crtstuff > > only with GNU ld. > > I may well misunderstand, but this seems like a somewhat hacky > workaround which avoids a bug in the linker by introducing a bug in > the unwind information. However, I don't have a better suggestion, true, and I'm not really comfortable about it either. But since no fix has been forthcoming on the Solaris 10 side and GCC 4.2+ have been inoperational on Solaris 10+/x86, I decided to propose it anyway. > and it sounds like this will be fixed in later versions of Solaris. As I suggested in the original patch submission, it should be possible to move the inclusion of i386/t-crtstuff to libgcc/configure.ac and make it conditional on a linker test there. This way, only systems with broken Sun linkers would be penalized. I could well try that approach, since it's certainly cleaner and doesn't break unwind information on recent Solaris 11 where we don't have to. What do you think? > I'll approve this patch for mainline and 4.3 branch. What about the 4.2 branch? As I mentioned, the patch is needed there, too, and I've successfully bootstrapped on i386-pc-solaris2.10. Unfortunately, the cleaner approach outlined above isn't available here since there's no separate libgcc with it's own configure, so I fear it's either this hack or leave that branch broken. Thanks. Rainer ----------------------------------------------------------------------------- Rainer Orth, Faculty of Technology, Bielefeld University