From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id C4A52385C411 for ; Mon, 9 Aug 2021 14:36:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4A52385C411 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x334.google.com with SMTP id f9-20020a05600c1549b029025b0f5d8c6cso14850056wmg.4 for ; Mon, 09 Aug 2021 07:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RJBB5qF2qG82Ow8kIYnzLPc4GkECPhuAOoBI3xkICJA=; b=0WUZwDC1RBYAZAPtWC4iuhUCnR0JlwZPmdBMWfrIoX+8Yor/TrdP41bh74JnI/6oGY 06HONIA9d3//ilqDJzwM85wDDDVJPuj2UQUGD1Qb5wyX6n92WdU2ttZo/vi0C8U42tGn YfVn71xFTSvz+hfAciJwbtU1Ql+oAkdqbede1AUFAHYxhkkoHcKqy2B1Jj3X/986njDl ybFCEPJsUMcj4WiOLaOblhnv0kKs8WBEPB/2rGLfiNY8JMB24w2+BVV24j1lcKLYp9Qt A/E5u6QgV7IY0iFC4T4XTvfnqNiX+UxJq2gs9jazFW18lIJt8YDJckhoVqXjfffEGnrd Q5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RJBB5qF2qG82Ow8kIYnzLPc4GkECPhuAOoBI3xkICJA=; b=pHM/EZ32zXdbm+OGIFhu7RnA3PSzjQPKHms3uSUKoLCZ7GendQOwRVzUT0I3MIxb3v Cp6TeSou6B/Z0oRGTTytxGX2zbTGXUn/3q3NVBOoTOVOKnBg6kGAFT4kpwtYyyEONrNl 1tde6GrfwOM6Oh9v+X/neVA7+uhgYJxjJ+k9YXVcr90F/z/2B+cWB6lStZ9wCwfZqLsT aZ73CrimwqmCDtyNZ85LTCv70AgXDiKyB+FgXv7QlbbICymmb6uqfsktVgCxPmrIJzNf qgA94pKB/E48cAyB2a0khvBUgcexacpTbhCbEKMH5Ik0x48HebK1N+napl7Ihh3JUIlZ mdaw== X-Gm-Message-State: AOAM531qOMMXDFT3ELVoMZhz+GXIn8kXjLAqfYGpU6SuNf7xvVNW5iqD QfuQ4pe9UPbJufrHxojaD+Dh7Q== X-Google-Smtp-Source: ABdhPJzHh8fj8FMlkEqTUwl9W92mW8hXFTMIGQrtKO9wH7MQgqOtmaLfIdypXiZCfV1mXYc0yEGhOg== X-Received: by 2002:a1c:a709:: with SMTP id q9mr33857710wme.23.1628519796734; Mon, 09 Aug 2021 07:36:36 -0700 (PDT) Received: from arcturus.localnet ([37.171.85.201]) by smtp.gmail.com with ESMTPSA id m39sm1987974wms.10.2021.08.09.07.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 07:36:35 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Bernd Edlinger Cc: gcc-patches@gcc.gnu.org, Richard Biener , Arnaud Charlet Subject: Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions Date: Mon, 09 Aug 2021 16:37:08 +0200 Message-ID: <1886121.usQuhbGJ8B@arcturus> In-Reply-To: References: <2152447.iZASKD2KPV@arcturus> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Aug 2021 14:36:39 -0000 > But it is okay that we can set a breakpoint on defs__struct1IP, > in the test case of PR 101598. > And the debugger shall only show assembler here. > Right? The defs__struct1IP procedure should be totally transparent for the user, so setting a breakpoint in it is not supposed to come into play. > Do you have an example where this location information is used in the > compiler itself for debugging? That's useful when you compile the code with -gnatD, i.e when you debug the intermediate code generated by the front-end. > I assume You would agree that having the location for Test2 is better > than no debug info at all? But we want no debug info at all for these IP functions. > What do you think? I guess I still don't understand why DECL_IGNORED_P was changed. -- Eric Botcazou