public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Peter Bergner <bergner@linux.ibm.com>
Cc: Martin Jambor <mjambor@suse.cz>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] SRA: Force gimple operand in an additional corner case (PR 112822)
Date: Wed, 13 Dec 2023 11:24:42 -0500	[thread overview]
Message-ID: <18b080da-b071-4f63-8257-dd5025030d4f@redhat.com> (raw)
In-Reply-To: <73527e3a-e56f-46d3-afef-615ace014cb5@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

On 12/12/23 21:36, Jason Merrill wrote:
> On 12/12/23 17:50, Peter Bergner wrote:
>> On 12/12/23 1:26 PM, Richard Biener wrote:
>>>> Am 12.12.2023 um 19:51 schrieb Peter Bergner <bergner@linux.ibm.com>:
>>>>
>>>> On 12/12/23 12:45 PM, Peter Bergner wrote:
>>>>> +/* PR target/112822 */
>>>>
>>>> Oops, this should be:
>>>>
>>>> /* PR tree-optimization/112822 */
>>>>
>>>> It's fixed on my end.
>>>
>>> Ok
>>
>> Pushed now that Martin has pushed his fix.  Thanks!
> 
> This test is failing for me below C++17, I think you need
> 
> // { dg-do compile { target c++17 } }
> or
> // { dg-require-effective-target c++17 }

Fixed thus.



[-- Attachment #2: 0001-testsuite-fix-g-.dg-pr112822.C.patch --]
[-- Type: text/x-patch, Size: 810 bytes --]

From d2b269ce30d77dbfc6c28c75887c330d4698b132 Mon Sep 17 00:00:00 2001
From: Jason Merrill <jason@redhat.com>
Date: Tue, 12 Dec 2023 21:33:11 -0500
Subject: [PATCH] testsuite: fix g++.dg/pr112822.C
To: gcc-patches@gcc.gnu.org

gcc/testsuite/ChangeLog:

	* g++.dg/pr112822.C: Require C++17.
---
 gcc/testsuite/g++.dg/pr112822.C | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/g++.dg/pr112822.C b/gcc/testsuite/g++.dg/pr112822.C
index a8557522467..9949fbb08ac 100644
--- a/gcc/testsuite/g++.dg/pr112822.C
+++ b/gcc/testsuite/g++.dg/pr112822.C
@@ -1,6 +1,7 @@
 /* PR tree-optimization/112822 */
 /* { dg-do compile { target c++17 } } */
 /* { dg-options "-w -O2" } */
+// { dg-do compile { target c++17 } }
 
 /* Verify we do not ICE on the following noisy creduced test case.  */
 
-- 
2.39.3


  parent reply	other threads:[~2023-12-13 16:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 16:50 Martin Jambor
2023-12-12 17:17 ` Richard Biener
2023-12-12 18:45 ` Peter Bergner
2023-12-12 18:51   ` Peter Bergner
2023-12-12 19:26     ` Richard Biener
2023-12-12 22:50       ` Peter Bergner
2023-12-13  2:36         ` Jason Merrill
2023-12-13  5:26           ` Peter Bergner
2023-12-13  7:51             ` Richard Biener
2023-12-13  8:05               ` Jakub Jelinek
2023-12-13 14:21                 ` Peter Bergner
2023-12-13 16:24           ` Jason Merrill [this message]
2023-12-13 16:26             ` Jakub Jelinek
2023-12-13 19:23               ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18b080da-b071-4f63-8257-dd5025030d4f@redhat.com \
    --to=jason@redhat.com \
    --cc=bergner@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).