From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id E8C9B3858D3C for ; Fri, 7 Oct 2022 14:15:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8C9B3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1029.google.com with SMTP id a5-20020a17090aa50500b002008eeb040eso7057345pjq.1 for ; Fri, 07 Oct 2022 07:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wXyJ34a1NpaGAILCrOKUlef5wep+GsVzM8tn22jL1Y0=; b=WgRlNxsA/M6fJU326sL130ggOjDNlq8Nbfi32X/rRPgA7HeP0HhWAxq4z4KqiEe9+v IVa6hk5ztoUjD4MR52cB8BFR1KVMo/FHDu1InImlZODFHEEBUvkpRaMmh/LB6DmBW+eg KVsib6MlR6Wuv43o3gzH8L0FXz3Rq+KhbIawdeprvRue+1ostYhqdnYDwfp1sfUMO53e Ebn37SbpnQWmbC5tOwC6+j7vvM8tmlDQ0HlxH662sH57nzPl0SOUBjOIdQChRNFfIeZP P4Ix8SxQcy2lcP24dwCc9rCyDF7AoEIruF/+LI3oj+GXxE034KYXQ2WCSDM6UBRnf6mm M5iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wXyJ34a1NpaGAILCrOKUlef5wep+GsVzM8tn22jL1Y0=; b=NFI51FY46UjUWVHsK+/VxN76qRF+UUVzBK/YHT0qbiR2CdIKWHd7JVCNgLwbm/t+K/ iSrIvzvHMq1vKk0dX5XW7quKWvcY3LxsgeFvXwNMAQV0H0/+d7b11xAxg594c7sQmgPw mZ9aP3xKtinstwD9ppfRRvCn2h1OUh0ZlqrPwTl0ChpprL/U7rsUPFci9+Ve+vLXphsW pNL2XV7PexJtCQXN22NEFcQ4febxODgF1e0iUqoDJXSIcHuHyT1eNHMQrNWotHqfu8sm tzpCxt/aU13PRwm++kKwQikPEdN1r2V3ABzGFpN4pXQuqSP2/5y8IN9xQ7x6Li2Jhtt6 y6KA== X-Gm-Message-State: ACrzQf0RdlYm2Ki6zl6iE/uYVEDXbjvYWXiyF3viowCB2367ZTHu/L9e VEi7PMl7kk9yS9z8/43/nf8= X-Google-Smtp-Source: AMsMyM6/1gX4i64i/3dbA4a+0JayjkJiKBvz9bfR49k8n4XQaDVlPvEwSRgu5IF5l4id+riTwSHEZg== X-Received: by 2002:a17:90b:1d07:b0:203:6732:e280 with SMTP id on7-20020a17090b1d0700b002036732e280mr16163782pjb.172.1665152150825; Fri, 07 Oct 2022 07:15:50 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id d6-20020a170902cec600b00176a715653dsm1593757plg.145.2022.10.07.07.15.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Oct 2022 07:15:49 -0700 (PDT) Message-ID: <18d7d1c0-1e05-8e30-6f16-0665d15be184@gmail.com> Date: Fri, 7 Oct 2022 08:15:49 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] cselib: Skip BImode while keeping track of subvalue relations [PR107088] Content-Language: en-US To: Stefan Schulze Frielinghaus Cc: gcc-patches@gcc.gnu.org References: <20221004112849.27678-1-stefansf@linux.ibm.com> <43be68a9-3069-26eb-8b1a-4f9215e02f8d@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/6/22 01:06, Stefan Schulze Frielinghaus wrote: > On Wed, Oct 05, 2022 at 08:48:13PM -0600, Jeff Law via Gcc-patches wrote: >> On 10/4/22 05:28, Stefan Schulze Frielinghaus via Gcc-patches wrote: >>> For BImode get_narrowest_mode evaluates to QImode but BImode < QImode. >>> Thus FOR_EACH_MODE_UNTIL never reaches BImode and iterates until OImode >>> for which no wider mode exists so we end up with VOIDmode and fail. >>> Fixed by adding a size guard so we effectively skip BImode. >>> >>> Bootstrap and regtest are currently running on x64. Assuming they pass >>> ok for mainline? >>> >>> gcc/ChangeLog: >>> >>> PR rtl-optimization/107088 >>> * cselib.cc (new_cselib_val): Skip BImode while keeping track of >>> subvalue relations. >> OK.  And FWIW, this fixes the various failures I saw in my tester due to the >> cselib patches. > Thanks for testing, too! Out of curiosity which target is your tester? > I gave it a try on x64 and AArch64 for which bootstrap went fine and > regtest showed no difference, and of course, for s390x regtest went for > the better. It's got at least one representative from most of the targets supported by gcc. http://law-sandy.freeddns.org:8080 will get you to the jenkins instance. Jeff