From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id CF7CB3857C71 for ; Sat, 24 Jun 2023 14:03:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF7CB3857C71 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-666e6541c98so1508718b3a.2 for ; Sat, 24 Jun 2023 07:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687615430; x=1690207430; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jU4GvnHTzXo2ydeWAUUWMyqxOUBsfFgSeQLAnpSSWgU=; b=qi6nrllozTZGr/0QnGZlZz9l6FG/cVefV11RlOu0S6l299UuoicTRXL4T8jYg0f3NF CNoU23lD1zf21jjDXhkxmvEt6kd6GMJvGCYq/z+5IR4gp6Wf8aT2BCp5jGPkQINF42pM oAhQ4F4Xko9HKGzySrwNrK6W3Zfw+4h+uRGfSnYD0EVS5Hhz+/luQxbBqzdvgB0OIpJw erGS9KH/Ou2H/v20PEfyJ0dh8nG8PEWO5vczdAn/LNHDtuzXLnpDinqqOB35EAR9Bs35 HrIJOXhB/5cn9oiWcTZ527pBgbu6qf76JNqegk7O8BFnrMK2zKGd49E+AgKjDggZEatU KVkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687615430; x=1690207430; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jU4GvnHTzXo2ydeWAUUWMyqxOUBsfFgSeQLAnpSSWgU=; b=P4B85bDe9JSanu7sQZs+M4eCJQ8p2uh2EBlptG9O+0Zl9jf0yPOuYNPUrSmMZ+YQ6o 0va6rKEkIuPZK/okzrLYn0IjfeDfvEJqMlMT8mpLL96fRCe9V61dtMn9zaq/U/0rfcEr 0LhVgvjjaLMYeLuQSK1lqmME32gd/uOIXjP7zZKiuJJ5pZEQqCZ8vS2eQ1QhgtuIie7u rwmvoeAVE7EQxiD9JmF+PPiOO1Zt8xfME0KCjILErUd0rhP6ilX3CZk4rvDE7IIY6by6 eT5qdyEsIzqm2WBPwKWgBqXswZedqibdwYCwJs7zotK9rHT6LfWvRsB0jVIZqVzoebAq d1GA== X-Gm-Message-State: AC+VfDx4chp+RqMXOKaW/QcZwgInFhzKO7RyGAPhkFkunANeYY8s9HXC 9O9Ih5XxzMWr8knvSlRnixg= X-Google-Smtp-Source: ACHHUZ6mv2Tqind+7ANN//aMcE8MDBIDChxmzKU8PK61gYu8ZZ8jW8u8gyoimZzHeRBCu7lwjrZgZQ== X-Received: by 2002:a05:6a20:9146:b0:104:1f67:1157 with SMTP id x6-20020a056a20914600b001041f671157mr30671271pzc.26.1687615429621; Sat, 24 Jun 2023 07:03:49 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id w2-20020a636202000000b005439aaf0301sm1287262pgb.64.2023.06.24.07.03.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jun 2023 07:03:49 -0700 (PDT) Message-ID: <18dffc14-01b4-ee87-d4a4-0423a4d9f727@gmail.com> Date: Sat, 24 Jun 2023 08:03:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] RISC-V: Refactor the integer ternary autovec pattern Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org Cc: kito.cheng@sifive.com, palmer@rivosinc.com, rdapp.gcc@gmail.com References: <20230621223842.259423-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20230621223842.259423-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/21/23 16:38, Juzhe-Zhong wrote: > Long time ago, I encounter ICE when trying to set clobber register as Pmode > and I forgot the reason. > > So, I clobber SI scratch and PUT_MODE to make it Pmode after reload which > makes patterns look unreasonable. > > According to Jeff's comments, I tried it again, it works now when we try to > set clobber register as Pmode and the patterns look more reasonable now. > > The tests are all passed, Ok for trunk. > > gcc/ChangeLog: > > * config/riscv/autovec.md (*fma): set clobber to Pmode in expand stage. > (*fma): Ditto. > (*fnma): Ditto. > (*fnma): Ditto. OK jeff