From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D420A3858D35 for ; Mon, 29 Apr 2024 18:33:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D420A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D420A3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714415623; cv=none; b=kBNiBdYVlF9NcE5u+C+m2XBY1zBsigJMJ2uWzu1FY5Txv3VKMHuJcA5mySs1G4MTYOd9vT/A7i0vburCvpkT00z1xJpCVC3BGw7u6SP2tv9CfCZriVyWm0dbS7HrC5Gz1P74h+DCYnoiq9hFt70NsXPq9SzCnV2tBUCNu2Ghkwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714415623; c=relaxed/simple; bh=kxwlbi6a9b1wbxxNtXV/m/q4rKVYHVNIq7Fs2Ddj2r8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=d/5kqdEwZ3oI8tTioOurq4RarVv0jo7s7Q5mr7U+DH+ndSTRN+NKgQcoH9KQD9Dtk8b7thXvFzQKSKWgpMpwX4EY8Ssa9o2C3YnZWH+is5fEelg1QKacDk2SLK/xpO2xezKnW59FUgdzzScnNXhmvcZu/kAQhLFhnt5Ov62jFgA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714415620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kXwSUst+/Jf7Uezqa6/G9MQznSB1PAcKM62ON+PC84E=; b=FOy92GrdpGN/rRl+/FJfr5bORkVuzFRbtqxNo7wAPwNiAnRaFwe6ZBWqCzdR5soXpry9kN 2IsITffO2HKtdKL6UZgys96lQNAEhEP3+5ryXUAIS5FUaFJB5KpQYkGu/xcWz9HYCoCwEI ZN1QaCTqBkniIZUWdS2UheuNjEVpAe4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-DN0XZbBnMsGQArhcT5U-7g-1; Mon, 29 Apr 2024 14:33:38 -0400 X-MC-Unique: DN0XZbBnMsGQArhcT5U-7g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41895b0a62cso34215055e9.2 for ; Mon, 29 Apr 2024 11:33:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714415617; x=1715020417; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kXwSUst+/Jf7Uezqa6/G9MQznSB1PAcKM62ON+PC84E=; b=GJpOpbdI8LjRBAQqFRU2/Pn3S9LX/K53ksZeSfndLhelKxDCO0xbX9PlUXqqDecTOY XwKyFgBzXc5T1MEYhmYrghIrF6GKB+ndB0huEm65GpilQLI3yWCIvwLOshtiiOvWZcHC pCR36zHOv2wNdRZNSdvBBsXLG5xIcKZ/rCaEw7EPdnk+nYcLvZIShdbbVEH+35KDlusK +e+aoNGTlx+7Hnw4qAXGIClkT7EaOe3wzfsGSEEpJI59rZiTfL0wLNaqSqXwk5/l4kd8 gKxwA+CuDyky5QFP44oMNCnqkS3PpAXu0GrRxcOyWLd9lsTbMIS5Jf2I6QoDhxO3cYsM vZmA== X-Forwarded-Encrypted: i=1; AJvYcCWMjOKfXqH9hpolvkcitGlZRWfvmj0BWJ7VIB+TfAGE9AN760sTzpQjSd/R2vtUxT68vq8ek2075xqIud5lewsHMxdKMpsuYQ== X-Gm-Message-State: AOJu0YyRNukGj9AHEkGsv2i9Xur3owiebk9R0eLpUIYuuUcvjwvWRIPM TzCSQVFFzZIWSqQQNlU3TauuBbm+BcRnaaOmyQm8ELc5uxqE6gTRVXLHTJ+5ncbsHsvh/kQlln6 Bbz8rGdx4Yy+RzStLrbQDI5mWrtA1nSkHGJJ2wbWgSlkv82X2s4OQ2E4= X-Received: by 2002:a05:600c:1d88:b0:41b:bb90:4af with SMTP id p8-20020a05600c1d8800b0041bbb9004afmr8217205wms.20.1714415617684; Mon, 29 Apr 2024 11:33:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJcVyzpHPa3uKMMSeo+2PdF8zrZDezP5FTm8oPdJcH+YxnFhuZa2ScE0ToMQilFq6zdypL0g== X-Received: by 2002:a05:600c:1d88:b0:41b:bb90:4af with SMTP id p8-20020a05600c1d8800b0041bbb9004afmr8217186wms.20.1714415617292; Mon, 29 Apr 2024 11:33:37 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id l23-20020a05600c1d1700b00418f99170f2sm40220378wms.32.2024.04.29.11.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 11:33:36 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1s1VoB-003L4X-Fb; Mon, 29 Apr 2024 18:32:59 +0000 Date: Mon, 29 Apr 2024 18:32:59 +0000 (UTC) From: Joseph Myers To: Jakub Jelinek cc: Richard Biener , gcc-patches@gcc.gnu.org, Jonathan Wakely , Florian Weimer Subject: Re: [PATCH] libgcc: Do use weakrefs for glibc 2.34 on GNU Hurd In-Reply-To: Message-ID: <18e6be82-5da6-7148-3ad2-c959a6c31b5d@redhat.com> References: <8eaa4872-ee98-c4dd-312-498687ccfffb@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 29 Apr 2024, Jakub Jelinek wrote: > On Mon, Apr 29, 2024 at 01:44:24PM +0000, Joseph Myers wrote: > > > glibc 2.34 and later doesn't have separate libpthread (libpthread.so.0 is a > > > dummy shared library with just some symbol versions for compatibility, but > > > all the pthread_* APIs are in libc.so.6). > > > > I suspect this has caused link failures in the glibc testsuite for Hurd, > > which still has separate libpthread. > > > > https://sourceware.org/pipermail/libc-testresults/2024q2/012556.html > > So like this then? I can't really test it on Hurd, but will certainly > test on x86_64-linux/i686-linux. > > 2024-04-29 Jakub Jelinek > > * gthr.h (GTHREAD_USE_WEAK): Don't redefine to 0 for glibc 2.34+ > on GNU Hurd. Yes, this fixes the problem seem for Hurd with build-many-glibcs.py. -- Joseph S. Myers josmyers@redhat.com