From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 352A53858D37 for ; Mon, 11 Mar 2024 09:51:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 352A53858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 352A53858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710150681; cv=none; b=duqj609lIgYWohjdDlmc2HVWE9PU4+KbnK7hEExHvOn2ru3zoMK/GxUGi9PdbPyCuItKMsyQgiKh98ArUvYA8MtA2kPvP/AtN073kdwdQ6RMWovYCnAx6t3sIkWKdzv4Smd+0EUZDChAn4xGFf25PUK9i0BJ7MoS3uEduhemczE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710150681; c=relaxed/simple; bh=6Ovezuc7/fx5VCmjte9vNXDFDeg5dwOsZ9kdBeAiiKc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=iRt/v0QYTyUD5ecRDDAl3jr9QGmOmBYvSWe45rm3p68Co7bdLRHAuWGHncVednZ0FTO506mc0YSbufE+JUuTCEHHZAbbTAH7LLbOkD18t0WCoRHHcuQ8vVWT3RczS8jX/PenUBLPREfvjbCpQmra7gMpV/eabqnPXg+XW5g7pqo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0081621C66; Mon, 11 Mar 2024 09:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710150679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LCvmT8jjHNAmEJnDHw2lWAJr/UFBiE9L7VcCxaDZJ8o=; b=Gca/CxyEeinGE6P0dgsNfvV+i6rq/dnPo4PAz2m6fXDg7wd3zvgRSEcWNfMF+450W87pTl W9dIvCvqjEgr4aIa6NSrnlOSI/Lm+U8jCDYpqPnleu1ermwkE3RaHK+59+WbPa7poz7Tlr llYueHTHcc2wK8yY/nXFGOQ9jdjzqc0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710150679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LCvmT8jjHNAmEJnDHw2lWAJr/UFBiE9L7VcCxaDZJ8o=; b=Dc/2GcCWeDecqHKJyPA0AGbdVilCtlmXUfneF+hycVHWxAD8Y9nxz86Ri8A/2smqug/lK2 F6j1VPQPahIdbiAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710150679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LCvmT8jjHNAmEJnDHw2lWAJr/UFBiE9L7VcCxaDZJ8o=; b=Gca/CxyEeinGE6P0dgsNfvV+i6rq/dnPo4PAz2m6fXDg7wd3zvgRSEcWNfMF+450W87pTl W9dIvCvqjEgr4aIa6NSrnlOSI/Lm+U8jCDYpqPnleu1ermwkE3RaHK+59+WbPa7poz7Tlr llYueHTHcc2wK8yY/nXFGOQ9jdjzqc0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710150679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LCvmT8jjHNAmEJnDHw2lWAJr/UFBiE9L7VcCxaDZJ8o=; b=Dc/2GcCWeDecqHKJyPA0AGbdVilCtlmXUfneF+hycVHWxAD8Y9nxz86Ri8A/2smqug/lK2 F6j1VPQPahIdbiAQ== Date: Mon, 11 Mar 2024 10:51:18 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] bitint: Avoid rewriting large/huge _BitInt vars into SSA after bitint lowering [PR114278] In-Reply-To: Message-ID: <18r27n18-7so9-n55s-80q0-s24p7oso7n3o@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-3.10 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Score: -3.10 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 9 Mar 2024, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs, because update-address-taken subpass of > fre5 rewrites > _BitInt(128) b; > vector(16) unsigned char _3; > > [local count: 1073741824]: > _3 = MEM [(char * {ref-all})p_2(D)]; > MEM [(char * {ref-all})&b] = _3; > b ={v} {CLOBBER(eos)}; > to > _BitInt(128) b; > vector(16) unsigned char _3; > > [local count: 1073741824]: > _3 = MEM [(char * {ref-all})p_2(D)]; > b_5 = VIEW_CONVERT_EXPR<_BitInt(128)>(_3); > but we can't have large/huge _BitInt vars in SSA form after the bitint > lowering except for function arguments loaded from memory, as expansion > isn't able to deal with those, it relies on bitint lowering to lower > those operations. > The following patch fixes that by not clearing TREE_ADDRESSABLE for > large/huge _BitInt vars after bitint lowering, such that we don't > rewrite them into SSA form. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK. Thanks, Richard. > 2024-03-09 Jakub Jelinek > > PR tree-optimization/114278 > * tree-ssa.cc (maybe_optimize_var): Punt on large/huge _BitInt > vars after bitint lowering. > > * gcc.dg/bitint-99.c: New test. > > --- gcc/tree-ssa.cc.jj 2024-01-03 11:51:39.902615009 +0100 > +++ gcc/tree-ssa.cc 2024-03-08 14:24:11.844821915 +0100 > @@ -1753,7 +1753,11 @@ maybe_optimize_var (tree var, bitmap add > /* Global Variables, result decls cannot be changed. */ > if (is_global_var (var) > || TREE_CODE (var) == RESULT_DECL > - || bitmap_bit_p (addresses_taken, DECL_UID (var))) > + || bitmap_bit_p (addresses_taken, DECL_UID (var)) > + || (TREE_CODE (TREE_TYPE (var)) == BITINT_TYPE > + /* Don't change large/huge _BitInt vars after _BitInt lowering. */ > + && (cfun->curr_properties & PROP_gimple_lbitint) != 0 > + && TYPE_PRECISION (TREE_TYPE (var)) > MAX_FIXED_MODE_SIZE)) > return; > > bool maybe_reg = false; > --- gcc/testsuite/gcc.dg/bitint-99.c.jj 2024-03-08 14:26:17.658069942 +0100 > +++ gcc/testsuite/gcc.dg/bitint-99.c 2024-03-08 14:25:36.292645965 +0100 > @@ -0,0 +1,26 @@ > +/* PR tree-optimization/114278 */ > +/* { dg-do compile { target bitint } } */ > +/* { dg-options "-O2 -fno-tree-dce -fno-tree-dse -fno-tree-ccp" } */ > +/* { dg-additional-options "-mavx2" { target i?86-*-* x86_64-*-* } } */ > + > +void > +foo (void *p) > +{ > + _BitInt(64) b = *(_BitInt(64) *) __builtin_memmove (&b, p, sizeof (_BitInt(64))); > +} > + > +#if __BITINT_MAXWIDTH__ >= 128 > +void > +bar (void *p) > +{ > + _BitInt(128) b = *(_BitInt(128) *) __builtin_memmove (&b, p, sizeof (_BitInt(128))); > +} > +#endif > + > +#if __BITINT_MAXWIDTH__ >= 256 > +void > +baz (void *p) > +{ > + _BitInt(256) b = *(_BitInt(256) *) __builtin_memmove (&b, p, sizeof (_BitInt(256))); > +} > +#endif > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)