* [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
@ 2016-01-05 7:37 Thomas Preud'homme
2016-01-05 10:47 ` Kyrill Tkachov
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Preud'homme @ 2016-01-05 7:37 UTC (permalink / raw)
To: gcc-patches, Richard Earnshaw, Ramana Radhakrishnan, Kyrylo Tkachov
Hi,
g++.dg/pr67989.C passes -march=armv4t to gcc when compiling which fails if
RUNTESTFLAGS passes -mcpu or -march with a different value. This patch adds a
dg-skip-if directive to skip the test when such a thing happens.
ChangeLog entry is as follows:
*** gcc/testsuite/ChangeLog ***
2015-12-31 Thomas Preud'homme <thomas.preudhomme@arm.com>
* g++.dg/pr67989.C: Skip test if already running it with -mcpu or
-march with different value.
diff --git a/gcc/testsuite/g++.dg/pr67989.C b/gcc/testsuite/g++.dg/pr67989.C
index
90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf825e7dc7
100644
--- a/gcc/testsuite/g++.dg/pr67989.C
+++ b/gcc/testsuite/g++.dg/pr67989.C
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-std=c++11 -O2" } */
+/* { dg-skip-if "do not override -mcpu" { arm*-*-* } { "-march=*" "-mcpu=*" }
{ "-march=armv4t" } } */
/* { dg-additional-options "-marm -march=armv4t" { target arm*-*-* } } */
__extension__ typedef unsigned long long int uint64_t;
Is this ok for stage3?
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-05 7:37 [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu Thomas Preud'homme
@ 2016-01-05 10:47 ` Kyrill Tkachov
2016-01-05 10:52 ` Richard Earnshaw (lists)
2016-01-07 7:35 ` Thomas Preud'homme
0 siblings, 2 replies; 14+ messages in thread
From: Kyrill Tkachov @ 2016-01-05 10:47 UTC (permalink / raw)
To: Thomas Preud'homme, gcc-patches, Richard Earnshaw,
Ramana Radhakrishnan
Hi Thomas,
On 05/01/16 07:37, Thomas Preud'homme wrote:
> Hi,
>
> g++.dg/pr67989.C passes -march=armv4t to gcc when compiling which fails if
> RUNTESTFLAGS passes -mcpu or -march with a different value. This patch adds a
> dg-skip-if directive to skip the test when such a thing happens.
>
> ChangeLog entry is as follows:
>
>
> *** gcc/testsuite/ChangeLog ***
>
> 2015-12-31 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * g++.dg/pr67989.C: Skip test if already running it with -mcpu or
> -march with different value.
>
>
> diff --git a/gcc/testsuite/g++.dg/pr67989.C b/gcc/testsuite/g++.dg/pr67989.C
> index
> 90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf825e7dc7
> 100644
> --- a/gcc/testsuite/g++.dg/pr67989.C
> +++ b/gcc/testsuite/g++.dg/pr67989.C
> @@ -1,5 +1,6 @@
> /* { dg-do compile } */
> /* { dg-options "-std=c++11 -O2" } */
> +/* { dg-skip-if "do not override -mcpu" { arm*-*-* } { "-march=*" "-mcpu=*" }
> { "-march=armv4t" } } */
> /* { dg-additional-options "-marm -march=armv4t" { target arm*-*-* } } */
>
How about we try to do it using the add_options_for_arm_arch_v4t machinery
and the arm_arch_v4t_ok check?
I think the -marm part can go and can be added implicitly as part of multilib testing
Thanks,
Kyrill
> __extension__ typedef unsigned long long int uint64_t;
>
>
> Is this ok for stage3?
>
> Best regards,
>
> Thomas
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-05 10:47 ` Kyrill Tkachov
@ 2016-01-05 10:52 ` Richard Earnshaw (lists)
2016-01-05 10:56 ` Kyrill Tkachov
2016-01-07 7:35 ` Thomas Preud'homme
1 sibling, 1 reply; 14+ messages in thread
From: Richard Earnshaw (lists) @ 2016-01-05 10:52 UTC (permalink / raw)
To: Kyrill Tkachov, Thomas Preud'homme, gcc-patches,
Ramana Radhakrishnan
On 05/01/16 10:47, Kyrill Tkachov wrote:
> Hi Thomas,
>
> On 05/01/16 07:37, Thomas Preud'homme wrote:
>> Hi,
>>
>> g++.dg/pr67989.C passes -march=armv4t to gcc when compiling which
>> fails if
>> RUNTESTFLAGS passes -mcpu or -march with a different value. This patch
>> adds a
>> dg-skip-if directive to skip the test when such a thing happens.
>>
>> ChangeLog entry is as follows:
>>
>>
>> *** gcc/testsuite/ChangeLog ***
>>
>> 2015-12-31 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>
>> * g++.dg/pr67989.C: Skip test if already running it with
>> -mcpu or
>> -march with different value.
>>
>>
>> diff --git a/gcc/testsuite/g++.dg/pr67989.C
>> b/gcc/testsuite/g++.dg/pr67989.C
>> index
>> 90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf825e7dc7
>>
>> 100644
>> --- a/gcc/testsuite/g++.dg/pr67989.C
>> +++ b/gcc/testsuite/g++.dg/pr67989.C
>> @@ -1,5 +1,6 @@
>> /* { dg-do compile } */
>> /* { dg-options "-std=c++11 -O2" } */
>> +/* { dg-skip-if "do not override -mcpu" { arm*-*-* } { "-march=*"
>> "-mcpu=*" }
>> { "-march=armv4t" } } */
>> /* { dg-additional-options "-marm -march=armv4t" { target arm*-*-* }
>> } */
>>
>
> How about we try to do it using the add_options_for_arm_arch_v4t machinery
> and the arm_arch_v4t_ok check?
>
> I think the -marm part can go and can be added implicitly as part of
> multilib testing
>
Or we could drop all the target-specific options as this is supposed to
be a generic test. Yes, I realise this was the particular flag
combination required to trigger the original ICE, but no other target
running this test has target-specific options, so it seams a little
strange that ARM does.
R.
> Thanks,
> Kyrill
>
>
>> __extension__ typedef unsigned long long int uint64_t;
>>
>>
>> Is this ok for stage3?
>>
>> Best regards,
>>
>> Thomas
>>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-05 10:52 ` Richard Earnshaw (lists)
@ 2016-01-05 10:56 ` Kyrill Tkachov
0 siblings, 0 replies; 14+ messages in thread
From: Kyrill Tkachov @ 2016-01-05 10:56 UTC (permalink / raw)
To: Richard Earnshaw (lists),
Thomas Preud'homme, gcc-patches, Ramana Radhakrishnan
On 05/01/16 10:52, Richard Earnshaw (lists) wrote:
> On 05/01/16 10:47, Kyrill Tkachov wrote:
>> Hi Thomas,
>>
>> On 05/01/16 07:37, Thomas Preud'homme wrote:
>>> Hi,
>>>
>>> g++.dg/pr67989.C passes -march=armv4t to gcc when compiling which
>>> fails if
>>> RUNTESTFLAGS passes -mcpu or -march with a different value. This patch
>>> adds a
>>> dg-skip-if directive to skip the test when such a thing happens.
>>>
>>> ChangeLog entry is as follows:
>>>
>>>
>>> *** gcc/testsuite/ChangeLog ***
>>>
>>> 2015-12-31 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>
>>> * g++.dg/pr67989.C: Skip test if already running it with
>>> -mcpu or
>>> -march with different value.
>>>
>>>
>>> diff --git a/gcc/testsuite/g++.dg/pr67989.C
>>> b/gcc/testsuite/g++.dg/pr67989.C
>>> index
>>> 90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf825e7dc7
>>>
>>> 100644
>>> --- a/gcc/testsuite/g++.dg/pr67989.C
>>> +++ b/gcc/testsuite/g++.dg/pr67989.C
>>> @@ -1,5 +1,6 @@
>>> /* { dg-do compile } */
>>> /* { dg-options "-std=c++11 -O2" } */
>>> +/* { dg-skip-if "do not override -mcpu" { arm*-*-* } { "-march=*"
>>> "-mcpu=*" }
>>> { "-march=armv4t" } } */
>>> /* { dg-additional-options "-marm -march=armv4t" { target arm*-*-* }
>>> } */
>>>
>> How about we try to do it using the add_options_for_arm_arch_v4t machinery
>> and the arm_arch_v4t_ok check?
>>
>> I think the -marm part can go and can be added implicitly as part of
>> multilib testing
>>
> Or we could drop all the target-specific options as this is supposed to
> be a generic test. Yes, I realise this was the particular flag
> combination required to trigger the original ICE, but no other target
> running this test has target-specific options, so it seams a little
> strange that ARM does.
IIRC the problem in this PR was a fallback path in one of the
atomic operation expand routines, so it needs an architecture version
that is sufficiently low to not use the target-specific expanders.
That's why the armv4t was there.
Kyrill
> R.
>
>
>> Thanks,
>> Kyrill
>>
>>
>>> __extension__ typedef unsigned long long int uint64_t;
>>>
>>>
>>> Is this ok for stage3?
>>>
>>> Best regards,
>>>
>>> Thomas
>>>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-05 10:47 ` Kyrill Tkachov
2016-01-05 10:52 ` Richard Earnshaw (lists)
@ 2016-01-07 7:35 ` Thomas Preud'homme
2016-01-07 9:15 ` Kyrill Tkachov
1 sibling, 1 reply; 14+ messages in thread
From: Thomas Preud'homme @ 2016-01-07 7:35 UTC (permalink / raw)
To: Kyrill Tkachov; +Cc: gcc-patches, Richard Earnshaw, Ramana Radhakrishnan
On Tuesday, January 05, 2016 10:47:38 AM Kyrill Tkachov wrote:
> Hi Thomas,
Hi Kyrill,
> >
> > diff --git a/gcc/testsuite/g++.dg/pr67989.C
> > b/gcc/testsuite/g++.dg/pr67989.C index
> > 90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf
> > 825e7dc7 100644
> > --- a/gcc/testsuite/g++.dg/pr67989.C
> > +++ b/gcc/testsuite/g++.dg/pr67989.C
> > @@ -1,5 +1,6 @@
> >
> > /* { dg-do compile } */
> > /* { dg-options "-std=c++11 -O2" } */
> >
> > +/* { dg-skip-if "do not override -mcpu" { arm*-*-* } { "-march=*"
> > "-mcpu=*" } { "-march=armv4t" } } */
> >
> > /* { dg-additional-options "-marm -march=armv4t" { target arm*-*-* } }
> > */
>
> How about we try to do it using the add_options_for_arm_arch_v4t machinery
> and the arm_arch_v4t_ok check?
I don't quite understand. dg-add-options doesn't take a selector according to
GCC internals documentation and dg-additional-options doesn't take feature. If
I use dg-add-options with a require-effective-target that will limit this test
to ARM.
Did I misunderstand your point?
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-07 7:35 ` Thomas Preud'homme
@ 2016-01-07 9:15 ` Kyrill Tkachov
2016-01-07 10:26 ` Richard Earnshaw (lists)
0 siblings, 1 reply; 14+ messages in thread
From: Kyrill Tkachov @ 2016-01-07 9:15 UTC (permalink / raw)
To: Thomas Preud'homme
Cc: gcc-patches, Richard Earnshaw, Ramana Radhakrishnan
On 07/01/16 07:34, Thomas Preud'homme wrote:
> On Tuesday, January 05, 2016 10:47:38 AM Kyrill Tkachov wrote:
>> Hi Thomas,
> Hi Kyrill,
>
>>> diff --git a/gcc/testsuite/g++.dg/pr67989.C
>>> b/gcc/testsuite/g++.dg/pr67989.C index
>>> 90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf
>>> 825e7dc7 100644
>>> --- a/gcc/testsuite/g++.dg/pr67989.C
>>> +++ b/gcc/testsuite/g++.dg/pr67989.C
>>> @@ -1,5 +1,6 @@
>>>
>>> /* { dg-do compile } */
>>> /* { dg-options "-std=c++11 -O2" } */
>>>
>>> +/* { dg-skip-if "do not override -mcpu" { arm*-*-* } { "-march=*"
>>> "-mcpu=*" } { "-march=armv4t" } } */
>>>
>>> /* { dg-additional-options "-marm -march=armv4t" { target arm*-*-* } }
>>> */
>> How about we try to do it using the add_options_for_arm_arch_v4t machinery
>> and the arm_arch_v4t_ok check?
> I don't quite understand. dg-add-options doesn't take a selector according to
> GCC internals documentation and dg-additional-options doesn't take feature. If
> I use dg-add-options with a require-effective-target that will limit this test
> to ARM.
>
> Did I misunderstand your point?
Humph, you're right. I thought that dg-add-options could take a target selector.
In this case perhaps we should go the route of just removing the target-specific option
altogether.
Richard, that's the approach you recommended, right?
Thanks,
Kyrill
> Best regards,
>
> Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-07 9:15 ` Kyrill Tkachov
@ 2016-01-07 10:26 ` Richard Earnshaw (lists)
2016-01-08 9:33 ` Thomas Preud'homme
0 siblings, 1 reply; 14+ messages in thread
From: Richard Earnshaw (lists) @ 2016-01-07 10:26 UTC (permalink / raw)
To: Kyrill Tkachov, Thomas Preud'homme; +Cc: gcc-patches, Ramana Radhakrishnan
On 07/01/16 09:15, Kyrill Tkachov wrote:
>
> On 07/01/16 07:34, Thomas Preud'homme wrote:
>> On Tuesday, January 05, 2016 10:47:38 AM Kyrill Tkachov wrote:
>>> Hi Thomas,
>> Hi Kyrill,
>>
>>>> diff --git a/gcc/testsuite/g++.dg/pr67989.C
>>>> b/gcc/testsuite/g++.dg/pr67989.C index
>>>> 90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf
>>>>
>>>> 825e7dc7 100644
>>>> --- a/gcc/testsuite/g++.dg/pr67989.C
>>>> +++ b/gcc/testsuite/g++.dg/pr67989.C
>>>> @@ -1,5 +1,6 @@
>>>>
>>>> /* { dg-do compile } */
>>>> /* { dg-options "-std=c++11 -O2" } */
>>>>
>>>> +/* { dg-skip-if "do not override -mcpu" { arm*-*-* } { "-march=*"
>>>> "-mcpu=*" } { "-march=armv4t" } } */
>>>>
>>>> /* { dg-additional-options "-marm -march=armv4t" { target
>>>> arm*-*-* } }
>>>> */
>>> How about we try to do it using the add_options_for_arm_arch_v4t
>>> machinery
>>> and the arm_arch_v4t_ok check?
>> I don't quite understand. dg-add-options doesn't take a selector
>> according to
>> GCC internals documentation and dg-additional-options doesn't take
>> feature. If
>> I use dg-add-options with a require-effective-target that will limit
>> this test
>> to ARM.
>>
>> Did I misunderstand your point?
>
> Humph, you're right. I thought that dg-add-options could take a target
> selector.
> In this case perhaps we should go the route of just removing the
> target-specific option
> altogether.
>
> Richard, that's the approach you recommended, right?
>
Yes.
I think if you really need to test a specific set of target flags, then
it might be acceptable to have a duplicate of the test in dg.target/arm
(but please put a comment in the (arm version of the) test to explain
why it has been duplicated.
R.
> Thanks,
> Kyrill
>
>> Best regards,
>>
>> Thomas
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-07 10:26 ` Richard Earnshaw (lists)
@ 2016-01-08 9:33 ` Thomas Preud'homme
2016-01-11 15:57 ` Bernd Schmidt
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Preud'homme @ 2016-01-08 9:33 UTC (permalink / raw)
To: Richard Earnshaw (lists)
Cc: Kyrill Tkachov, gcc-patches, Ramana Radhakrishnan
On Thursday, January 07, 2016 10:26:28 AM Richard Earnshaw wrote:
> On 07/01/16 09:15, Kyrill Tkachov wrote:
> > In this case perhaps we should go the route of just removing the
> > target-specific option
> > altogether.
> >
> > Richard, that's the approach you recommended, right?
>
> Yes.
>
> I think if you really need to test a specific set of target flags, then
> it might be acceptable to have a duplicate of the test in dg.target/arm
> (but please put a comment in the (arm version of the) test to explain
> why it has been duplicated.
What about the following:
*** gcc/testsuite/ChangeLog ***
2016-01-08 Thomas Preud'homme <thomas.preudhomme@arm.com>
* g++.dg/pr67989.C: Remove ARM-specific option.
* gcc.target/arm/pr67989.C: New file.
diff --git a/gcc/testsuite/g++.dg/pr67989.C b/gcc/testsuite/g++.dg/pr67989.C
index
90261c450b4b9429fb989f7df62f3743017c7363..c3023557d31a21aead717fd58483c82e3e74da95
100644
--- a/gcc/testsuite/g++.dg/pr67989.C
+++ b/gcc/testsuite/g++.dg/pr67989.C
@@ -1,6 +1,5 @@
/* { dg-do compile } */
/* { dg-options "-std=c++11 -O2" } */
-/* { dg-additional-options "-marm -march=armv4t" { target arm*-*-* } } */
__extension__ typedef unsigned long long int uint64_t;
namespace std __attribute__ ((__visibility__ ("default")))
diff --git a/gcc/testsuite/gcc.target/arm/pr67989.C b/gcc/testsuite/
gcc.target/arm/pr67989.C
new file mode 100644
index
0000000000000000000000000000000000000000..0006924e24f698711e1e501d09b5098049522ad6
--- /dev/null
+++ b/gcc/testsuite/gcc.target/arm/pr67989.C
@@ -0,0 +1,82 @@
+/* { dg-do compile } */
+/* { dg-options "-std=c++11 -O2" } */
+/* { dg-require-effective-target arm_arch_v4t_ok } */
+/* { dg-add-options arm_arch_v4t } */
+/* { dg-additional-options "-marm" } */
+
+/* Duplicate version of the test in g++.dg to be able to run this test only
if
+ ARMv4t in ARM execution state can be targetted. Newer architecture don't
+ expose the bug this testcase was written for. */
+
+
+__extension__ typedef unsigned long long int uint64_t;
+namespace std __attribute__ ((__visibility__ ("default")))
+{
+ typedef enum memory_order
+ {
+ memory_order_seq_cst
+ } memory_order;
+}
+
+namespace std __attribute__ ((__visibility__ ("default")))
+{
+ template < typename _Tp > struct atomic
+ {
+ static constexpr int _S_min_alignment
+ = (sizeof (_Tp) & (sizeof (_Tp) - 1)) || sizeof (_Tp) > 16
+ ? 0 : sizeof (_Tp);
+ static constexpr int _S_alignment
+ = _S_min_alignment > alignof (_Tp) ? _S_min_alignment : alignof (_Tp);
+ alignas (_S_alignment) _Tp _M_i;
+ operator _Tp () const noexcept
+ {
+ return load ();
+ }
+ _Tp load (memory_order __m = memory_order_seq_cst) const noexcept
+ {
+ _Tp tmp;
+ __atomic_load (&_M_i, &tmp, __m);
+ }
+ };
+}
+
+namespace lldb_private
+{
+ namespace imp
+ {
+ }
+ class Address;
+}
+namespace lldb
+{
+ typedef uint64_t addr_t;
+ class SBSection
+ {
+ };
+ class SBAddress
+ {
+ void SetAddress (lldb::SBSection section, lldb::addr_t offset);
+ lldb_private::Address & ref ();
+ };
+}
+namespace lldb_private
+{
+ class Address
+ {
+ public:
+ const Address & SetOffset (lldb::addr_t offset)
+ {
+ bool changed = m_offset != offset;
+ }
+ std::atomic < lldb::addr_t > m_offset;
+ };
+}
+
+using namespace lldb;
+using namespace lldb_private;
+void
+SBAddress::SetAddress (lldb::SBSection section, lldb::addr_t offset)
+{
+ Address & addr = ref ();
+ addr.SetOffset (offset);
+}
Is this ok for stage3?
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-08 9:33 ` Thomas Preud'homme
@ 2016-01-11 15:57 ` Bernd Schmidt
2016-01-12 7:55 ` Thomas Preud'homme
0 siblings, 1 reply; 14+ messages in thread
From: Bernd Schmidt @ 2016-01-11 15:57 UTC (permalink / raw)
To: Thomas Preud'homme, Richard Earnshaw (lists)
Cc: Kyrill Tkachov, gcc-patches, Ramana Radhakrishnan
On 01/08/2016 10:33 AM, Thomas Preud'homme wrote:
> 2016-01-08 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * g++.dg/pr67989.C: Remove ARM-specific option.
> * gcc.target/arm/pr67989.C: New file.
I checked some other arm tests and they have things like
/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
"-march=*" } { "-march=armv4t" } } */
/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
"-mthumb" } { "" } } */
Do you need the same in your testcase?
Bernd
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-11 15:57 ` Bernd Schmidt
@ 2016-01-12 7:55 ` Thomas Preud'homme
2016-01-13 17:39 ` Bernd Schmidt
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Preud'homme @ 2016-01-12 7:55 UTC (permalink / raw)
To: Bernd Schmidt
Cc: Richard Earnshaw (lists),
Kyrill Tkachov, gcc-patches, Ramana Radhakrishnan
On Monday, January 11, 2016 04:57:18 PM Bernd Schmidt wrote:
> On 01/08/2016 10:33 AM, Thomas Preud'homme wrote:
> > 2016-01-08 Thomas Preud'homme <thomas.preudhomme@arm.com>
> >
> > * g++.dg/pr67989.C: Remove ARM-specific option.
> > * gcc.target/arm/pr67989.C: New file.
>
> I checked some other arm tests and they have things like
>
> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> "-march=*" } { "-march=armv4t" } } */
> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> "-mthumb" } { "" } } */
>
> Do you need the same in your testcase?
That was the first approach I took but Kyrill suggested me to use arm_arch_v4t
and arm_arch_v4t_ok machinery instead. It should take care about whether the
architecture can be selected.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-12 7:55 ` Thomas Preud'homme
@ 2016-01-13 17:39 ` Bernd Schmidt
2016-01-18 3:33 ` Thomas Preud'homme
0 siblings, 1 reply; 14+ messages in thread
From: Bernd Schmidt @ 2016-01-13 17:39 UTC (permalink / raw)
To: Thomas Preud'homme
Cc: Richard Earnshaw (lists),
Kyrill Tkachov, gcc-patches, Ramana Radhakrishnan
On 01/12/2016 08:55 AM, Thomas Preud'homme wrote:
> On Monday, January 11, 2016 04:57:18 PM Bernd Schmidt wrote:
>> On 01/08/2016 10:33 AM, Thomas Preud'homme wrote:
>>> 2016-01-08 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>
>>> * g++.dg/pr67989.C: Remove ARM-specific option.
>>> * gcc.target/arm/pr67989.C: New file.
>>
>> I checked some other arm tests and they have things like
>>
>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
>> "-march=*" } { "-march=armv4t" } } */
>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
>> "-mthumb" } { "" } } */
>>
>> Do you need the same in your testcase?
>
> That was the first approach I took but Kyrill suggested me to use arm_arch_v4t
> and arm_arch_v4t_ok machinery instead. It should take care about whether the
> architecture can be selected.
Hmm, the ones I looked at did use dg-add-options, but not the
corresponding _ok requirement. So I think this is OK.
Bernd
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-13 17:39 ` Bernd Schmidt
@ 2016-01-18 3:33 ` Thomas Preud'homme
2016-01-27 6:35 ` Thomas Preud'homme
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Preud'homme @ 2016-01-18 3:33 UTC (permalink / raw)
To: gcc-patches
Cc: Bernd Schmidt, Richard Earnshaw (lists),
Kyrill Tkachov, Ramana Radhakrishnan
On Wednesday, January 13, 2016 06:39:20 PM Bernd Schmidt wrote:
> On 01/12/2016 08:55 AM, Thomas Preud'homme wrote:
> > On Monday, January 11, 2016 04:57:18 PM Bernd Schmidt wrote:
> >> On 01/08/2016 10:33 AM, Thomas Preud'homme wrote:
> >>> 2016-01-08 Thomas Preud'homme <thomas.preudhomme@arm.com>
> >>>
> >>> * g++.dg/pr67989.C: Remove ARM-specific option.
> >>> * gcc.target/arm/pr67989.C: New file.
> >>
> >> I checked some other arm tests and they have things like
> >>
> >> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >> "-march=*" } { "-march=armv4t" } } */
> >> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >> "-mthumb" } { "" } } */
> >>
> >> Do you need the same in your testcase?
> >
> > That was the first approach I took but Kyrill suggested me to use
> > arm_arch_v4t and arm_arch_v4t_ok machinery instead. It should take care
> > about whether the architecture can be selected.
>
> Hmm, the ones I looked at did use dg-add-options, but not the
> corresponding _ok requirement. So I think this is OK.
Just to make sure: ok as in OK to commit as is?
Best regards,
Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-18 3:33 ` Thomas Preud'homme
@ 2016-01-27 6:35 ` Thomas Preud'homme
2016-01-27 20:04 ` Mike Stump
0 siblings, 1 reply; 14+ messages in thread
From: Thomas Preud'homme @ 2016-01-27 6:35 UTC (permalink / raw)
To: gcc-patches, Bernd Schmidt
Cc: Richard Earnshaw (lists), Kyrill Tkachov, Ramana Radhakrishnan
Ping?
On Monday, January 18, 2016 11:33:47 AM Thomas Preud'homme wrote:
> On Wednesday, January 13, 2016 06:39:20 PM Bernd Schmidt wrote:
> > On 01/12/2016 08:55 AM, Thomas Preud'homme wrote:
> > > On Monday, January 11, 2016 04:57:18 PM Bernd Schmidt wrote:
> > >> On 01/08/2016 10:33 AM, Thomas Preud'homme wrote:
> > >>> 2016-01-08 Thomas Preud'homme <thomas.preudhomme@arm.com>
> > >>>
> > >>> * g++.dg/pr67989.C: Remove ARM-specific option.
> > >>> * gcc.target/arm/pr67989.C: New file.
> > >>
> > >> I checked some other arm tests and they have things like
> > >>
> > >> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> > >> "-march=*" } { "-march=armv4t" } } */
> > >> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> > >> "-mthumb" } { "" } } */
> > >>
> > >> Do you need the same in your testcase?
> > >
> > > That was the first approach I took but Kyrill suggested me to use
> > > arm_arch_v4t and arm_arch_v4t_ok machinery instead. It should take care
> > > about whether the architecture can be selected.
> >
> > Hmm, the ones I looked at did use dg-add-options, but not the
> > corresponding _ok requirement. So I think this is OK.
>
> Just to make sure: ok as in OK to commit as is?
>
> Best regards,
>
> Thomas
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
2016-01-27 6:35 ` Thomas Preud'homme
@ 2016-01-27 20:04 ` Mike Stump
0 siblings, 0 replies; 14+ messages in thread
From: Mike Stump @ 2016-01-27 20:04 UTC (permalink / raw)
To: Thomas Preud'homme
Cc: GCC Patches, Bernd Schmidt, Richard Earnshaw (lists),
Kyrill Tkachov, Ramana Radhakrishnan
On Jan 26, 2016, at 10:35 PM, Thomas Preud'homme <thomas.preudhomme@foss.arm.com> wrote:
> On Monday, January 18, 2016 11:33:47 AM Thomas Preud'homme wrote:
>> On Wednesday, January 13, 2016 06:39:20 PM Bernd Schmidt wrote:
>>> On 01/12/2016 08:55 AM, Thomas Preud'homme wrote:
>>>> On Monday, January 11, 2016 04:57:18 PM Bernd Schmidt wrote:
>>>>> On 01/08/2016 10:33 AM, Thomas Preud'homme wrote:
>>>>>> 2016-01-08 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>>>>
>>>>>> * g++.dg/pr67989.C: Remove ARM-specific option.
>>>>>> * gcc.target/arm/pr67989.C: New file.
>>>>>
>>>>> I checked some other arm tests and they have things like
>>>>>
>>>>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
>>>>> "-march=*" } { "-march=armv4t" } } */
>>>>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
>>>>> "-mthumb" } { "" } } */
>>>>>
>>>>> Do you need the same in your testcase?
>>>>
>>>> That was the first approach I took but Kyrill suggested me to use
>>>> arm_arch_v4t and arm_arch_v4t_ok machinery instead. It should take care
>>>> about whether the architecture can be selected.
>>>
>>> Hmm, the ones I looked at did use dg-add-options, but not the
>>> corresponding _ok requirement. So I think this is OK.
>>
>> Just to make sure: ok as in OK to commit as is?
Ok.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-01-27 20:04 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-05 7:37 [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu Thomas Preud'homme
2016-01-05 10:47 ` Kyrill Tkachov
2016-01-05 10:52 ` Richard Earnshaw (lists)
2016-01-05 10:56 ` Kyrill Tkachov
2016-01-07 7:35 ` Thomas Preud'homme
2016-01-07 9:15 ` Kyrill Tkachov
2016-01-07 10:26 ` Richard Earnshaw (lists)
2016-01-08 9:33 ` Thomas Preud'homme
2016-01-11 15:57 ` Bernd Schmidt
2016-01-12 7:55 ` Thomas Preud'homme
2016-01-13 17:39 ` Bernd Schmidt
2016-01-18 3:33 ` Thomas Preud'homme
2016-01-27 6:35 ` Thomas Preud'homme
2016-01-27 20:04 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).