public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH 4.4] PR33642: also XFAIL -frtl-abstract-sequences tests on arm*-*-*
@ 2009-10-19 19:38 Mikael Pettersson
  2009-10-20 10:11 ` Richard Earnshaw
  0 siblings, 1 reply; 4+ messages in thread
From: Mikael Pettersson @ 2009-10-19 19:38 UTC (permalink / raw)
  To: gcc-patches

The pr11832.c and pr33009.c -frtl-abstract-sequences tests
in 4.4 ICE on ARM, like they do on many other platforms,
causing new testsuite failures compared to 4.3.  This patch
adds arm*-*-* to these tests' XFAIL lists.

Regtested on {i686,powerpc64}-linux and armv5tel-linux-gnueabi.

Ok for 4.4?
(I don't have write access.)

gcc/testsuite/

2009-10-19  Mikael Pettersson  <mikpe@it.uu.se>

	PR rtl-optimization/33642
	* gcc.c-torture/compile/pr11832.c: XFAIL on arm*-*-*.
	* gcc.c-torture/compile/pr33009.c: Likewise.

diff -rupN gcc-4.4.2/gcc/testsuite/gcc.c-torture/compile/pr11832.c gcc-4.4.2-pr33642-arm/gcc/testsuite/gcc.c-torture/compile/pr11832.c
--- gcc-4.4.2/gcc/testsuite/gcc.c-torture/compile/pr11832.c	2008-12-01 16:19:40.000000000 +0100
+++ gcc-4.4.2-pr33642-arm/gcc/testsuite/gcc.c-torture/compile/pr11832.c	2009-10-17 22:42:32.000000000 +0200
@@ -1,6 +1,6 @@
 /* { dg-do compile } */
-/* Currently ICEs for Alpha, IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
-/* { dg-xfail-if "PR33642" { alpha*-*-* hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
+/* Currently ICEs for Alpha, ARM, IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
+/* { dg-xfail-if "PR33642" { alpha*-*-* arm*-*-* hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
 /* Currently ICEs for (x86 && ilp32 && pic).  */
 /* { dg-xfail-if "PR33642/36240" { { i?86-*-* x86_64-*-* } && { ilp32 && { ! nonpic } } } { "*" } { "" } } */
 /* { dg-prune-output ".*internal compiler error.*" }
diff -rupN gcc-4.4.2/gcc/testsuite/gcc.c-torture/compile/pr33009.c gcc-4.4.2-pr33642-arm/gcc/testsuite/gcc.c-torture/compile/pr33009.c
--- gcc-4.4.2/gcc/testsuite/gcc.c-torture/compile/pr33009.c	2008-12-01 16:19:40.000000000 +0100
+++ gcc-4.4.2-pr33642-arm/gcc/testsuite/gcc.c-torture/compile/pr33009.c	2009-10-17 22:42:32.000000000 +0200
@@ -1,6 +1,6 @@
 /* { dg-do compile } */
-/* Currently ICEs for Alpha, IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
-/* { dg-xfail-if "PR33642" { alpha*-*-* hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
+/* Currently ICEs for Alpha, ARM, IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
+/* { dg-xfail-if "PR33642" { alpha*-*-* arm*-*-* hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
 /* Currently ICEs for (x86 && ilp32 && pic).  */
 /* { dg-xfail-if "PR33642/36240" { { i?86-*-* x86_64-*-* } && { ilp32 && { ! nonpic } } } { "*" } { "" } } */
 /* { dg-prune-output ".*internal compiler error.*" }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4.4] PR33642: also XFAIL -frtl-abstract-sequences tests  on arm*-*-*
  2009-10-19 19:38 [PATCH 4.4] PR33642: also XFAIL -frtl-abstract-sequences tests on arm*-*-* Mikael Pettersson
@ 2009-10-20 10:11 ` Richard Earnshaw
  2009-10-20 10:18   ` Mikael Pettersson
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Earnshaw @ 2009-10-20 10:11 UTC (permalink / raw)
  To: Mikael Pettersson; +Cc: gcc-patches


On Mon, 2009-10-19 at 21:34 +0200, Mikael Pettersson wrote:
> The pr11832.c and pr33009.c -frtl-abstract-sequences tests
> in 4.4 ICE on ARM, like they do on many other platforms,
> causing new testsuite failures compared to 4.3.  This patch
> adds arm*-*-* to these tests' XFAIL lists.
> 
> Regtested on {i686,powerpc64}-linux and armv5tel-linux-gnueabi.
> 
> Ok for 4.4?
> (I don't have write access.)
> 

-frtl-abstract-sequences was removed on trunk.  So this is all dead code
now in reality.  It might be simpler just to remove the tests.

R.

> gcc/testsuite/
> 
> 2009-10-19  Mikael Pettersson  <mikpe@it.uu.se>
> 
> 	PR rtl-optimization/33642
> 	* gcc.c-torture/compile/pr11832.c: XFAIL on arm*-*-*.
> 	* gcc.c-torture/compile/pr33009.c: Likewise.
> 
> diff -rupN gcc-4.4.2/gcc/testsuite/gcc.c-torture/compile/pr11832.c gcc-4.4.2-pr33642-arm/gcc/testsuite/gcc.c-torture/compile/pr11832.c
> --- gcc-4.4.2/gcc/testsuite/gcc.c-torture/compile/pr11832.c	2008-12-01 16:19:40.000000000 +0100
> +++ gcc-4.4.2-pr33642-arm/gcc/testsuite/gcc.c-torture/compile/pr11832.c	2009-10-17 22:42:32.000000000 +0200
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
> -/* Currently ICEs for Alpha, IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
> -/* { dg-xfail-if "PR33642" { alpha*-*-* hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
> +/* Currently ICEs for Alpha, ARM, IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
> +/* { dg-xfail-if "PR33642" { alpha*-*-* arm*-*-* hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
>  /* Currently ICEs for (x86 && ilp32 && pic).  */
>  /* { dg-xfail-if "PR33642/36240" { { i?86-*-* x86_64-*-* } && { ilp32 && { ! nonpic } } } { "*" } { "" } } */
>  /* { dg-prune-output ".*internal compiler error.*" }
> diff -rupN gcc-4.4.2/gcc/testsuite/gcc.c-torture/compile/pr33009.c gcc-4.4.2-pr33642-arm/gcc/testsuite/gcc.c-torture/compile/pr33009.c
> --- gcc-4.4.2/gcc/testsuite/gcc.c-torture/compile/pr33009.c	2008-12-01 16:19:40.000000000 +0100
> +++ gcc-4.4.2-pr33642-arm/gcc/testsuite/gcc.c-torture/compile/pr33009.c	2009-10-17 22:42:32.000000000 +0200
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
> -/* Currently ICEs for Alpha, IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
> -/* { dg-xfail-if "PR33642" { alpha*-*-* hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
> +/* Currently ICEs for Alpha, ARM, IA64, HPPA, MIPS, CRIS, Xtensa, PowerPC, SH and SPARC; see PR33642.  */
> +/* { dg-xfail-if "PR33642" { alpha*-*-* arm*-*-* hppa*-*-* mips*-*-* powerpc*-*-* cris-*-* crisv32-*-* ia64-*-* xtensa*-*-* sh*-*-* sparc*-*-* s390*-*-* } { "*" } { "" } } */
>  /* Currently ICEs for (x86 && ilp32 && pic).  */
>  /* { dg-xfail-if "PR33642/36240" { { i?86-*-* x86_64-*-* } && { ilp32 && { ! nonpic } } } { "*" } { "" } } */
>  /* { dg-prune-output ".*internal compiler error.*" }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4.4] PR33642: also XFAIL -frtl-abstract-sequences tests  on arm*-*-*
  2009-10-20 10:11 ` Richard Earnshaw
@ 2009-10-20 10:18   ` Mikael Pettersson
  2009-10-20 11:52     ` Richard Guenther
  0 siblings, 1 reply; 4+ messages in thread
From: Mikael Pettersson @ 2009-10-20 10:18 UTC (permalink / raw)
  To: Richard Earnshaw; +Cc: Mikael Pettersson, gcc-patches

Richard Earnshaw writes:
 > 
 > On Mon, 2009-10-19 at 21:34 +0200, Mikael Pettersson wrote:
 > > The pr11832.c and pr33009.c -frtl-abstract-sequences tests
 > > in 4.4 ICE on ARM, like they do on many other platforms,
 > > causing new testsuite failures compared to 4.3.  This patch
 > > adds arm*-*-* to these tests' XFAIL lists.
 > > 
 > > Regtested on {i686,powerpc64}-linux and armv5tel-linux-gnueabi.
 > > 
 > > Ok for 4.4?
 > > (I don't have write access.)
 > > 
 > 
 > -frtl-abstract-sequences was removed on trunk.  So this is all dead code
 > now in reality.  It might be simpler just to remove the tests.

I was just following the status quo for 4.4, but removing de facto
pointless tests seems more rational.  I can submit a patch to do
that, if people agree it's the right thing to do.

/Mikael

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 4.4] PR33642: also XFAIL -frtl-abstract-sequences tests on   arm*-*-*
  2009-10-20 10:18   ` Mikael Pettersson
@ 2009-10-20 11:52     ` Richard Guenther
  0 siblings, 0 replies; 4+ messages in thread
From: Richard Guenther @ 2009-10-20 11:52 UTC (permalink / raw)
  To: Mikael Pettersson; +Cc: Richard Earnshaw, gcc-patches

On Tue, Oct 20, 2009 at 12:11 PM, Mikael Pettersson <mikpe@it.uu.se> wrote:
> Richard Earnshaw writes:
>  >
>  > On Mon, 2009-10-19 at 21:34 +0200, Mikael Pettersson wrote:
>  > > The pr11832.c and pr33009.c -frtl-abstract-sequences tests
>  > > in 4.4 ICE on ARM, like they do on many other platforms,
>  > > causing new testsuite failures compared to 4.3.  This patch
>  > > adds arm*-*-* to these tests' XFAIL lists.
>  > >
>  > > Regtested on {i686,powerpc64}-linux and armv5tel-linux-gnueabi.
>  > >
>  > > Ok for 4.4?
>  > > (I don't have write access.)
>  > >
>  >
>  > -frtl-abstract-sequences was removed on trunk.  So this is all dead code
>  > now in reality.  It might be simpler just to remove the tests.
>
> I was just following the status quo for 4.4, but removing de facto
> pointless tests seems more rational.  I can submit a patch to do
> that, if people agree it's the right thing to do.

A patch to do that is pre-approved.

Richard.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-10-20 11:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-19 19:38 [PATCH 4.4] PR33642: also XFAIL -frtl-abstract-sequences tests on arm*-*-* Mikael Pettersson
2009-10-20 10:11 ` Richard Earnshaw
2009-10-20 10:18   ` Mikael Pettersson
2009-10-20 11:52     ` Richard Guenther

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).