From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 9C48E3852205 for ; Mon, 21 Nov 2022 15:26:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C48E3852205 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id y203so11632667pfb.4 for ; Mon, 21 Nov 2022 07:26:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ks3a5uwjYZy9dG49mabRmV2dX32QSZuoaC02/Xl7ftE=; b=MAdrmYtgH9YInjG3U2upJrJcrLbCW6tsCBV7fXOCkK1XszptQ+/Ng2x3gg6v/JKIRL yofuxYoTP/xoUcLrs2ArKA9ettf3ppSCFUJ0Bqm1HtQgYu3LXVVrO/eEIUfDiDcY5bOX B0y1dqPx9TG2qsZrEPYJCJnBXCY2YTxnWoLjuZ3htd5ZU4L/aJBRqYjxrdFWVatrjFyp JBXPjQQEOiHI+pxX0/NeAHqP18hQKUUw3AbtPnS0ETomuLi3BBSjtiQnfm1QubNBDpF2 FVTE9I/L0xARlqZfBmSZywpQbZmGQWw6vPWKffDA1l3816cPCF9ekerd6GHfdr6pdHmY YYeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ks3a5uwjYZy9dG49mabRmV2dX32QSZuoaC02/Xl7ftE=; b=pS9e5OGWiVk5nMTop8nrlvkzvKsd/GkXLw/Pu0DQHOlOwOvINfBQ4OiPeMssqhMHd5 oAHJiSMJyP0J8ck+gOQataLRzOEQyjNAm4BQynXjj/XEH/CXJtyul3QEnqDEya/cxoqE We3OUtkzTfjqpIK8JiBeuyovlGKEo0x6z5RFb04cWw5N21kONE3mn2Mar7fXb+05Gp8c Ig/ZdFAz5/Xt+H/0aY8HFhdN5z8pVzPLAGEqTj0G+4D/U4qIo2rACaN6DDqGzfLQdaQ4 dq6Qshk57Rj+OXLBlTDqXjHdcjwIzP+2D4SCyWqnZNUFac0xLDCXcABHhEQzbWCkpM3Z /S/g== X-Gm-Message-State: ANoB5pmatLSxBQ/az8yeCpyUe5CfJa+3/v3wxl9uwvKbdaLk1aGPt5gf glwIOzKNIX6Hpmnhqsf5r7g= X-Google-Smtp-Source: AA0mqf45jmNkCV6XBwCEKbRX8otCtBd7IBlgDQAP+MvPNkuF9ym58FVY3P4v1+OGnLSDkfph9i8oug== X-Received: by 2002:a63:c46:0:b0:476:ed2a:6228 with SMTP id 6-20020a630c46000000b00476ed2a6228mr675355pgm.137.1669044400329; Mon, 21 Nov 2022 07:26:40 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id mg24-20020a17090b371800b002071ee97923sm10576080pjb.53.2022.11.21.07.26.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 07:26:39 -0800 (PST) Content-Type: multipart/mixed; boundary="------------VABmPO0EnLq8e0u3HkDi8kDK" Message-ID: <1952901d-e16d-c626-d3a7-f95398c92e9e@gmail.com> Date: Mon, 21 Nov 2022 08:26:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Add RVV registers register spilling Content-Language: en-US To: "juzhe.zhong@rivai.ai" , schwab Cc: gcc-patches , "monk.chiang" , "kito.cheng" , jiawei References: <20221106085633.267351-1-juzhe.zhong@rivai.ai> <875yfageql.fsf@linux-m68k.org> <20221121163829759542114@rivai.ai> <833F883F0CA80822+20221121172503206590116@rivai.ai> From: Jeff Law In-Reply-To: <833F883F0CA80822+20221121172503206590116@rivai.ai> X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------VABmPO0EnLq8e0u3HkDi8kDK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/21/22 02:25, juzhe.zhong@rivai.ai wrote: > https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606523.html > This patch obviously didn't include scalable size frame. > So it ICE in offset = cfun->machine->frame.gp_sp_offset.to_constant (); > We can't directly use to_constant if the frame is a scalable. > Please fix it or revert it. Thanks We probably just need to reject everything in riscv_get_setparate_components if the offset isn't constant. Something like the attached patch (untested) might be enough to resolve the problem. Jeff --------------VABmPO0EnLq8e0u3HkDi8kDK Content-Type: text/plain; charset=UTF-8; name="P" Content-Disposition: attachment; filename="P" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvcmlzY3YvcmlzY3YuY2MgYi9nY2MvY29uZmlnL3Jp c2N2L3Jpc2N2LmNjCmluZGV4IDdlYzRjZTk3ZTZjLi43YmZjMGU5ZjU5NSAxMDA2NDQKLS0t IGEvZ2NjL2NvbmZpZy9yaXNjdi9yaXNjdi5jYworKysgYi9nY2MvY29uZmlnL3Jpc2N2L3Jp c2N2LmNjCkBAIC01MzQwLDcgKzUzNDAsOCBAQCByaXNjdl9nZXRfc2VwYXJhdGVfY29tcG9u ZW50cyAodm9pZCkKICAgYml0bWFwX2NsZWFyIChjb21wb25lbnRzKTsKIAogICBpZiAocmlz Y3ZfdXNlX3NhdmVfbGliY2FsbCAoJmNmdW4tPm1hY2hpbmUtPmZyYW1lKQotICAgICAgfHwg Y2Z1bi0+bWFjaGluZS0+aW50ZXJydXB0X2hhbmRsZXJfcCkKKyAgICAgIHx8IGNmdW4tPm1h Y2hpbmUtPmludGVycnVwdF9oYW5kbGVyX3AKKyAgICAgIHx8ICFjZnVuLT5tYWNoaW5lLT5m cmFtZS5ncF9zcF9vZmZzZXQuaXNfY29uc3RhbnQgKCkpCiAgICAgcmV0dXJuIGNvbXBvbmVu dHM7CiAKICAgb2Zmc2V0ID0gY2Z1bi0+bWFjaGluZS0+ZnJhbWUuZ3Bfc3Bfb2Zmc2V0LnRv X2NvbnN0YW50ICgpOwo= --------------VABmPO0EnLq8e0u3HkDi8kDK--