From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 412A63858C78 for ; Wed, 19 Jul 2023 21:57:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 412A63858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689803819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PwfYl7dxv7iQRfFOv7URD5gQSovzzvjOMfl7kTcy6KQ=; b=BZiuSTHnP8oxvZHB7ghH+r3GX/chzFU8Lz2cwEvfGWmvMdUu1BT7JS2H6rcaorZ0sW21UT YXXGCne9BwuzJPltQ/pXX3cYAhDveOqjQoDdQbpfNefMXodjy0y2x3/R+YnXWOvOi+1Hml oWoQ7ekZ+YHmBQK6SVcHhmug2ffMNLw= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-ule9QeLpOYGj7_ZKyNx5kg-1; Wed, 19 Jul 2023 17:56:58 -0400 X-MC-Unique: ule9QeLpOYGj7_ZKyNx5kg-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-76843c4b0f3so19318785a.2 for ; Wed, 19 Jul 2023 14:56:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689803817; x=1692395817; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PwfYl7dxv7iQRfFOv7URD5gQSovzzvjOMfl7kTcy6KQ=; b=jUlBAjNiXqUCnJ2gYTlON1PQgde/AK4125aed3oZl+Hd3KhgBsnDpP7rXD9XfH5GqG aNTB+wI13edRSx3yC8GsBpC3afBbrvZkzqNanWBxGv5HtSkS8erotPK8usMDiuxgmyOb fFp8nKGFAmH/0dFEOPxP01bLQhv+oGvxUKdDWxhyy+wwUHrHSK9AZKPH0r9bM78dXvR7 RhkPew9OpOHFc3DIwc2A+N63gNiPrTQqO5AanuV8hbHymNzHBjPR8rQn7cOMOolRNjWQ hKsMJLZrOYqfcGJkRTrybTK4/i8uPMKAO8C4AFXgK1E49C/rxpZZmS4kxulmoyZ77XR+ ZYNw== X-Gm-Message-State: ABy/qLamJj1jzUNWD/wGO533N/v2pWXpII7DZj/kkuuLZ3UjQjRL9wzK Lkpr14oe2JA/MPmXBhz41vcPynF593Lm+gf5PJurp5xpyOGY1+YdqugKy36M6hQGsjeP2WVSHJJ 0Q50Zb1OBjrt/giOVsg== X-Received: by 2002:a05:620a:4bc9:b0:767:2e5a:cc with SMTP id sw9-20020a05620a4bc900b007672e5a00ccmr3362921qkn.26.1689803817676; Wed, 19 Jul 2023 14:56:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlH8X5AJlRnhtGOUCy8idLvzLSSEk8fMD3zMuLd7lhbzdFZUIpTIZ8rhpNaZdiOjT7Jk4Cg0xA== X-Received: by 2002:a05:620a:4bc9:b0:767:2e5a:cc with SMTP id sw9-20020a05620a4bc900b007672e5a00ccmr3362913qkn.26.1689803817301; Wed, 19 Jul 2023 14:56:57 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id h7-20020ac85147000000b00403b3156f18sm1633147qtn.8.2023.07.19.14.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 14:56:56 -0700 (PDT) Message-ID: <195b8bc2-fbb9-3e73-9cf3-a048a7eaa6a0@redhat.com> Date: Wed, 19 Jul 2023 17:56:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] c++: Improve printing of base classes [PR110745] To: Marek Polacek , GCC Patches References: <20230719215122.513059-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20230719215122.513059-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/19/23 17:51, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? OK, thanks. > -- >8 -- > > This patch changes > > warning: missing initializer for member 'D::' [-Wmissing-field-initializers] > > to > > warning: missing initializer for member 'D::B' [-Wmissing-field-initializers] > > PR c++/110745 > > gcc/cp/ChangeLog: > > * error.cc (dump_simple_decl): Print base class name. > > gcc/testsuite/ChangeLog: > > * g++.dg/diagnostic/base.C: New test. > --- > gcc/cp/error.cc | 2 ++ > gcc/testsuite/g++.dg/diagnostic/base.C | 16 ++++++++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/diagnostic/base.C > > diff --git a/gcc/cp/error.cc b/gcc/cp/error.cc > index 31319aa9e87..8a5219a68a1 100644 > --- a/gcc/cp/error.cc > +++ b/gcc/cp/error.cc > @@ -1177,6 +1177,8 @@ dump_simple_decl (cxx_pretty_printer *pp, tree t, tree type, int flags) > } > else if (DECL_DECOMPOSITION_P (t)) > pp_string (pp, M_("")); > + else if (TREE_CODE (t) == FIELD_DECL && DECL_FIELD_IS_BASE (t)) > + dump_type (pp, TREE_TYPE (t), flags); > else > pp_string (pp, M_("")); > > diff --git a/gcc/testsuite/g++.dg/diagnostic/base.C b/gcc/testsuite/g++.dg/diagnostic/base.C > new file mode 100644 > index 00000000000..1540414072e > --- /dev/null > +++ b/gcc/testsuite/g++.dg/diagnostic/base.C > @@ -0,0 +1,16 @@ > +// PR c++/110745 > +// { dg-do compile { target c++17 } } > +// { dg-options "-Wmissing-field-initializers" } > + > +struct B { int i; }; > +struct D : B { > + int x; > + int y; > +}; > + > +int > +main () > +{ > + D d = {.x=1, .y=2}; // { dg-warning "missing initializer for member .D::B." } > + (void)d; > +} > > base-commit: b1ae46bdd19fc2aaea41bc894168bdaf4799be80