public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	David Malcolm <dmalcolm@redhat.com>,
	Nathan Sidwell <nathan@acm.org>
Subject: Re: C++ PATCH for c++/91678 - wrong error with decltype and location wrapper
Date: Sun, 15 Sep 2019 14:18:00 -0000	[thread overview]
Message-ID: <1960c4f6-2d6f-f62c-e985-3885583110d6@redhat.com> (raw)
In-Reply-To: <20190906022455.GC14737@redhat.com>

On 9/5/19 9:24 PM, Marek Polacek wrote:
> They use
> non_lvalue_loc, but that won't create a NON_LVALUE_EXPR wrapper around a location
> wrapper.

That seems like the bug. maybe_lvalue_p should be true for 
VIEW_CONVERT_EXPR.

Jason

  parent reply	other threads:[~2019-09-15 14:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  2:25 Marek Polacek
2019-09-13  2:26 ` Marek Polacek
2019-09-15 14:18 ` Jason Merrill [this message]
2019-09-16 18:12   ` Marek Polacek
2019-09-18  3:59     ` Jason Merrill
2019-12-07  0:19       ` Marek Polacek
2019-12-07  4:03         ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1960c4f6-2d6f-f62c-e985-3885583110d6@redhat.com \
    --to=jason@redhat.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nathan@acm.org \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).