From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12221 invoked by alias); 15 Sep 2019 14:18:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12210 invoked by uid 89); 15 Sep 2019 14:18:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:310, marek, Polacek, Marek X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Sep 2019 14:18:34 +0000 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CED63295 for ; Sun, 15 Sep 2019 14:18:33 +0000 (UTC) Received: by mail-qt1-f198.google.com with SMTP id h10so2628529qtq.11 for ; Sun, 15 Sep 2019 07:18:33 -0700 (PDT) Received: from [172.16.41.86] ([198.168.27.218]) by smtp.gmail.com with ESMTPSA id o8sm11783107qte.47.2019.09.15.07.18.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Sep 2019 07:18:31 -0700 (PDT) Subject: Re: C++ PATCH for c++/91678 - wrong error with decltype and location wrapper To: Marek Polacek , GCC Patches , David Malcolm , Nathan Sidwell References: <20190906022455.GC14737@redhat.com> From: Jason Merrill Message-ID: <1960c4f6-2d6f-f62c-e985-3885583110d6@redhat.com> Date: Sun, 15 Sep 2019 14:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190906022455.GC14737@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00906.txt.bz2 On 9/5/19 9:24 PM, Marek Polacek wrote: > They use > non_lvalue_loc, but that won't create a NON_LVALUE_EXPR wrapper around a location > wrapper. That seems like the bug. maybe_lvalue_p should be true for VIEW_CONVERT_EXPR. Jason