From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id D8E633858CDA for ; Sun, 31 Jul 2022 15:24:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D8E633858CDA Received: by mail-pl1-x629.google.com with SMTP id z19so8417122plb.1 for ; Sun, 31 Jul 2022 08:24:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vOZLSEjAI0qBIEmAtlaOxvkhkZNkyZD5nqCVN6aIkPo=; b=wiQinu8tO1LttRuIQSKFBYRyPuQ9q0M2AqUXb8X07SvgzHHeFLOK4l6ENSzC2m+CZi KFR9UWeHPVDbQFEJCxUfeBIriH56Y3oUnw2gof2rnsnFOSOzHFxcBe2Rc79uaFtpU1AK giQiDBlmV8zt+tNxhhVqeoNZ2cOR6EAbe6JCFHvSy5Ri7YqL7077F7guZhlxAhkGPRuO Ja7wE8tDLnhDi5FbE6dgD40jbiq5IiFnCt95QLF5mdRTKgHiHzFm7mXr7aqi8h3yy/ci 0qfRvOXP8ZOdfcnkiRZ5DrngOk1GuOoU9ctr9ZFOTxKKLTmgpfDPgSZ027jQ7Evp1qBH Losw== X-Gm-Message-State: ACgBeo0bQgl20mECgftBRD2lo+Jh3ha6w30sxEfo57P7j/9wni4C729T SGYPTK3r54VYXmvq1PkQ90U= X-Google-Smtp-Source: AA6agR4Np13AQuue3A5mM1frH64tqw4L/TPSaYMzQKn2f1yzJbSsrYikt8h1L9zh98bZQz4BMWIl7Q== X-Received: by 2002:a17:90b:4d05:b0:1e2:bf91:8af2 with SMTP id mw5-20020a17090b4d0500b001e2bf918af2mr14787781pjb.210.1659281048585; Sun, 31 Jul 2022 08:24:08 -0700 (PDT) Received: from [172.31.0.204] (c-73-98-188-51.hsd1.ut.comcast.net. [73.98.188.51]) by smtp.gmail.com with ESMTPSA id e4-20020a17090301c400b0016bf5557690sm7634923plh.4.2022.07.31.08.24.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Jul 2022 08:24:07 -0700 (PDT) Message-ID: <19698f34-543c-d436-33bf-b18153f7ad7e@gmail.com> Date: Sun, 31 Jul 2022 09:24:06 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] c: Fix location for _Pragma tokens [PR97498] Content-Language: en-US To: Lewis Hyatt Cc: gcc-patches List References: <20220709205230.GA4991@ldh-imac.local> <377c7016-633c-f354-8c21-599ff2b56449@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2022 15:24:11 -0000 On 7/31/2022 6:44 AM, Lewis Hyatt wrote: > On Sat, Jul 30, 2022 at 10:43 PM Jeff Law wrote: >>> There was a request to backport this >>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97498#c7) since it is >>> relevant to this one: >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106267. Is that OK as >>> well for any of the current release branches please? It will work fine >>> as far back as 10. Thanks... >> Generally we try to focus mostly on codegen issues and regressions on >> the release branches, but it's not a strict rule. Given this has been >> on the trunk for nearly a couple weeks without issues, feel free to go >> ahead and backport per Martin's request. >> >> jeff > Thank you, I'll do that. One question, does a backport need to be an > exact cherry-pick, or is it OK if I need to tweak a few things as > well? I wasn't sure if I need to re-post the patch here in that case. > The patch itself applies to gcc 12 branch fine, however I think I need > a couple small changes to the testsuite parts. Thanks... I personally prefer cherry-pick when we can, but as you note, sometimes minor twiddling is necessary, particularly as you go to older and older branches.  If you need to make minor changes, go ahead.  Consider the patch pre-approved with any minor changes you need to make to work with the branch and just post the patch with a note that it was installed as pre-approved. Jeff