From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80679 invoked by alias); 21 Dec 2017 17:19:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 80669 invoked by uid 89); 21 Dec 2017 17:19:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=H*f:sk:a0293ed, H*f:sk:b5538b3, H*f:sk:ea083a8, H*i:sk:ea083a8 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 17:19:46 +0000 Received: from svr-orw-mbx-04.mgc.mentorg.com ([147.34.90.204]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1eS4VT-00009K-Vh from Cesar_Philippidis@mentor.com for gcc-patches@gcc.gnu.org; Thu, 21 Dec 2017 09:19:44 -0800 Received: from [127.0.0.1] (147.34.91.1) by SVR-ORW-MBX-04.mgc.mentorg.com (147.34.90.204) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 21 Dec 2017 09:19:41 -0800 Subject: Re: [PATCH,PTX] Add support for CUDA 9 To: Tom de Vries CC: "gcc-patches@gcc.gnu.org" References: <002bf03f-baad-5809-6e9a-2fdffa0c1e2c@codesourcery.com> From: Cesar Philippidis Message-ID: <19831d57-118f-1ef7-b360-0dc0ba905688@codesourcery.com> Date: Thu, 21 Dec 2017 17:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To SVR-ORW-MBX-04.mgc.mentorg.com (147.34.90.204) X-SW-Source: 2017-12/txt/msg01431.txt.bz2 On 12/20/2017 03:15 PM, Tom de Vries wrote: > On 12/20/2017 11:59 PM, Cesar Philippidis wrote: >> On 12/19/2017 04:39 PM, Tom de Vries wrote: >>> On 12/20/2017 12:25 AM, Cesar Philippidis wrote: >>>> In CUDA 9, Nvidia removed support for treating the labels of functions >>>> as generic address spaces as part of their PTX 6.0 changes. More >>>> specifically, >>>> : >>>> >>>> >>>> >>>>     Support for taking address of labels, using labels in initializers >>>>     which was unimplemented has been removed from the spec. >>>> >>>> Despite targeting PTX 3.0, the ptxas assembler shipped with CUDA 9 no >>>> longer support that legacy functionality. Consequently, this prevented >>>> newlib from building. This patch fixes that problem by not using a >>>> generic address space when initializing variables using a label >>>> address. >>>> >>> >>> What is the effect for pre-9.0 cudas? >> >> No change in the libgomp execution test suite as an accelerator. >> >>>> Is this OK for trunk? >>>> >>> >>> How did you test this? >> >> Just libgomp as an accelerator for now. I'm trying to get standalone >> nvptx working right now. > > Indeed, you should test that as well, both with 9.0 and pre 9.0 cuda. > >> Which testsuites do you usually run? I only see >> the test results for check-gcc-c in your nightly build bot. >> > > The gcc test suite should be enough. My test results are somewhat inconsistent. On MG's build servers, there are no regressions in CUDA 8. On my laptop, there are fewer regressions in CUDA 9, than CUDA 8. However, I think some of those failures are due to premature timeouts on my laptop (I'm setting dejagnu to timeout after 90s instead of 5m locally). I know your on vacation, so I'll commit this patch to og7. We can revisit the patch for trunk and other backports later. Thanks, Cesar