From: Mikael Pettersson <mikpe@it.uu.se>
To: Richard Sandiford <richard.sandiford@linaro.org>
Cc: Andreas Krebbel <krebbel@linux.vnet.ibm.com>,
gcc-patches@gcc.gnu.org, rth@redhat.com
Subject: Re: Cleaning up expand optabs code
Date: Tue, 29 Mar 2011 12:26:00 -0000 [thread overview]
Message-ID: <19857.52792.228466.501327@pilspetsen.it.uu.se> (raw)
In-Reply-To: <g4mxkkvhqv.fsf@linaro.org>
Richard Sandiford writes:
> Andreas Krebbel <krebbel@linux.vnet.ibm.com> writes:
> > On 03/22/2011 06:48 PM, Richard Henderson wrote:
> >
> >> Ok. Watch out for other target problems this week.
> >
> > This unfortunately broke bootstrap on s390.
>
> This is PR 48263. Since it seems to be affecting several targets,
> and since my bootstrap seems to be taking a looong time, I'll post
> the patch here before testing has finished.
>
> > Just copying the pre-patch behaviour fixes the problem for me:
>
> I think we need to undo more of the patch, and leave the conversion
> outside of the new interface.
>
> Sorry for the breakage.
>
> Richard
>
>
> gcc/
> PR rtl-optimization/48263
> * optabs.c (expand_binop_directly): Reinstate convert_modes code
> and original commutative_p handling. Use maybe_gen_insn.
Unfortunately this fix (r171418) broke m68k-linux, see
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48332
/Mikael
next prev parent reply other threads:[~2011-03-29 12:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 16:33 Richard Sandiford
2011-03-17 19:20 ` Richard Henderson
2011-03-19 19:53 ` Richard Sandiford
2011-03-21 19:27 ` Richard Henderson
2011-03-21 21:39 ` Richard Sandiford
2011-03-22 15:09 ` Richard Sandiford
2011-03-22 17:49 ` Richard Henderson
2011-03-23 18:01 ` Anatoly Sokolov
2011-03-24 10:04 ` Richard Sandiford
2011-03-24 12:01 ` Andreas Krebbel
2011-03-24 12:13 ` Richard Sandiford
2011-03-24 15:09 ` Richard Sandiford
2011-03-24 17:09 ` Richard Henderson
2011-03-29 12:26 ` Mikael Pettersson [this message]
2011-03-29 13:27 ` Richard Sandiford
2011-03-29 14:27 ` Mikael Pettersson
2011-03-29 22:01 ` Richard Sandiford
2011-03-29 22:14 ` Richard Henderson
2011-03-30 9:13 ` Richard Sandiford
2011-03-30 15:23 ` Richard Henderson
2011-03-25 12:58 ` Georg-Johann Lay
2011-03-25 13:00 ` Georg-Johann Lay
2011-03-25 17:35 ` Richard Henderson
2011-03-25 17:56 ` Richard Sandiford
2011-03-25 18:30 ` Richard Sandiford
2011-03-25 18:31 ` Richard Sandiford
2011-03-25 19:23 ` Richard Henderson
2011-03-26 2:51 ` Richard Henderson
2011-03-31 10:00 ` Georg-Johann Lay
2011-03-31 12:57 ` Richard Sandiford
2011-04-01 12:54 ` Georg-Johann Lay
2011-03-24 15:14 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19857.52792.228466.501327@pilspetsen.it.uu.se \
--to=mikpe@it.uu.se \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
--cc=richard.sandiford@linaro.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).