From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1816 invoked by alias); 29 Mar 2011 12:19:16 -0000 Received: (qmail 1803 invoked by uid 22791); 29 Mar 2011 12:19:14 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fanny.its.uu.se (HELO fanny.its.uu.se) (130.238.4.241) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Mar 2011 12:19:09 +0000 Received: from fanny.its.uu.se (localhost [127.0.0.1]) by fanny.its.uu.se (Postfix) with ESMTP id 6174A625B; Tue, 29 Mar 2011 14:19:07 +0200 (MSZ) Received: from pilspetsen.it.uu.se (pilspetsen.it.uu.se [130.238.18.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by fanny.its.uu.se (Postfix) with ESMTP id DFFBF6466; Tue, 29 Mar 2011 14:19:06 +0200 (MSZ) Received: (from mikpe@localhost) by pilspetsen.it.uu.se (8.14.4+Sun/8.14.4) id p2TCJ4o5022797; Tue, 29 Mar 2011 14:19:04 +0200 (MEST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19857.52792.228466.501327@pilspetsen.it.uu.se> Date: Tue, 29 Mar 2011 12:26:00 -0000 From: Mikael Pettersson To: Richard Sandiford Cc: Andreas Krebbel , gcc-patches@gcc.gnu.org, rth@redhat.com Subject: Re: Cleaning up expand optabs code In-Reply-To: References: <4D825EF5.1010307@redhat.com> <87wrju28hn.fsf@firetop.home> <4D87A69B.90704@redhat.com> <4D88E10A.8080005@redhat.com> <4D8B32A9.9050309@linux.vnet.ibm.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg01986.txt.bz2 Richard Sandiford writes: > Andreas Krebbel writes: > > On 03/22/2011 06:48 PM, Richard Henderson wrote: > > > >> Ok. Watch out for other target problems this week. > > > > This unfortunately broke bootstrap on s390. > > This is PR 48263. Since it seems to be affecting several targets, > and since my bootstrap seems to be taking a looong time, I'll post > the patch here before testing has finished. > > > Just copying the pre-patch behaviour fixes the problem for me: > > I think we need to undo more of the patch, and leave the conversion > outside of the new interface. > > Sorry for the breakage. > > Richard > > > gcc/ > PR rtl-optimization/48263 > * optabs.c (expand_binop_directly): Reinstate convert_modes code > and original commutative_p handling. Use maybe_gen_insn. Unfortunately this fix (r171418) broke m68k-linux, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48332 /Mikael