From: "François-Xavier Coudert" <fxcoudert@gmail.com>
To: "Jerry DeLisle" <jvdelisle@verizon.net>
Cc: "Fortran List" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] PR31201 Too large unit number generates wrong code
Date: Wed, 04 Apr 2007 06:52:00 -0000 [thread overview]
Message-ID: <19c433eb0704032352r10fc77b5jc0b4a952e66022cb@mail.gmail.com> (raw)
In-Reply-To: <46134371.3030400@verizon.net>
> No, I do not disagree with you. I was very bothered about changing the size of
> unit. I would appreciate your assistance on the front end. I got as far as
> determining if the value provided is int8. Without the patch here, the
> front-end is converting that to int4. I will study your repeat patch and we can
> email off list to work this.
Fine with me.
> Also, take a look at what happens to exe_path in main.c. Somewhere in there we
> get unfreed memory.
Hum, I wrote that part and remember thinking: we never free exe_path,
but then it's only allocated once. That was before everyone started to
run valgrind :) Does the following fix it for you?
Index: runtime/main.c
===================================================================
--- runtime/main.c (revision 123388)
+++ runtime/main.c (working copy)
@@ -170,4 +170,5 @@
cleanup (void)
{
close_units ();
+ free (exe_path);
}
prev parent reply other threads:[~2007-04-04 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 4:53 Jerry DeLisle
2007-04-04 5:47 ` FX Coudert
2007-04-04 6:21 ` Jerry DeLisle
2007-04-04 6:52 ` François-Xavier Coudert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c433eb0704032352r10fc77b5jc0b4a952e66022cb@mail.gmail.com \
--to=fxcoudert@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jvdelisle@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).