* [Patch]: Set USE_GTHREAD_WEAK on mingw32 to 0
@ 2007-07-30 2:13 Danny Smith
2007-07-30 12:47 ` FX Coudert
2007-08-13 12:22 ` François-Xavier Coudert
0 siblings, 2 replies; 3+ messages in thread
From: Danny Smith @ 2007-07-30 2:13 UTC (permalink / raw)
To: GFORTRAN, GCC-patches
Hello,
PR 32915 exposed a bug in the configury of GTHREAD_USE_WEAK for mingw32
library host. Normally, mingw32 would not use gthr-posix.h, so the
question of GTHREAD_USE_WEAK would be moot. However, if for whatever
reason, someone want to use gthr-posix.h, then weak references will not
do the right thing on mingw32 if the win32-pthread lib is a dll.
In short, .weak directive, as handled by current gas, does not work if
the symbol is in a win32 dll, since each 'object' of a dll import lib
defines only one symbol.
This fixes.
2007-07-30 Danny Smith <dannysmit@users.sourceforge.net>
* acinclude.m4 (GTHREAD_USE_WEAK) Define to 0 for mingw32.
* configure: Regenerate.
Index: acinclude.m4
===================================================================
--- acinclude.m4 (revision 126996)
+++ acinclude.m4 (working copy)
@@ -128,7 +128,7 @@
[Define to 1 if the target supports #pragma weak])
fi
case "$host" in
- *-*-darwin* | *-*-hpux* | *-*-cygwin*)
+ *-*-darwin* | *-*-hpux* | *-*-cygwin* | *-*-mingw* )
AC_DEFINE(GTHREAD_USE_WEAK, 0,
[Define to 0 if the target shouldn't use #pragma weak])
;;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch]: Set USE_GTHREAD_WEAK on mingw32 to 0
2007-07-30 2:13 [Patch]: Set USE_GTHREAD_WEAK on mingw32 to 0 Danny Smith
@ 2007-07-30 12:47 ` FX Coudert
2007-08-13 12:22 ` François-Xavier Coudert
1 sibling, 0 replies; 3+ messages in thread
From: FX Coudert @ 2007-07-30 12:47 UTC (permalink / raw)
To: Danny Smith; +Cc: GFORTRAN, GCC-patches
> 2007-07-30 Danny Smith <dannysmit@users.sourceforge.net>
>
> * acinclude.m4 (GTHREAD_USE_WEAK) Define to 0 for mingw32.
> * configure: Regenerate.
OK to apply to libgfortran/acinclude.m4.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch]: Set USE_GTHREAD_WEAK on mingw32 to 0
2007-07-30 2:13 [Patch]: Set USE_GTHREAD_WEAK on mingw32 to 0 Danny Smith
2007-07-30 12:47 ` FX Coudert
@ 2007-08-13 12:22 ` François-Xavier Coudert
1 sibling, 0 replies; 3+ messages in thread
From: François-Xavier Coudert @ 2007-08-13 12:22 UTC (permalink / raw)
To: Danny Smith; +Cc: GFORTRAN, GCC-patches
> 2007-07-30 Danny Smith <dannysmit@users.sourceforge.net>
>
> * acinclude.m4 (GTHREAD_USE_WEAK) Define to 0 for mingw32.
> * configure: Regenerate.
Committed to mainline as rev. 127395.
FX
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-13 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-30 2:13 [Patch]: Set USE_GTHREAD_WEAK on mingw32 to 0 Danny Smith
2007-07-30 12:47 ` FX Coudert
2007-08-13 12:22 ` François-Xavier Coudert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).