From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 38070385F009 for ; Mon, 30 Oct 2023 15:12:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38070385F009 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38070385F009 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698678760; cv=none; b=SMiHxThb99YxZkHDUcmq+qoRzTAgmujzWDT0/o3B+sZ5czv5yWhx0u4MIskiigns2hy42QQX5uO4Z2cNATkAC2lAbJxxLwSZ9xk3PaV1JI+fRc4Jitf7ZAvIlicQ17to0dTrQColar/mTA2ACfwwPgwvymEcwlFrxpzRWt1AO/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698678760; c=relaxed/simple; bh=TfecqvRRTzqhWqhojY366CMbvboMkhX8KT/a8r0HSUg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JiKEsVRzQ3cu030k1WBmUfo+Vk36K1GADHgStp0pjsqlwlnbgEAljDG63X3PykbxuU5P70xSa2G0DaatgQB5i0bI7Omq70ZzDmVGpxAbSA64NL7m0bEKABW2YCy4B3VDZGI2CskwqSwtkBBCPu8Yg2POOaCcKc02xkuINpL9UCE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1cc5fa0e4d5so1994235ad.0 for ; Mon, 30 Oct 2023 08:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698678758; x=1699283558; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PLr2e5i/1vr6LxZWxCxiJujCfqd/KQijf8cVnUBG4Lc=; b=KBuwx2uieH3eKMjSCTs22Sf9GM9XGC0mdfT8C9Ax3kdBdUFxtTtt/ttDUZodWRzCJf JHXExrQ/5vvz9PrSXV9ee5dQ7LR4rSrrbAo4p/KvRe134Z8/aQeKl2naa189EA8+K9bA 9SyAk9MF7auJwQrtpIwrRd4uaCpeg39yeGqmOzv1kuVcODlrNSEJOiTT1bdR+tWegjJG CWgvf3jd4X11qzQPgZtO9BR4zSLU6qLOfH/wVH2AFoTTKA2XSUQvJgbqVR8LWCGjXPuy ii3TTdPDSpCEOp9QSR8maHZBByuGnnqiV2bNTZ3kx44OU/E3N30tlUvBWEO8LK2QyhOr Ur/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698678758; x=1699283558; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PLr2e5i/1vr6LxZWxCxiJujCfqd/KQijf8cVnUBG4Lc=; b=OgIGEKyKRt+rlUJiK24k+XWnKFkkRtQUR23Ic/ugU7n4EESYBQuA26cX5vLhoKi4fR e/ECoECoHWvOMOMc9e+lnUGGiDiL9LHhD4Y7yzzmcZyzIbQ2JUUud1s7KxgNRo750iHh SJ04m8924IjV8AIAyqs2Qf5vHyE3JhE0FiULkwtOTxy8/GKAf2oh4SXilC91JBcxE4b3 EbXhMDrGUAmDn4I6wTrujdgl3fK+vV+v95c7l6WOyXS4R6bVnGQCYkHDx38Q9hw1/D+/ 0AdaVGjOvStJRcYJfavKQtn0nigg8jFkvnbQR/0y2PJFfZz+fpNDxEs+iByBqXtGBezB NdlQ== X-Gm-Message-State: AOJu0Yzuw7nKJSH8nauulL4tfN+K/46lA4nESoegntEyzG1MlhB4fReX bdVskFZtcuoNCDwbbvFUqsw= X-Google-Smtp-Source: AGHT+IEmAToAAcmEqVYUq/bRze3sOmnKNCBzfCuQTynYKbAKWi72P3K+yqt5vkVtO0/74cQjgL4QRA== X-Received: by 2002:a17:903:1104:b0:1ca:29f:4b06 with SMTP id n4-20020a170903110400b001ca029f4b06mr13399275plh.2.1698678757959; Mon, 30 Oct 2023 08:12:37 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id bd11-20020a170902830b00b001c7283d3089sm6355060plb.273.2023.10.30.08.12.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 08:12:37 -0700 (PDT) Message-ID: <19c6284d-eb0e-4a3b-aecd-3331d321fd76@gmail.com> Date: Mon, 30 Oct 2023 09:12:32 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] [RISC-V]add hook to control Zicond based ifcvt opt Content-Language: en-US To: Fei Gao , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com References: <20231030072523.26818-1-gaofei@eswincomputing.com> <20231030072523.26818-2-gaofei@eswincomputing.com> From: Jeff Law In-Reply-To: <20231030072523.26818-2-gaofei@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/30/23 01:25, Fei Gao wrote: > TARGET_HAVE_COND_ZERO is added to control ifcvt optimization > for targets with RISC-V Zicond like insns. > > Co-authored-by: Xiao Zeng > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_have_cond_zero): Implement TARGET_HAVE_COND_ZERO > (TARGET_HAVE_COND_ZERO): define RISC-V hook > * doc/tm.texi: add TARGET_HAVE_COND_ZERO > * doc/tm.texi.in: add TARGET_HAVE_COND_ZERO > * target.def: define TARGET_HAVE_COND_ZERO I'd like to avoid doing something like this. If we must query the target for information, I think the better choice would be to construct a conditional zero insn, then see if it's recognized. ie, why create a new target hook when we can ask the question using existing mechanisms. jeff